Re: [PATCH] Update and switch APIs call conflict resolver at end of operation

2013-03-27 Thread Julian Foad
; Sent: Wednesday, 27 March 2013, 12:31 > Subject: Re: [PATCH] Update and switch APIs call conflict resolver at end of > operation > > On Wed, Mar 27, 2013 at 12:22 PM, Julian Foad > wrote: >> Discussing the behaviour of the backward-compatibility APIs: >> >>

Re: [PATCH] Update and switch APIs call conflict resolver at end of operation

2013-03-27 Thread Mark Phippard
On Wed, Mar 27, 2013 at 12:22 PM, Julian Foad wrote: > Discussing the behaviour of the backward-compatibility APIs: > > > Bert wrote: >> I don't think the strict ordening will be a problem for old clients at the >> client level. We don't promis ordering in the ra layers anyway and we have >> chang

Re: [PATCH] Update and switch APIs call conflict resolver at end of operation

2013-03-27 Thread Julian Foad
Discussing the behaviour of the backward-compatibility APIs: Bert wrote: > I don't think the strict ordening will be a problem for old clients at the > client level. We don't promis ordering in the ra layers anyway and we have > changed the ordering many times before. As long as we call the callb

Re: [PATCH] Update and switch APIs call conflict resolver at end of operation

2013-03-26 Thread bert
I don’ t think the strict ordening will be a problem for old clients at the client level. We don't promis ordering in the ra layers anyway and we have changed the ordering many times before. As long as we call the callbacks I think clients would be fine. And it will solve the existing problem of

Re: [PATCH] Update and switch APIs call conflict resolver at end of operation

2013-03-26 Thread Julian Foad
Stefan Sperling wrote: > On Tue, Mar 26, 2013 at 04:26:33PM +, Julian Foad wrote: >> With this patch, subversion/svn/update-cmd.c:svn_cl__update() will do this: >> >>   * Call svn_client_update4(...) >> >>     - with ctx->conflict_func2 set to svn_cl__conflict_func_interactive() >>      

Re: [PATCH] Update and switch APIs call conflict resolver at end of operation

2013-03-26 Thread Stefan Sperling
On Tue, Mar 26, 2013 at 04:26:33PM +, Julian Foad wrote: > With this patch, subversion/svn/update-cmd.c:svn_cl__update() will do this: > >   * Call svn_client_update4(...) > >     - with ctx->conflict_func2 set to svn_cl__conflict_func_interactive() >       which does interactive or non-inter

Re: [PATCH] Update and switch APIs call conflict resolver at end of operation

2013-03-26 Thread Julian Foad
6 > Subject: [PATCH] Update and switch APIs call conflict resolver at end of > operation > > Following on from the fix for issue #4316 "Merge errors out after resolving > conflicts" r1459012, in which I made the merge APIs call the conflict > resolver callback for all

[PATCH] Update and switch APIs call conflict resolver at end of operation

2013-03-26 Thread Julian Foad
Following on from the fix for issue #4316 "Merge errors out after resolving conflicts" r1459012, in which I made the merge APIs call the conflict resolver callback for all conflicts before returning, I mentioned that we should do the same for update and switch [1].  I'll explain a bit more. Cur