Re: [PATCH] Unlocking a file and pre-unlock hook failure

2011-06-14 Thread Philip Martin
vijay writes: > I have attached a patch which tests whether the error message contains > "500 Internal Server Error"(In case of ra_serf/ra_neon) or the "error > text"(in case of ra_local). Committed in r1135651. Thanks! -- Philip

Re: [PATCH] Unlocking a file and pre-unlock hook failure

2011-06-02 Thread vijay
On Thursday 02 June 2011 08:36 PM, Daniel Shahaf wrote: +#-- +def block_unlock_if_pre_unlock_hook_fails(sbox): + "block unlock operation if pre-unlock hook fails" + + sbox.build() + wc_dir = sbox.wc_dir + repo_dir = sbox.rep

Re: [PATCH] Unlocking a file and pre-unlock hook failure

2011-06-02 Thread Daniel Shahaf
vijay wrote on Thu, Jun 02, 2011 at 20:18:22 +0530: > On Thursday 02 June 2011 05:05 PM, Philip Martin wrote: > >vijay writes: > > > >>At the end of the testcase, I thought of checking the status of the > >>working copy with expected status as "writelocked=K". But I couldn't > >>do it as the test

Re: [PATCH] Unlocking a file and pre-unlock hook failure

2011-06-02 Thread vijay
On Thursday 02 June 2011 05:05 PM, Philip Martin wrote: vijay writes: At the end of the testcase, I thought of checking the status of the working copy with expected status as "writelocked=K". But I couldn't do it as the test raises exception in between, i.e., during unlock operation itself. I

Re: [PATCH] Unlocking a file and pre-unlock hook failure

2011-06-02 Thread Philip Martin
vijay writes: > At the end of the testcase, I thought of checking the status of the > working copy with expected status as "writelocked=K". But I couldn't > do it as the test raises exception in between, i.e., during unlock > operation itself. I don't understand this. With your patch the test i

[PATCH] Unlocking a file and pre-unlock hook failure

2011-06-01 Thread vijay
Hi, Last week, I was working on this issue: "Whenever the pre-unlock hook fails, Subversion server sends the error message "Unlock blocked by pre-unlock hook (exit code 1)" to Apache. But Apache's mod_dav is not handling the error and it is not sending any error messages to client side, i