Re: [PATCH] Speed-up of libsvn_diff by reworking fp argument

2011-05-29 Thread Stefan Fuhrmann
On 29.05.2011 16:01, Morten Kloster wrote: (stefan) wrote: Hi Morten, Did you activate compiler optimizations (e.g. use the release build in VS)? While your patch makes the code easier to read, the GCC output is the same as for the unchanged code - except for an additional NOP to ensure optimina

Re: [PATCH] Speed-up of libsvn_diff by reworking fp argument

2011-05-29 Thread Morten Kloster
(stefan) wrote: > Hi Morten, > Did you activate compiler optimizations (e.g. use the release build in VS)? > While your patch makes the code easier to read, the GCC output is > the same as for the unchanged code - except for an additional NOP > to ensure optiminal branch target alignment. > -- Stef

Re: [PATCH] Speed-up of libsvn_diff by reworking fp argument

2011-05-29 Thread Stefan Fuhrmann
On 27.05.2011 20:41, Morten Kloster wrote: [[[ Faster LCS algorithm in libsvn_diff by reworking fp argument * subversion/libsvn_diff/lcs.c (svn_diff__snake): fp and k arguments are added by caller ]]] Calling svn_diff__snake with fp+k as argument instead of both as separate arguments reduces

Re: [PATCH] Speed-up of libsvn_diff by reworking fp argument

2011-05-29 Thread Morten Kloster
Here is an updated version that resolves conflicts with revision 1128852. Index: subversion/libsvn_diff/lcs.c === --- subversion/libsvn_diff/lcs.c(revision 1128868) +++ subversion/libsvn_diff/lcs.c(working copy) @@ -48,

Re: [PATCH] Speed-up of libsvn_diff by reworking fp argument

2011-05-28 Thread Morten Kloster
On Fri, May 27, 2011 at 8:41 PM, Morten Kloster wrote: > [[[ > Faster LCS algorithm in libsvn_diff by reworking fp argument > > * subversion/libsvn_diff/lcs.c >  (svn_diff__snake): fp and k arguments are added by caller > ]]] > > Calling svn_diff__snake with fp+k as argument instead of both as > s

[PATCH] Speed-up of libsvn_diff by reworking fp argument

2011-05-27 Thread Morten Kloster
[[[ Faster LCS algorithm in libsvn_diff by reworking fp argument * subversion/libsvn_diff/lcs.c (svn_diff__snake): fp and k arguments are added by caller ]]] Calling svn_diff__snake with fp+k as argument instead of both as separate arguments reduces running time for the lcs algorithm substantia