Re: [PATCH] Simplify and optimize RA-svn's string marshalling

2011-06-14 Thread Stefan Fuhrmann
On 03.06.2011 10:52, Julian Foad wrote: Hi Stefan2 and others. This patch simplifies code in RA-svn/marshal.c by using a single code path to read both short and long strings efficiently. Using a single code path is beneficial for test coverage. It is an alternative to r1028352 which merg

Re: [PATCH] Simplify and optimize RA-svn's string marshalling

2011-06-08 Thread Julian Foad
Daniel Shahaf wrote: > But... isn't there a bug here? > > [[[ > Index: subversion/libsvn_ra_svn/marshal.c > === > --- subversion/libsvn_ra_svn/marshal.c(revision 1133231) > +++ subversion/libsvn_ra_svn/marshal.c(workin

Re: [PATCH] Simplify and optimize RA-svn's string marshalling

2011-06-07 Thread Daniel Shahaf
Julian Foad wrote on Mon, Jun 06, 2011 at 15:45:11 +0100: > On Fri, 2011-06-03, Daniel Shahaf wrote: > > Julian Foad wrote on Fri, Jun 03, 2011 at 09:52:21 +0100: > > > +++ subversion/libsvn_ra_svn/marshal.c(working copy) > > > @@ -563,36 +563,6 @@ svn_error_t *svn_ra_svn_write_tuple(svn_ > > >

Re: [PATCH] Simplify and optimize RA-svn's string marshalling

2011-06-06 Thread Julian Foad
On Fri, 2011-06-03, Daniel Shahaf wrote: > Julian Foad wrote on Fri, Jun 03, 2011 at 09:52:21 +0100: > > Hi Stefan2 and others. > > > > This patch simplifies code in RA-svn/marshal.c by using a single code > > path to read both short and long strings efficiently. Using a single > > code path is b

Re: [PATCH] Simplify and optimize RA-svn's string marshalling

2011-06-06 Thread Julian Foad
I (Julian Foad) wrote: > > On 03.06.2011 10:52, Julian Foad wrote: > > > Hi Stefan2 and others. > > > > > > This patch simplifies code in RA-svn/marshal.c by using a single code > > > path to read both short and long strings efficiently. Using a single > > > code path is beneficial for test covera

Re: [PATCH] Simplify and optimize RA-svn's string marshalling

2011-06-06 Thread Julian Foad
> On 03.06.2011 10:52, Julian Foad wrote: > > Hi Stefan2 and others. > > > > This patch simplifies code in RA-svn/marshal.c by using a single code > > path to read both short and long strings efficiently. Using a single > > code path is beneficial for test coverage. > > > > It is an alternative to

Re: [PATCH] Simplify and optimize RA-svn's string marshalling

2011-06-03 Thread Stefan Fuhrmann
On 03.06.2011 10:52, Julian Foad wrote: Hi Stefan2 and others. This patch simplifies code in RA-svn/marshal.c by using a single code path to read both short and long strings efficiently. Using a single code path is beneficial for test coverage. It is an alternative to r1028352 which merged r98

Re: [PATCH] Simplify and optimize RA-svn's string marshalling

2011-06-03 Thread Daniel Shahaf
Julian Foad wrote on Fri, Jun 03, 2011 at 09:52:21 +0100: > Hi Stefan2 and others. > > This patch simplifies code in RA-svn/marshal.c by using a single code > path to read both short and long strings efficiently. Using a single > code path is beneficial for test coverage. > > It is an alternativ

[PATCH] Simplify and optimize RA-svn's string marshalling

2011-06-03 Thread Julian Foad
Hi Stefan2 and others. This patch simplifies code in RA-svn/marshal.c by using a single code path to read both short and long strings efficiently. Using a single code path is beneficial for test coverage. It is an alternative to r1028352 which merged r985606 and r1028092 from the performance bra