Re: [PATCH] Revision 1297676 broke --list option of command line tests

2012-03-06 Thread Hyrum K Wright
On Tue, Mar 6, 2012 at 3:27 PM, Alexey Neyman wrote: > The code which accesses options.verbose is still there in some places, > including TestRunner.list(): > > 1071809     pburba       # If there is no filter or this test made if through > 1071809     pburba       # the filter then print it! > 10

Re: [PATCH] Revision 1297676 broke --list option of command line tests

2012-03-06 Thread Alexey Neyman
The code which accesses options.verbose is still there in some places, including TestRunner.list(): 1071809 pburba # If there is no filter or this test made if through 1071809 pburba # the filter then print it! 1071809 pburba if options.milestone_filter is None or le

Re: [PATCH] Revision 1297676 broke --list option of command line tests

2012-03-06 Thread Hyrum K Wright
I think the solution here is to rip out places that require options.verbose, rather than attempt to paper over the problem by resurrecting that field. I've attempted to do so in subsequent commits (see r1297724 and r1297725). -Hyrum On Tue, Mar 6, 2012 at 3:11 PM, Alexey Neyman wrote: > Argh, d

Re: [PATCH] Revision 1297676 broke --list option of command line tests

2012-03-06 Thread Alexey Neyman
Argh, damn. Last one: [[[ * subversion/tests/cmdline/svntest/main.py (_create_parser): Partially revert r1297676, other code needs options.verbose. (_parse_options): Call logger.setLevel(logging.DEBUG) if verbose output is requested. ]]] On Tuesday, Mar

Re: [PATCH] Revision 1297676 broke --list option of command line tests

2012-03-06 Thread Alexey Neyman
Please use the attached patch instead (the first one fixed "--list", but not "--list --verbose"). Regards, Alexey. On Tuesday, March 06, 2012 12:45:21 pm Alexey Neyman wrote: > Hi all, > > Revision 1297676 by hwright broke the command line tests' --list option > (and probably, some other interf

[PATCH] Revision 1297676 broke --list option of command line tests

2012-03-06 Thread Alexey Neyman
Hi all, Revision 1297676 by hwright broke the command line tests' --list option (and probably, some other interfaces): the options dict no longer contains verbose option as --verbose handler was changed from 'store_true' to 'callback'. The attached patch fixes it by reintroducing options.verbos