On Thu, Nov 3, 2016 at 10:27 AM, Bert Huijben wrote:
> I’m not sure about the perl rules applied around this function, but
> perhaps we should just copy the string instead of changing memory that we
> receive as constant. We might also have a different api function that
> behaves in a cleaner way
[mailto:roderich.sch...@gmail.com]
Sent: woensdag 2 november 2016 21:07
To: Daniel Shahaf
Cc: rai...@codingfarm.de; Subversion devel mailing list
Subject: Re: [PATCH] Perl bindings corrupt "{DATE}" revision variable
On Wed, Nov 2, 2016 at 8:41 PM, Daniel Shahaf mailto:danie...@apache.org> >
On Wed, Nov 2, 2016 at 8:41 PM, Daniel Shahaf wrote:
> Thanks, Roderich. Could you update the log message with an appropriate
> "Verbed by"[1] clause, for contribulyzer?
>
Done.
> I assume this should be backported, in which case, here is my +0 for
> backport of the patch as committed.
>
> No
roderich.sch...@gmail.com wrote on Wed, Nov 02, 2016 at 12:36:02 -0700:
> Commited as 1767768, slightly modified to address the above concerns.
Thanks, Roderich. Could you update the log message with an appropriate
"Verbed by"[1] clause, for contribulyzer?
I assume this should be backported, in
On Wednesday, November 2, 2016 at 7:48:04 PM UTC+1, Daniel Shahaf wrote:
>
> Do the perl bindings use C89, like libsvn*? C89 forbids middle-of-block
> declarations.
> ...
> The two maybe_croak() calls after this line (one of them in the patch
> context, one just below it) would now print two r
Rainer Müller wrote on Wed, Nov 02, 2016 at 18:29:04 +0100:
> Index: subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c
> ===
> --- subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c
> (revision 1767623)
> +++
Hello,
when passing a revision string in the form of "{DATE}" to the Perl
bindings, the passed string is unexpectedly modified during parsing and
the closing brace will be removed. Here is a Perl script reproducing the
issue with an example:
---8<---
use SVN::Client;
my $ctx = SVN::Client->new(
7 matches
Mail list logo
