Re: [PATCH] On the 'ra-git' branch: update to libgit2 v0.22

2015-04-01 Thread Julian Foad
Julian Foad wrote: > I'll try doing a catch-up merge from trunk as well, now. I did a catch-up as far as trunk@1664077 (which is a few weeks ago), resolving the few minor conflicts. One of the changes this merge brought in from trunk was a re-working of the part of autogen.sh that you fixed in you

Re: [PATCH] On the 'ra-git' branch: update to libgit2 v0.22

2015-04-01 Thread Julian Foad
Carlos, I committed your patch in r1670647 (without the quoting style change in autogen.sh). Thanks! I'll try doing a catch-up merge from trunk as well, now. - Julian

Re: [PATCH] On the 'ra-git' branch: update to libgit2 v0.22

2015-04-01 Thread Philip Martin
Julian Foad writes: > export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$HOME/.local/libgit2-0.20.0/lib > configure [...] --with-libgit2=$HOME/.local/libgit2-0.20.0 > > works. > > configure [...] --with-libgit2=$HOME/.local/libgit2-0.20.0 \ > LDFLAGS=-Wl,-rpath,$HOME/.local/libgit2-0.20.0/lib > > also wo

Re: [PATCH] On the 'ra-git' branch: update to libgit2 v0.22

2015-04-01 Thread Julian Foad
Philip Martin wrote: > Julian Foad writes: > >> --with-libgit2=/home/julianfoad/.local/libgit2-0.20.0 > >> /usr/bin/ld: warning: libgit2.so.0, needed by >> //nobackup/home/julianfoad/build/subversion-p/subversion/libsvn_ra_git/.libs/libsvn_ra_git-1.so.0, >> not found (try using -rpath or -rpath-li

Re: [PATCH] On the 'ra-git' branch: update to libgit2 v0.22

2015-04-01 Thread Philip Martin
Julian Foad writes: > --with-libgit2=/home/julianfoad/.local/libgit2-0.20.0 > /usr/bin/ld: warning: libgit2.so.0, needed by > //nobackup/home/julianfoad/build/subversion-p/subversion/libsvn_ra_git/.libs/libsvn_ra_git-1.so.0, > not found (try using -rpath or -rpath-link) > //nobackup/home/julianf

Re: [PATCH] On the 'ra-git' branch: update to libgit2 v0.22

2015-04-01 Thread Carlos Martín Nieto
On Tue, 2015-03-31 at 12:25 +0100, Julian Foad wrote: > On 31 March 2015 at 12:19, Julian Foad wrote: > > I wanted to commit this, but first I tried to build it and I'm getting > > link failure on Linux > > Of course you want to see the specifics of the link failure. > > [[[ > Start -- /home/jul

Re: [PATCH] On the 'ra-git' branch: update to libgit2 v0.22

2015-03-31 Thread Julian Foad
On 31 March 2015 at 12:19, Julian Foad wrote: > I wanted to commit this, but first I tried to build it and I'm getting > link failure on Linux Of course you want to see the specifics of the link failure. [[[ Start -- /home/julianfoad/src/subversion-p/configure --enable-maintainer-mode --prefix=/

Re: [PATCH] On the 'ra-git' branch: update to libgit2 v0.22

2015-03-31 Thread Julian Foad
I wanted to commit this, but first I tried to build it and I'm getting link failure on Linux, both with (the patch and libgit2-0.22) and also with (no patch and libgit2-0.20). The wierd thing is, last April I successfully built it with libgit2-0.20, and my installation of libgit2-0.20 hasn't been t

Re: [PATCH] On the 'ra-git' branch: update to libgit2 v0.22

2015-03-30 Thread James McCoy
On Tue, Mar 31, 2015 at 12:13:09AM +0200, Branko Čibej wrote: > On 30.03.2015 20:26, Daniel Shahaf wrote: > > Carlos Martín Nieto wrote on Mon, Mar 30, 2015 at 16:58:57 +0200: > >> +++ autogen.sh (working copy) > >> -configfile=${LIBTOOL_CONFIG-`cd $ltpath/../share/libtool/config ; > >

Re: [PATCH] On the 'ra-git' branch: update to libgit2 v0.22

2015-03-30 Thread Ben Reser
On 3/30/15 3:13 PM, Branko Čibej wrote: > It is not. autogen.sh must not require bash. $() is not a bash'ism. It's actually in POSIX. But for whatever reason Solaris' sh does not support it so both of you are correct we can't use it.

Re: [PATCH] On the 'ra-git' branch: update to libgit2 v0.22

2015-03-30 Thread Branko Čibej
On 30.03.2015 20:26, Daniel Shahaf wrote: > Carlos Martín Nieto wrote on Mon, Mar 30, 2015 at 16:58:57 +0200: >> +++ autogen.sh (working copy) >> -configfile=${LIBTOOL_CONFIG-`cd $ltpath/../share/libtool/config ; >> pwd`/$file} >> +configfile=${LIBTOOL_CONFIG-$(cd $ltpath/../

Re: [PATCH] On the 'ra-git' branch: update to libgit2 v0.22

2015-03-30 Thread Daniel Shahaf
Carlos Martín Nieto wrote on Mon, Mar 30, 2015 at 16:58:57 +0200: > +++ autogen.sh(working copy) > -configfile=${LIBTOOL_CONFIG-`cd $ltpath/../share/libtool/config ; > pwd`/$file} > +configfile=${LIBTOOL_CONFIG-$(cd $ltpath/../share/libtool/config ; > pwd)}/$file Is it sa

[PATCH] On the 'ra-git' branch: update to libgit2 v0.22

2015-03-30 Thread Carlos Martín Nieto
Hi, The git RA layer still expects to be built against v0.20 of libgit2, which has been unsupported for quite a while now. This patch brings the code up to date to work against the v0.22 API. [[[ On the 'ra-git' branch: update to libgit2 v0.22 * BRANCH-README: Specify we build against libgit2