Re: [PATCH] Missing newline in propset error message

2013-04-15 Thread Ben Reser
On Mon, Apr 15, 2013 at 9:11 AM, Philip Martin wrote: > That's just repeating what Mattias said. What I want to clarify is why > we want to use a double printf rather than having a new string. The existing translation key doesn't have a newline on it. Most of the uses it is inappropriate to jus

Re: [PATCH] Missing newline in propset error message

2013-04-15 Thread Philip Martin
Ben Reser writes: > On Mon, Apr 15, 2013 at 6:38 AM, Philip Martin > wrote: >> Mattias Engdegård writes: >> >>> Here is a patch. (I didn't add a newline to the string directly since >>> it occurs in many places.) >> >> The explaination should go in the code not the email otherwise somebody >> e

Re: [PATCH] Missing newline in propset error message

2013-04-15 Thread Ben Reser
On Mon, Apr 15, 2013 at 6:38 AM, Philip Martin wrote: > Mattias Engdegård writes: > >> Here is a patch. (I didn't add a newline to the string directly since >> it occurs in many places.) > > The explaination should go in the code not the email otherwise somebody > else may change the code. I don

Re: [PATCH] Missing newline in propset error message

2013-04-15 Thread Philip Martin
Mattias Engdegård writes: > Here is a patch. (I didn't add a newline to the string directly since > it occurs in many places.) The explaination should go in the code not the email otherwise somebody else may change the code. I don't understand the explaination, is this to make translation easie

Re: [PATCH] Missing newline in propset error message

2013-04-14 Thread Mattias Engdegård
14 apr 2013 kl. 16.19 skrev Mattias Engdegård: Here is a patch. (I didn't add a newline to the string directly since it occurs in many places.) Committed as r1467803, kindly approved by Ben Reser.

[PATCH] Missing newline in propset error message

2013-04-14 Thread Mattias Engdegård
There is a missing newline in the error when propset is used on a nonexisting file: $ svn ps a b file 'file' is not under version controlsvn: E155010: The node '/tmp/d1/ file' was not found. Here is a patch. (I didn't add a newline to the string directly since it occurs in many places.)