Re: [PATCH] Make constructors of some JavaHL classes public

2013-09-04 Thread Branko Čibej
On 04.09.2013 15:50, Mark Phippard wrote: > On Wed, Sep 4, 2013 at 9:47 AM, Branko Čibej > wrote: > > On 04.09.2013 15:03, Dmitry Pavlenko wrote: > > Hello all! > > There're 2 classes in JavaHL interface (CommitItem and > ConflictVersion) that have packag

Re: [PATCH] Make constructors of some JavaHL classes public

2013-09-04 Thread Dmitry Pavlenko
I thought about that, but there's a lot of such comments even above public constructors (e.g. above Lock class constructor). I think, this comment will still be true even the after change because within Subversion project the class will still be constructed only from JNI code. > 2013/9/4 Dmit

Re: [PATCH] Make constructors of some JavaHL classes public

2013-09-04 Thread Mark Phippard
On Wed, Sep 4, 2013 at 9:47 AM, Branko Čibej wrote: > On 04.09.2013 15:03, Dmitry Pavlenko wrote: > > Hello all! > > There're 2 classes in JavaHL interface (CommitItem and ConflictVersion) > that have package local > > constructors that makes it difficult to construct them from SVNKit. I > would

Re: [PATCH] Make constructors of some JavaHL classes public

2013-09-04 Thread Branko Čibej
On 04.09.2013 15:03, Dmitry Pavlenko wrote: > Hello all! > There're 2 classes in JavaHL interface (CommitItem and ConflictVersion) that > have package local > constructors that makes it difficult to construct them from SVNKit. I would > ask you to make the > constructors public. I disagree. Th

Re: [PATCH] Make constructors of some JavaHL classes public

2013-09-04 Thread Konstantin Kolinko
2013/9/4 Dmitry Pavlenko : > Hello all! > There're 2 classes in JavaHL interface (CommitItem and ConflictVersion) that > have package local > constructors that makes it difficult to construct them from SVNKit. I would > ask you to make the > constructors public. > > [[[ > Make constructors of Com

[PATCH] Make constructors of some JavaHL classes public

2013-09-04 Thread Dmitry Pavlenko
Hello all! There're 2 classes in JavaHL interface (CommitItem and ConflictVersion) that have package local constructors that makes it difficult to construct them from SVNKit. I would ask you to make the constructors public. [[[ Make constructors of CommitItem and ConflictVersion publc. * subv