Re: [PATCH] Improve svn_checksum_t bindings in SWIG

2012-12-11 Thread Daniel Shahaf
Shivani Poddar wrote on Wed, Dec 12, 2012 at 00:50:03 +0530: > On Wed, Dec 12, 2012 at 12:40 AM, Daniel Shahaf wrote: > > > Yeah, you're right. Ultimately that's because svn_checksum_size takes > > a checksum rather than a checksum kind. > > > > What should we do then? > > > > - revv svn_checksu

Re: [PATCH] Improve svn_checksum_t bindings in SWIG

2012-12-11 Thread Shivani Poddar
On Wed, Dec 12, 2012 at 12:40 AM, Daniel Shahaf wrote: > Yeah, you're right. Ultimately that's because svn_checksum_size takes > a checksum rather than a checksum kind. > > What should we do then? > > - revv svn_checksum_size to take an svn_checksum_kind_t? > Does this line mean something like:

Re: [PATCH] Improve svn_checksum_t bindings in SWIG

2012-12-11 Thread Daniel Shahaf
Yeah, you're right. Ultimately that's because svn_checksum_size takes a checksum rather than a checksum kind. What should we do then? - revv svn_checksum_size to take an svn_checksum_kind_t? - svn.core.APR_MD5_DIGESTSIZE? svn.core doesn't export that symbol. - len(hashlib.md5().hexdigest()) ?

Re: [PATCH] Improve svn_checksum_t bindings in SWIG

2012-12-11 Thread Peter Samuelson
> > +LENGTH = > > svn.core.svn_checksum_size(svn.core.svn_checksum_create(svn.core.svn_checksum_md5)) > > +self.assertEqual(len(check_val)%LENGTH,0,"Length of digest does > > not match kind") Is there a better way to get the expected length? svn.core.svn_checksum_create(svn.core.svn_ch

Re: [PATCH] Improve svn_checksum_t bindings in SWIG

2012-12-11 Thread Shivani Poddar
On Wed, Dec 12, 2012 at 12:02 AM, Daniel Shahaf wrote: > Shivani Poddar wrote on Tue, Dec 11, 2012 at 23:49:56 +0530: > > Log Message: > > > > Improve support for svn_checksum.h in SWIG bindings > > * subversion/bindings/swig/python/tests/checksum.py: Improved > test_checksum > > You haven't fixe

Re: [PATCH] Improve svn_checksum_t bindings in SWIG

2012-12-11 Thread Daniel Shahaf
Shivani Poddar wrote on Tue, Dec 11, 2012 at 23:49:56 +0530: > Log Message: > > Improve support for svn_checksum.h in SWIG bindings > * subversion/bindings/swig/python/tests/checksum.py: Improved test_checksum You haven't fixed the log message as per my original review. > Index: subversion/bindi

Re: [PATCH] Improve svn_checksum_t bindings in SWIG

2012-12-11 Thread Shivani Poddar
Log Message: Improve support for svn_checksum.h in SWIG bindings * subversion/bindings/swig/python/tests/checksum.py: Improved test_checksum Modified: subversion/trunk/subversion/bindings/swig/python/tests/checksum.py On Tue, Dec 11, 2012 at 11:05 PM, Daniel Shahaf wrote: > Shivani Poddar wro

Re: [PATCH] Improve svn_checksum_t bindings in SWIG

2012-12-11 Thread Daniel Shahaf
Shivani Poddar wrote on Tue, Dec 11, 2012 at 22:54:58 +0530: > I did use the assert functions on the same line but i did understand the > earlier concerns cited that although they compiled they werent the exact Ben was not referring to unittest.assertRaises() but to other unittest.assertFoo() func

Re: [PATCH] Improve svn_checksum_t bindings in SWIG

2012-12-11 Thread Shivani Poddar
On Tue, Dec 11, 2012 at 10:48 PM, Ben Reser wrote: > On Tue, Dec 11, 2012 at 3:18 AM, Shivani Poddar > wrote: > > > > Log Message: > > > > Improve support for svn_checksum.h in SWIG bindings > > * subversion/bindings/swig/python/tests/checksum.py: Improved > test_checksum > > > > > > Modified: >

Re: [PATCH] Improve svn_checksum_t bindings in SWIG

2012-12-11 Thread Ben Reser
On Tue, Dec 11, 2012 at 3:18 AM, Shivani Poddar wrote: > > Log Message: > > Improve support for svn_checksum.h in SWIG bindings > * subversion/bindings/swig/python/tests/checksum.py: Improved test_checksum > > > Modified: > subversion/trunk/subversion/bindings/swig/python/tests/checksum.py This d

[PATCH] Improve svn_checksum_t bindings in SWIG

2012-12-11 Thread Shivani Poddar
Log Message: Improve support for svn_checksum.h in SWIG bindings * subversion/bindings/swig/python/tests/checksum.py: Improved test_checksum Modified: subversion/trunk/subversion/bindings/swig/python/tests/checksum.py Regards, Shivani Poddar Bachelors in Computer Sciences and MS in Exact H

Re: [PATCH] Improve svn_checksum_t bindings in SWIG

2012-12-11 Thread Shivani Poddar
On Tue, Dec 11, 2012 at 2:17 PM, Daniel Shahaf wrote: > Shivani Poddar wrote on Tue, Dec 11, 2012 at 11:51:19 +0530: > > On Tue, Dec 11, 2012 at 4:08 AM, Daniel Shahaf > wrote: > > > Shivani Poddar wrote on Tue, Dec 11, 2012 at 02:22:28 +0530: > > > > Index: subversion/bindings/swig/python/tests

Re: [PATCH] Improve svn_checksum_t bindings in SWIG

2012-12-11 Thread Daniel Shahaf
Shivani Poddar wrote on Tue, Dec 11, 2012 at 11:51:19 +0530: > On Tue, Dec 11, 2012 at 4:08 AM, Daniel Shahaf wrote: > > Shivani Poddar wrote on Tue, Dec 11, 2012 at 02:22:28 +0530: > > > Index: subversion/bindings/swig/python/tests/checksum.py > > > ===

Re: [PATCH] Improve svn_checksum_t bindings in SWIG

2012-12-10 Thread Shivani Poddar
On Tue, Dec 11, 2012 at 4:08 AM, Daniel Shahaf wrote: > Shivani Poddar wrote on Tue, Dec 11, 2012 at 02:22:28 +0530: > > Log Message: > > > > Improve support for svn_checksum.h in SWIG bindings > > * subversion/bindings/swig/python/tests/checksum.py: Improved > test_checksum > > > > Need a blank

Re: [PATCH] Improve svn_checksum_t bindings in SWIG

2012-12-10 Thread Daniel Shahaf
Shivani Poddar wrote on Tue, Dec 11, 2012 at 02:22:28 +0530: > Log Message: > > Improve support for svn_checksum.h in SWIG bindings > * subversion/bindings/swig/python/tests/checksum.py: Improved test_checksum > Need a blank line before the * line, and to use the "* file\n (symbol)" syntax ---

[PATCH] Improve svn_checksum_t bindings in SWIG

2012-12-10 Thread Shivani Poddar
Log Message: Improve support for svn_checksum.h in SWIG bindings * subversion/bindings/swig/python/tests/checksum.py: Improved test_checksum Review by: danielsh Modified: subversion/trunk/subversion/bindings/swig/python/tests/checksum.py Regards, Shivani Poddar Bachelors in Computer Sciences a