Re: [PATCH] Improve single byte read stream performance

2010-03-15 Thread Johan Corveleyn
On Mon, Mar 15, 2010 at 9:56 PM, Johan Corveleyn wrote: > On Mon, Mar 15, 2010 at 6:18 PM, Ivan Zhakov wrote: >> On Mon, Mar 15, 2010 at 17:01, C. Michael Pilato wrote: >>> Philip Martin wrote: Johan Corveleyn writes: > On Tue, Mar 9, 2010 at 8:04 PM, Julian Foad > wrote: >>

Re: [PATCH] Improve single byte read stream performance

2010-03-15 Thread Johan Corveleyn
On Mon, Mar 15, 2010 at 6:18 PM, Ivan Zhakov wrote: > On Mon, Mar 15, 2010 at 17:01, C. Michael Pilato wrote: >> Philip Martin wrote: >>> Johan Corveleyn writes: >>> On Tue, Mar 9, 2010 at 8:04 PM, Julian Foad wrote: > On Sun, 2010-03-07, Stefan Fuhrman wrote: >> Speed up inp

Re: [PATCH] Improve single byte read stream performance

2010-03-15 Thread Stefan Fuhrmann
On Sunday 14 March 2010 22:53:59 Philip Martin wrote: > Johan Corveleyn writes: > > On Tue, Mar 9, 2010 at 8:04 PM, Julian Foad wrote: > >> On Sun, 2010-03-07, Stefan Fuhrman wrote: > >>> Speed up input stream processing in config parser and > >>> others that read single bytes from a stream. > >

Re: [PATCH] Improve single byte read stream performance

2010-03-15 Thread Ivan Zhakov
On Mon, Mar 15, 2010 at 17:01, C. Michael Pilato wrote: > Philip Martin wrote: >> Johan Corveleyn writes: >> >>> On Tue, Mar 9, 2010 at 8:04 PM, Julian Foad >>> wrote: On Sun, 2010-03-07, Stefan Fuhrman wrote: > Speed up input stream processing in config parser and > others that re

Re: [PATCH] Improve single byte read stream performance

2010-03-15 Thread C. Michael Pilato
Philip Martin wrote: > Johan Corveleyn writes: > >> On Tue, Mar 9, 2010 at 8:04 PM, Julian Foad wrote: >>> On Sun, 2010-03-07, Stefan Fuhrman wrote: Speed up input stream processing in config parser and others that read single bytes from a stream. * subversion/libsvn_subr/sub

Re: [PATCH] Improve single byte read stream performance

2010-03-14 Thread Philip Martin
Philip Martin writes: > Any improvement is lost in > the noise when I run the command line client on Linux. As measured by CPU usage or runtime. -- Philip

Re: [PATCH] Improve single byte read stream performance

2010-03-14 Thread Philip Martin
Johan Corveleyn writes: > On Tue, Mar 9, 2010 at 8:04 PM, Julian Foad wrote: >> On Sun, 2010-03-07, Stefan Fuhrman wrote: >>> Speed up input stream processing in config parser and >>> others that read single bytes from a stream. >>> >>> * subversion/libsvn_subr/subst.c >>>   (translated_stream_r

Re: [PATCH] Improve single byte read stream performance

2010-03-14 Thread Johan Corveleyn
On Tue, Mar 9, 2010 at 8:04 PM, Julian Foad wrote: > On Sun, 2010-03-07, Stefan Fuhrman wrote: >> Speed up input stream processing in config parser and >> others that read single bytes from a stream. >> >> * subversion/libsvn_subr/subst.c >>   (translated_stream_read): Add an optimized code path >

Re: [PATCH] Improve single byte read stream performance

2010-03-09 Thread Julian Foad
On Sun, 2010-03-07, Stefan Fuhrman wrote: > Speed up input stream processing in config parser and > others that read single bytes from a stream. > > * subversion/libsvn_subr/subst.c > (translated_stream_read): Add an optimized code path > for single byte read requests. > > Patch by: Stefan

Re: [PATCH] Improve single byte read stream performance

2010-03-09 Thread Julian Foad
On Sun, 2010-03-07 at 20:40 +0100, Stefan Fuhrman wrote: > While profiling TSVN's SVN proper access code, > I found that about 40% of the runtime was spent in > svn_config_get_config(). The reason was the config > parser fetching individual bytes from the input stream. > > However, translated_stre

Re: [PATCH] Improve single byte read stream performance

2010-03-08 Thread Stefan Fuhrmann
On Sunday 07 March 2010 21:30:35 you wrote: > > While profiling TSVN's SVN proper access code, > > I found that about 40% of the runtime was spent in > > svn_config_get_config(). The reason was the config > > parser fetching individual bytes from the input stream. > > > > However, translated_stream

RE: [PATCH] Improve single byte read stream performance

2010-03-07 Thread Bert Huijben
> -Original Message- > From: Stefan Fuhrman [mailto:stefanfuhrm...@alice-dsl.de] > Sent: zondag 7 maart 2010 20:40 > To: dev@subversion.apache.org > Subject: [PATCH] Improve single byte read stream performance > > While profiling TSVN's SVN proper access cod

[PATCH] Improve single byte read stream performance

2010-03-07 Thread Stefan Fuhrman
While profiling TSVN's SVN proper access code, I found that about 40% of the runtime was spent in svn_config_get_config(). The reason was the config parser fetching individual bytes from the input stream. However, translated_stream_read() obviously imposes a significant overhead per call for smal