Re: [PATCH] Fixing prop_tests.py failure in Solaris

2010-06-14 Thread Alexander Thomas
On Sat, 2010-06-12 at 13:04 +0200, Stefan Sperling wrote: > On Fri, Jun 11, 2010 at 02:30:09PM +0530, Alexander Thomas wrote: > > On Fri, 2010-06-11 at 09:53 +0100, Philip Martin wrote: > > > Alexander Thomas writes: > > > > > > > Yes SUNWuiu8 is the one that comes default with Solaris10 and 646/

Re: [PATCH] Fixing prop_tests.py failure in Solaris

2010-06-12 Thread Stefan Sperling
On Fri, Jun 11, 2010 at 02:30:09PM +0530, Alexander Thomas wrote: > On Fri, 2010-06-11 at 09:53 +0100, Philip Martin wrote: > > Alexander Thomas writes: > > > > > Yes SUNWuiu8 is the one that comes default with Solaris10 and 646/ASCII > > > conversion to UTF-8 works fine. But for other reasons I

Re: [PATCH] Fixing prop_tests.py failure in Solaris

2010-06-11 Thread Alexander Thomas
On Fri, 2010-06-11 at 09:53 +0100, Philip Martin wrote: > Alexander Thomas writes: > > > Yes SUNWuiu8 is the one that comes default with Solaris10 and 646/ASCII > > conversion to UTF-8 works fine. But for other reasons I should continue > > using gnu-libiconv. > > http://www.mail-archive.com/inf

Re: [PATCH] Fixing prop_tests.py failure in Solaris

2010-06-11 Thread Philip Martin
Alexander Thomas writes: > Yes SUNWuiu8 is the one that comes default with Solaris10 and 646/ASCII > conversion to UTF-8 works fine. But for other reasons I should continue > using gnu-libiconv. http://www.mail-archive.com/info-gnu%40gnu.org/msg00690.html Are you using 1.13? It added support fo

Re: [PATCH] Fixing prop_tests.py failure in Solaris

2010-06-11 Thread Alexander Thomas
On Fri, 2010-06-11 at 08:17 +0100, Philip Martin wrote: > Alexander Thomas writes: > > > Code snippet produced "646". > > > > "iconv -f 646 -t UTF-8 /dev/null" returned > > "iconv: conversion from `646' is not supported" > > Google suggests you need to install SUNWuiu8 for 646 to work. > > You

Re: [PATCH] Fixing prop_tests.py failure in Solaris

2010-06-11 Thread Philip Martin
Alexander Thomas writes: > Code snippet produced "646". > > "iconv -f 646 -t UTF-8 /dev/null" returned > "iconv: conversion from `646' is not supported" Google suggests you need to install SUNWuiu8 for 646 to work. You could try setting the environment variable LANG=C, or some other locale of

Re: [PATCH] Fixing prop_tests.py failure in Solaris

2010-06-10 Thread Alexander Thomas
On Thu, 2010-06-10 at 18:23 +0200, Stefan Sperling wrote: > On Wed, Jun 09, 2010 at 01:31:54PM +0200, Stefan Sperling wrote: > > > PASS: prop_tests.py 22: test prop* handle invalid property names > > > > Hmmm... I will try to debug this during the hackathon. > > This is not a problem in Subver

Re: [PATCH] Fixing prop_tests.py failure in Solaris

2010-06-10 Thread Stefan Sperling
On Wed, Jun 09, 2010 at 01:31:54PM +0200, Stefan Sperling wrote: > > PASS: prop_tests.py 22: test prop* handle invalid property names > > Hmmm... I will try to debug this during the hackathon. This is not a problem in Subversion. The problem is way deeper, down in the iconv implementation, an

Re: [PATCH] Fixing prop_tests.py failure in Solaris

2010-06-09 Thread Stefan Sperling
On Wed, Jun 09, 2010 at 12:15:58PM +0100, Philip Martin wrote: > Stefan Sperling writes: > > > On Wed, Jun 09, 2010 at 12:36:31PM +0200, Stefan Sperling wrote: > >> It would be great if you could build with --enable-maintainer-mode and > >> show the error trace of the failing test. An easy way is

Re: [PATCH] Fixing prop_tests.py failure in Solaris

2010-06-09 Thread Philip Martin
Stefan Sperling writes: > On Wed, Jun 09, 2010 at 12:36:31PM +0200, Stefan Sperling wrote: >> It would be great if you could build with --enable-maintainer-mode and >> show the error trace of the failing test. An easy way is to just post >> the entire output of ./prop_tests.py --verbose invalid_p

Re: [PATCH] Fixing prop_tests.py failure in Solaris

2010-06-09 Thread Alexander Thomas
On Wed, 2010-06-09 at 12:36 +0200, Stefan Sperling wrote: > On Wed, Jun 09, 2010 at 02:03:01PM +0530, Alexander Thomas wrote: > > > The test used to check for an unprintable ascii character (backspace). > > > With this patch, it checks for an empty string. > > > I'm not sure if this is a good thin

Re: [PATCH] Fixing prop_tests.py failure in Solaris

2010-06-09 Thread Stefan Sperling
On Wed, Jun 09, 2010 at 12:36:31PM +0200, Stefan Sperling wrote: > It would be great if you could build with --enable-maintainer-mode and > show the error trace of the failing test. An easy way is to just post > the entire output of ./prop_tests.py --verbose invalid_propnames It turns out that the

Re: [PATCH] Fixing prop_tests.py failure in Solaris

2010-06-09 Thread Stefan Sperling
On Wed, Jun 09, 2010 at 02:03:01PM +0530, Alexander Thomas wrote: > On Wed, 2010-06-09 at 09:51 +0200, Stefan Sperling wrote: > > On Wed, Jun 09, 2010 at 12:55:26PM +0530, Alexander Thomas wrote: > > > [[[ > > > Replace existing invalid propname to make test pass in Solaris. > > > > > > * subversi

Re: [PATCH] Fixing prop_tests.py failure in Solaris

2010-06-09 Thread Alexander Thomas
On Wed, 2010-06-09 at 09:51 +0200, Stefan Sperling wrote: > On Wed, Jun 09, 2010 at 12:55:26PM +0530, Alexander Thomas wrote: > > [[[ > > Replace existing invalid propname to make test pass in Solaris. > > > > * subversion/tests/cmdline/prop_tests.py > > (invalid_propnames): Changed propname to

Re: [PATCH] Fixing prop_tests.py failure in Solaris

2010-06-09 Thread Stefan Sperling
On Wed, Jun 09, 2010 at 12:55:26PM +0530, Alexander Thomas wrote: > [[[ > Replace existing invalid propname to make test pass in Solaris. > > * subversion/tests/cmdline/prop_tests.py > (invalid_propnames): Changed propname to empty char. > ]]] > > > -Alexander Thomas (AT) > Index: subversion/

[PATCH] Fixing prop_tests.py failure in Solaris

2010-06-09 Thread Alexander Thomas
[[[ Replace existing invalid propname to make test pass in Solaris. * subversion/tests/cmdline/prop_tests.py (invalid_propnames): Changed propname to empty char. ]]] -Alexander Thomas (AT) Index: subversion/tests/cmdline/prop_tests.py ===