On 2021/04/01 3:57, Julian Foad wrote:
> Yasuhito FUTATSUKI wrote:
>> Follow up to r188732: Fix the invocation of svneditor.sh on out of tree
>> build.
>
> I confirm this patch makes it work properly in my out-of-tree build. Thank
> you!
>
Commited in r1888273. Thanks!
Cheers,
--
Yasuhito FU
Yasuhito FUTATSUKI wrote:
> Follow up to r188732: Fix the invocation of svneditor.sh on out of tree build.
I confirm this patch makes it work properly in my out-of-tree build. Thank you!
--
- Julian
On 2021/03/31 23:53, Julian Foad wrote:
>> I've commited the former of above candidates (using script_dir at runtime).
>
> Hello. I just noticed this change makes some tests fail for me. I am using
> an out-of-tree build. What seems to be happening is it is now building
> "subversion/tests/cm
> I've commited the former of above candidates (using script_dir at runtime).
Hello. I just noticed this change makes some tests fail for me. I am using an
out-of-tree build. What seems to be happening is it is now building
"subversion/tests/cmdline/svneditor.sh" in the obj-dir (which is not
On 2021/03/03 4:05, Daniel Shahaf wrote:
> Yasuhito FUTATSUKI wrote on Tue, 02 Mar 2021 03:21 +00:00:
>> On 2021/03/02 0:41, Daniel Shahaf wrote:
>>> Yasuhito FUTATSUKI wrote on Mon, Mar 01, 2021 at 10:55:51 +0900:
+++ subversion/tests/cmdline/svneditor.sh.in (working copy)
@@ -0,0
Yasuhito FUTATSUKI wrote on Tue, 02 Mar 2021 03:21 +00:00:
> On 2021/03/02 0:41, Daniel Shahaf wrote:
> > Yasuhito FUTATSUKI wrote on Mon, Mar 01, 2021 at 10:55:51 +0900:
> >> +++ subversion/tests/cmdline/svneditor.sh.in (working copy)
> >> @@ -0,0 +1,40 @@
> >> +print_python_path()
> >> +{
>
On 2021/03/02 0:41, Daniel Shahaf wrote:
> Yasuhito FUTATSUKI wrote on Mon, Mar 01, 2021 at 10:55:51 +0900:
>> On 2021/02/26 22:52, Daniel Shahaf wrote:
>>> Yasuhito FUTATSUKI wrote on Thu, Feb 25, 2021 at 21:43:15 +0900:
On 2021/02/22 13:39, Karl Fogel wrote:
(A) Replace the shebang lin
Yasuhito FUTATSUKI wrote on Mon, Mar 01, 2021 at 10:55:51 +0900:
> On 2021/02/26 22:52, Daniel Shahaf wrote:
> > Yasuhito FUTATSUKI wrote on Thu, Feb 25, 2021 at 21:43:15 +0900:
> >> On 2021/02/22 13:39, Karl Fogel wrote:
> >>> I felt I should close the loop in this thread:
> >>>
> >>> I decided to
On 2021/02/26 22:52, Daniel Shahaf wrote:
> Yasuhito FUTATSUKI wrote on Thu, Feb 25, 2021 at 21:43:15 +0900:
>> On 2021/02/22 13:39, Karl Fogel wrote:
>>> I felt I should close the loop in this thread:
>>>
>>> I decided to leave this be for now. Even though it is mildly annoying that
>>> the Subv
Yasuhito FUTATSUKI wrote on Thu, Feb 25, 2021 at 21:43:15 +0900:
> On 2021/02/22 13:39, Karl Fogel wrote:
> > I felt I should close the loop in this thread:
> >
> > I decided to leave this be for now. Even though it is mildly annoying that
> > the Subversion test suite exhibits a few spurious fa
Karl Fogel wrote on Thu, Feb 25, 2021 at 16:02:10 -0600:
> With just Patch B, there are the same 4 test failures:
>
> FAIL: commit_tests.py 48: set revision props during remote property edit
> FAIL: prop_tests.py 1: write/read props in wc only (ps, pl, pdel, pe)
> FAIL: prop_tests.py 16: pro
On 2021/02/26 7:02, Karl Fogel wrote:
> On 25 Feb 2021, Yasuhito FUTATSUKI wrote:
>> Then, I made patches. It also allows pypy to run the test without 'python'.
>> (A) Replace the shebang line of svneditor.py from svneditor.py at running
>> the configure script. (fix-svneditor-in-test-patch-a
On 25 Feb 2021, Yasuhito FUTATSUKI wrote:
Then, I made patches. It also allows pypy to run the test without
'python'. (A) Replace the shebang line of svneditor.py from
svneditor.py
at running the configure
script. (fix-svneditor-in-test-patch-a.txt) As @PYTHON@ can be
basename only, rela
On 2021/02/22 13:39, Karl Fogel wrote:
> I felt I should close the loop in this thread:
>
> I decided to leave this be for now. Even though it is mildly annoying that
> the Subversion test suite exhibits a few spurious failures on systems that
> have only 'python3' and not 'python', it turns ou
I felt I should close the loop in this thread:
I decided to leave this be for now. Even though it is mildly
annoying that the Subversion test suite exhibits a few spurious
failures on systems that have only 'python3' and not 'python', it
turns out that most of the time most of my systems have
On 27 Jan 2021, Yasuhito FUTATSUKI wrote:
This is because SVN_MERGE does not execute through a shell, whole
value is treated as a single path. On the other hand, SVN_EDITOR
is passed to system() and is interpreted by a shell.
Ah, thank you for the explanation. What I saw makes sense now.
H
On 2021/01/27 16:30, Karl Fogel wrote:
> On 26 Jan 2021, Daniel Shahaf wrote:
>> +1 to using sys.executable. Fixing the quoting while in there would be
>> nice to have, but as it's not a regression it's not a blocker either.
>> Happy to leave the details to you.
>
> Well, things turn out to be a
On 26 Jan 2021, Daniel Shahaf wrote:
>+1 to using sys.executable. Fixing the quoting while in there would be
>nice to have, but as it's not a regression it's not a blocker either.
>Happy to leave the details to you.
Well, things turn out to be a bit more complicated than I thought.
My original p
On Tue, Jan 26, 2021 at 01:47:23AM -0600, Karl Fogel wrote:
> On recent versions of Debian GNU/Linux, the 'python' command doesn't
> normally exist. Instead, there are separate 'python3' and 'python2'
> commands.
>
> As a result, four tests fail in the Subversion test suite as of
> r1885910, all
On 26 Jan 2021, Daniel Shahaf wrote:
>Yay! *gestures* Here's your old chair, right where you left it; I think you'll
>find the only difference from when you last occupied it is that your DHCP lease
>may have expired ;-)
:laugh+cry emoji::)
>AFAICT:
>
>1. SVN_TEST_PYTHON is only used by the
> From: Karl Fogel
> Subject: [PATCH] Fix tests failing on Debian due to lack of 'python' command.
Yay! *gestures* Here's your old chair, right where you left it; I think you'll
find the only difference from when you last occupied it is that your DHCP lease
may
On 26 Jan 2021, M. Buecher wrote:
>On 2021-01-26 08:47, Karl Fogel wrote:
>> On recent versions of Debian GNU/Linux, the 'python' command doesn't
>> normally exist. Instead, there are separate 'python3' and 'python2'
>> commands.
>
>Side note:
>There are additional packages to set either python2 o
On 2021-01-26 08:47, Karl Fogel wrote:
On recent versions of Debian GNU/Linux, the 'python' command doesn't
normally exist. Instead, there are separate 'python3' and 'python2'
commands.
Side note:
There are additional packages to set either python2 or python3 as the
"default" Python.
This cha
On recent versions of Debian GNU/Linux, the 'python' command doesn't normally
exist. Instead, there are separate 'python3' and 'python2' commands.
As a result, four tests fail in the Subversion test suite as of r1885910, all
for the same reason: the 'subversion/tests/cmdline/svneditor.py' mock
24 matches
Mail list logo
