Fwd: [PATCH] Fix non-ASCII cmdline options in non-UTF-8 locales

(Forwarding to dev@, on the assumption that's what C-Mike intended.) C. Michael Pilato wrote: > On 04/25/2013 07:32 PM, Julian Foad wrote: >> While reviewing r1475724 "Fix changelist filtering when --changelist >> values aren't UTF8", I noticed we also fail to convert some other >> command-line op

Re: [PATCH] Fix non-ASCII cmdline options in non-UTF-8 locales

On 26.04.2013 01:32, Julian Foad wrote: > --with-revprop: > - '=' characters are examined before converting to UTF-8; this should be > safe becaue '=' is in the ASCII Basic Code Table [1]. I'm not sure we can rely on this if the locale has an ISO-2022-compliant encoding (multibyte with shif

Re: [PATCH] Fix non-ASCII cmdline options in non-UTF-8 locales

Julian Foad wrote on Fri, Apr 26, 2013 at 00:32:32 +0100: > Some other arguments, including '--native-eol', are not converted > before testing for valid values, and the valid values are always > ASCII.  This is OK, if we assume an ASCII subset.  That's probably > safe, as [1] indicates that all com

[PATCH] Fix non-ASCII cmdline options in non-UTF-8 locales

While reviewing r1475724 "Fix changelist filtering when --changelist values aren't UTF8", I noticed we also fail to convert some other command-line options to UTF-8. The attached patch addresses:   --old, --new:     Fix usage of non-ASCII paths. It looked for the wrong file and so was     unus