Re: [PATCH] Fix modification of nil value in Ruby test suite

2016-10-22 Thread James McCoy
On Tue, Nov 17, 2015 at 08:51:31AM -0500, James McCoy wrote: > On Nov 17, 2015 8:40 AM, "Philip Martin" wrote: > > > > James McCoy writes: > > > > > --- a/subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c > > > +++ b/subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c > > > @@

Re: [PATCH] Fix modification of nil value in Ruby test suite

2015-11-17 Thread James McCoy
On Nov 17, 2015 8:40 AM, "Philip Martin" wrote: > > James McCoy writes: > > > --- a/subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c > > +++ b/subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c > > @@ -3230,14 +3230,16 @@ svn_swig_rb_make_stream(VALUE io) > > stream_p =

Re: [PATCH] Fix modification of nil value in Ruby test suite

2015-11-17 Thread Philip Martin
James McCoy writes: > --- a/subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c > +++ b/subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c > @@ -3230,14 +3230,16 @@ svn_swig_rb_make_stream(VALUE io) > stream_p = &stream; > r2c_swig_type2(io, "svn_stream_t *", (void **

Re: [PATCH] Fix modification of nil value in Ruby test suite

2015-11-16 Thread James McCoy
On Sun, Nov 08, 2015 at 11:26:07PM -0500, James McCoy wrote: > The attached patch makes the Ruby 2.2 test suite failure I mentioned in > [0] go away, but this is all code I'm pretty unfamiliar with. > > https://mail-archives.apache.org/mod_mbox/subversion-dev/201511.mbox/ajax/%3C20151108030937.GC8

[PATCH] Fix modification of nil value in Ruby test suite

2015-11-08 Thread James McCoy
The attached patch makes the Ruby 2.2 test suite failure I mentioned in [0] go away, but this is all code I'm pretty unfamiliar with. https://mail-archives.apache.org/mod_mbox/subversion-dev/201511.mbox/ajax/%3C20151108030937.GC8248%40freya.jamessan.com%3E [[[ Create a new Ruby Object instead of