Re: [PATCH] Fix harmless uninitialized read in svn_fs_fs__l2p_index_append

2020-07-30 Thread Nathan Hartman
On Thu, Jul 30, 2020 at 9:56 PM Daniel Shahaf wrote: > Nathan Hartman wrote on Thu, 30 Jul 2020 19:17 -0400: > > On Wed, Jul 29, 2020 at 6:28 PM Daniel Shahaf > > wrote: > > > Nathan Hartman wrote on Tue, 28 Jul 2020 10:42 -0400: > > > > Committed in r1880374. > > > > > > Thanks. Nominate these

Re: [PATCH] Fix harmless uninitialized read in svn_fs_fs__l2p_index_append

2020-07-30 Thread Daniel Shahaf
Nathan Hartman wrote on Thu, 30 Jul 2020 19:17 -0400: > On Wed, Jul 29, 2020 at 6:28 PM Daniel Shahaf > wrote: > > Nathan Hartman wrote on Tue, 28 Jul 2020 10:42 -0400: > > > Committed in r1880374. > > > > Thanks. Nominate these for backport? > > > > My +1 on the FSFS part for 1.14.x. (ENOTI

Re: [PATCH] Fix harmless uninitialized read in svn_fs_fs__l2p_index_append

2020-07-30 Thread Nathan Hartman
On Wed, Jul 29, 2020 at 6:28 PM Daniel Shahaf wrote: > Nathan Hartman wrote on Tue, 28 Jul 2020 10:42 -0400: > > Committed in r1880374. > > Thanks. Nominate these for backport? > > My +1 on the FSFS part for 1.14.x. (ENOTIME to review the FSX part > currently.) For FSFS, +1. For FSX, I'd like

Re: [PATCH] Fix harmless uninitialized read in svn_fs_fs__l2p_index_append

2020-07-29 Thread Daniel Shahaf
Nathan Hartman wrote on Tue, 28 Jul 2020 10:42 -0400: > On Mon, Jul 27, 2020 at 3:28 AM Daniel Shahaf wrote: > > Nathan Hartman wrote on Mon, 27 Jul 2020 03:29 +00:00: > > > I've reviewed the first one so far. In reviewing, my concern was > > > whether changing the order of the expressions could

Re: [PATCH] Fix harmless uninitialized read in svn_fs_fs__l2p_index_append

2020-07-28 Thread Nathan Hartman
On Mon, Jul 27, 2020 at 3:28 AM Daniel Shahaf wrote: > Nathan Hartman wrote on Mon, 27 Jul 2020 03:29 +00:00: > > I've reviewed the first one so far. In reviewing, my concern was > > whether changing the order of the expressions could alter behavior. I > > studied the code paths through svn_fs_fs_

Re: [PATCH] Fix harmless uninitialized read in svn_fs_fs__l2p_index_append

2020-07-27 Thread Daniel Shahaf
Nathan Hartman wrote on Mon, 27 Jul 2020 03:29 +00:00: > On Sat, Jul 25, 2020 at 7:27 PM Orivej Desh wrote: > > > > Clang 10 memory sanitizer reports an uninitialized read of .offset in > > if ((entry > 0 && proto_entry.offset == 0) || eof) > > when read_l2p_entry_from_proto_index set eof and

Re: [PATCH] Fix harmless uninitialized read in svn_fs_fs__l2p_index_append

2020-07-26 Thread Nathan Hartman
On Sat, Jul 25, 2020 at 7:27 PM Orivej Desh wrote: > > Clang 10 memory sanitizer reports an uninitialized read of .offset in > if ((entry > 0 && proto_entry.offset == 0) || eof) > when read_l2p_entry_from_proto_index set eof and left the proto_entry unset. Thanks for your patches! +1 to com

Re: [PATCH] Fix harmless uninitialized read in svn_fs_fs__l2p_index_append

2020-07-26 Thread Orivej Desh
* Daniel Shahaf [2020-07-27] > Orivej Desh wrote on Sat, 25 Jul 2020 23:27 +: > > Clang 10 memory sanitizer reports an uninitialized read of .offset in > > if ((entry > 0 && proto_entry.offset == 0) || eof) > > when read_l2p_entry_from_proto_index set eof and left the proto_entry unset. >

Re: [PATCH] Fix harmless uninitialized read in svn_fs_fs__l2p_index_append

2020-07-26 Thread Daniel Shahaf
Orivej Desh wrote on Sat, 25 Jul 2020 23:27 +: > Clang 10 memory sanitizer reports an uninitialized read of .offset in > if ((entry > 0 && proto_entry.offset == 0) || eof) > when read_l2p_entry_from_proto_index set eof and left the proto_entry unset. Orivej Desh wrote on Sat, 25 Jul 2020

[PATCH] Fix harmless uninitialized read in svn_fs_fs__l2p_index_append

2020-07-25 Thread Orivej Desh
Clang 10 memory sanitizer reports an uninitialized read of .offset in if ((entry > 0 && proto_entry.offset == 0) || eof) when read_l2p_entry_from_proto_index set eof and left the proto_entry unset. [[[ Fix harmless uninitialized read in svn_fs_fs__l2p_index_append * subversion/libsvn_fs_fs/in