Re: [PATCH] Fix alignment of blame output containing revision numbers >= 1000000

2010-06-18 Thread Julian Foad
On Thu, 2010-06-17, Johan Corveleyn wrote: > On Thu, Jun 17, 2010 at 5:54 PM, C. Michael Pilato > wrote: > > Julian Foad wrote: > >> My recommendation: Let's strive for compatibility where we can, and > >> where the old behaviour is reasonable. I think a 6-character minimum > >> column width is

Re: [PATCH] Fix alignment of blame output containing revision numbers >= 1000000

2010-06-17 Thread Johan Corveleyn
On Thu, Jun 17, 2010 at 5:54 PM, C. Michael Pilato wrote: > Julian Foad wrote: >> My recommendation:  Let's strive for compatibility where we can, and >> where the old behaviour is reasonable.  I think a 6-character minimum >> column width is reasonable for most purposes, even though it's not the

Re: [PATCH] Fix alignment of blame output containing revision numbers >= 1000000

2010-06-17 Thread C. Michael Pilato
Julian Foad wrote: > My recommendation: Let's strive for compatibility where we can, and > where the old behaviour is reasonable. I think a 6-character minimum > column width is reasonable for most purposes, even though it's not the > purest design. +1 -- C. Michael Pilato CollabNet <> ww

Re: [PATCH] Fix alignment of blame output containing revision numbers >= 1000000

2010-06-17 Thread Julian Foad
On Thu, 2010-06-17, Johan Corveleyn wrote: > Please find in attachment my (very first) patch addressing the issue > discussed in [1] and [2]. > > Log message (maybe a bit too verbose ...): This amount of detail is fine. > [[[ > Fix alignment of blame output containing revision numbers >= 100

[PATCH] Fix alignment of blame output containing revision numbers >= 1000000

2010-06-16 Thread Johan Corveleyn
Hi, Please find in attachment my (very first) patch addressing the issue discussed in [1] and [2]. Log message (maybe a bit too verbose ...): [[[ Fix alignment of blame output containing revision numbers >= 100 * subversion/include/svn_client.h (svn_client_blame_receiver3_t): Add parameter