Re: [PATCH] Fix a bug with property validation logic during 'svnadmin load'

On 01/27/2012 02:10 AM, vijay wrote: > Fix the helper function 'change_rev_prop' to use functions which perform > validation of the property value if 'validate_props' is set. Otherwise, > bypass those checks. > > * subversion/libsvn_repos/load-fs-vtable.c > (change_rev_prop): Do the property val

Re: [PATCH] Fix a bug with property validation logic during 'svnadmin load'

On 01/26/2012 06:44 PM, C. Michael Pilato wrote: Vijay, I think you have misunderstood what these docstrings are claiming. They are not saying, "When Subversion calls the FS-loading API, it tends to pass FALSE for validate_props by default." They are describing the quite literal implementation

Re: [PATCH] Fix a bug with property validation logic during 'svnadmin load'

On 01/25/2012 09:51 AM, vijay wrote: > Index: subversion/include/svn_repos.h > === > --- subversion/include/svn_repos.h(revision 1235706) > +++ subversion/include/svn_repos.h(working copy) > @@ -2649,7 +2649,7 @@ > /** > * S

[PATCH] Fix a bug with property validation logic during 'svnadmin load'

Hi, This patch fixes a bug in a helper function subversion/libsvn_repos/load-fs-vtable.c:change_rev_prop() to use property validation functions if 'validate_props' is 'TRUE'. As "svnadmin load" does the property validation by default, 'validate_props' parameter is always set to 'TRUE'. Update