Re: [PATCH] Fix JavaHL error in SVNBase::createCppBoundObject

2020-10-05 Thread Alexandr Miloslavskiy
On 05.10.2020 5:17, Nathan Hartman wrote: While reviewing r1882115, I wondered what was the original rationale for the C++ function SVNBase::createCppBoundObject() to cache clazz's ctor's method ID in a locally scoped static variable. It seems to be the common code style in JavaHL to cache the

Re: [PATCH] Fix JavaHL error in SVNBase::createCppBoundObject

2020-10-04 Thread Nathan Hartman
While reviewing r1882115, I wondered what was the original rationale for the C++ function SVNBase::createCppBoundObject() to cache clazz's ctor's method ID in a locally scoped static variable. (In C++ such a variable is basically the same as a global variable, only with its visibility limited to t

Re: [PATCH] Fix JavaHL error in SVNBase::createCppBoundObject

2020-09-29 Thread Alexandr Miloslavskiy
Committed in 1882115.

[PATCH] Fix JavaHL error in SVNBase::createCppBoundObject

2020-09-15 Thread Alexandr Miloslavskiy
Please find patch attached. [[[ Fix JavaHL error in SVNBase::createCppBoundObject The problem here is that 'SVNBase::createCppBoundObject' can work with different classes (see argument), but it cached methodID of '' for the first class processed. The error is seen when running JavaHL tests with