Re: [PATCH] Add svnrdump

2010-07-09 Thread Junio C Hamano
Michael J Gruber writes: > Blair Zajac venit, vidit, dixit 09.07.2010 02:42: >> On 07/08/2010 01:17 AM, Daniel Shahaf wrote: >>> @Bert: could you please trim quoted patches to only the relevant parts? >>> Scrolling is tedious when I don't have have line folding available... >> >> +1 on this, in

Re: [PATCH] Add svnrdump

2010-07-09 Thread Ramkumar Ramachandra
Hi, Ramkumar Ramachandra writes: > Where is svn_dirent_basename defined? I can't seem to find it in the > codebase at all. np, I found it. It's svn_relpath_basename. -- Ram

Re: [PATCH] Add svnrdump

2010-07-09 Thread Ramkumar Ramachandra
Hi, Bert Huijben writes: > > + /* Cleanup */ > > + SVN_ERR(svn_io_file_close(hb->temp_file, hb->pool)); > > + SVN_ERR(svn_stream_close(hb->temp_filestream)); > > The standard handler already closes the stream for you and if you don't > disown the file on mapping, this also closes the file. >

Re: [PATCH] Add svnrdump

2010-07-09 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > > > + /* Use a temporary file to measure the text-content-length */ > > > + apr_err = apr_temp_dir_get(&tempdir, hb->pool); > > svn_io_temp_dir() Fixed. > > > + if (apr_err != APR_SUCCESS) > > > +SVN_ERR(svn_error_wrap_apr(apr_err, NULL)); > > > + > > >

Re: [PATCH] Add svnrdump

2010-07-09 Thread Ramkumar Ramachandra
Hi Bert, Thank you for the review. Bert Huijben writes: > > +svn_error_t *open_root(void *edit_baton, > > + svn_revnum_t base_revision, > > + apr_pool_t *pool, > > + void **root_baton) > > Static and the return type on its own lin

Re: [PATCH] Add svnrdump

2010-07-09 Thread Sverre Rabbelier
Heya, On Fri, Jul 9, 2010 at 03:16, Michael J Gruber wrote: > In fact, on the git list we tend to trim as little as possible. Huh? Quite the opposite I thought... -- Cheers, Sverre Rabbelier

Re: [PATCH] Add svnrdump

2010-07-09 Thread Michael J Gruber
Blair Zajac venit, vidit, dixit 09.07.2010 02:42: > On 07/08/2010 01:17 AM, Daniel Shahaf wrote: >> @Bert: could you please trim quoted patches to only the relevant parts? >> Scrolling is tedious when I don't have have line folding available... > > +1 on this, in Thunderbird, it took a while to sc

Re: [PATCH] Add svnrdump

2010-07-08 Thread Blair Zajac
On 07/08/2010 01:17 AM, Daniel Shahaf wrote: @Bert: could you please trim quoted patches to only the relevant parts? Scrolling is tedious when I don't have have line folding available... +1 on this, in Thunderbird, it took a while to scan through the whole email to see the comments. Regards,

RE: [PATCH] Add svnrdump

2010-07-08 Thread Daniel Shahaf
ail.com] > > Sent: donderdag 8 juli 2010 10:35 > > To: dev@subversion.apache.org > > Cc: Jonathan Nieder; Sverre Rabbelier; Git Mailing List > > Subject: [PATCH] Add svnrdump > > > > + /* Use a temporary file to measure the text-content-length */ > > + apr_e

RE: [PATCH] Add svnrdump

2010-07-08 Thread Bert Huijben
> -Original Message- > From: Ramkumar Ramachandra [mailto:artag...@gmail.com] > Sent: donderdag 8 juli 2010 10:35 > To: dev@subversion.apache.org > Cc: Jonathan Nieder; Sverre Rabbelier; Git Mailing List > Subject: [PATCH] Add svnrdump > > Hi, > > Kindly

[PATCH] Add svnrdump

2010-07-08 Thread Ramkumar Ramachandra
Hi, Kindly find the diff for svnrdump in the later part of this email. I haven't written a build.conf rule or manpage, but I suppose I can do them in another patch. Thanks. -- Ram 8<--->8- Index: subversion/svnrdump/dump_editor.c