Re: [PATCH] Add support for http_proxy and https_proxy environment variables

2012-10-03 Thread C. Michael Pilato
On 09/25/2012 11:32 AM, Branko Čibej wrote: > On 25.09.2012 17:10, Stefan Sperling wrote: >> On Tue, Sep 25, 2012 at 11:01:44AM -0400, C. Michael Pilato wrote: >>> On 09/25/2012 10:42 AM, Branko Čibej wrote: On 25.09.2012 16:37, C. Michael Pilato wrote: > +1 on the optional libproxy depend

Re: [PATCH] Add support for http_proxy and https_proxy environment variables

2012-09-25 Thread Branko Čibej
On 25.09.2012 17:10, Stefan Sperling wrote: > On Tue, Sep 25, 2012 at 11:01:44AM -0400, C. Michael Pilato wrote: >> On 09/25/2012 10:42 AM, Branko Čibej wrote: >>> On 25.09.2012 16:37, C. Michael Pilato wrote: +1 on the optional libproxy dependency. That makes great sense to me. How

Re: [PATCH] Add support for http_proxy and https_proxy environment variables

2012-09-25 Thread Stefan Sperling
On Tue, Sep 25, 2012 at 11:01:44AM -0400, C. Michael Pilato wrote: > On 09/25/2012 10:42 AM, Branko Čibej wrote: > > On 25.09.2012 16:37, C. Michael Pilato wrote: > >> +1 on the optional libproxy dependency. That makes great sense to me. > >> > >> However ... since the env-var stuff is *relatively

Re: [PATCH] Add support for http_proxy and https_proxy environment variables

2012-09-25 Thread C. Michael Pilato
On 09/25/2012 10:42 AM, Branko Čibej wrote: > On 25.09.2012 16:37, C. Michael Pilato wrote: >> +1 on the optional libproxy dependency. That makes great sense to me. >> >> However ... since the env-var stuff is *relatively* straightforward, would >> we be interested in/willing to *also* implement t

Re: [PATCH] Add support for http_proxy and https_proxy environment variables

2012-09-25 Thread Branko Čibej
On 25.09.2012 16:37, C. Michael Pilato wrote: > On 09/17/2012 09:34 PM, Bert Huijben wrote: >> On Windows this isn't the normal way to fetch the system wide proxy, nor >> is it on the Mac. Adding environment flags to GUI applications there is >> certainly *not* the right way to look at this problem

Re: [PATCH] Add support for http_proxy and https_proxy environment variables

2012-09-25 Thread C. Michael Pilato
On 09/17/2012 09:34 PM, Bert Huijben wrote: > On Windows this isn't the normal way to fetch the system wide proxy, nor > is it on the Mac. Adding environment flags to GUI applications there is > certainly *not* the right way to look at this problem. The linux specific > environment variable solutio

RE: [PATCH] Add support for http_proxy and https_proxy environment variables

2012-09-17 Thread Bert Huijben
> -Original Message- > From: Neil Bird [mailto:n...@jibbyjobby.co.uk] > Sent: maandag 17 september 2012 03:07 > To: Josh Triplett > Cc: C. Michael Pilato; dev@subversion.apache.org > Subject: Re: [PATCH] Add support for http_proxy and https_proxy > environment variab

Re: [PATCH] Add support for http_proxy and https_proxy environment variables

2012-09-17 Thread Neil Bird
Around about 13/09/12 15:50, Josh Triplett typed ... Why should only the command-line clients notice those environment variables? If someone has http_proxy set, and runs some graphical subversion client using libsvn, that client ought to use the proxy as well. As a user of http_proxy on both

Re: [PATCH] Add support for http_proxy and https_proxy environment variables

2012-09-14 Thread Josh Triplett
On Fri, Sep 14, 2012 at 01:22:03PM +0200, Johan Corveleyn wrote: > On Thu, Sep 13, 2012 at 4:50 PM, Josh Triplett wrote: > > On Thu, Sep 13, 2012 at 08:03:06AM -0400, C. Michael Pilato wrote: > ... > >> - While your approach was the super simple one to take, how do we feel > >> about > >> the fac

Re: [PATCH] Add support for http_proxy and https_proxy environment variables

2012-09-14 Thread Johan Corveleyn
On Thu, Sep 13, 2012 at 4:50 PM, Josh Triplett wrote: > On Thu, Sep 13, 2012 at 08:03:06AM -0400, C. Michael Pilato wrote: ... >> - While your approach was the super simple one to take, how do we feel about >> the fact that this would cause all programs which linked against >> Subversion's libs to

Re: [PATCH] Add support for http_proxy and https_proxy environment variables

2012-09-13 Thread Josh Triplett
On Thu, Sep 13, 2012 at 08:03:06AM -0400, C. Michael Pilato wrote: > On 09/12/2012 07:52 PM, Josh Triplett wrote: > > The attached patch implements support for the http_proxy and https_proxy > > environment variables. This allows subversion to automatically make use > > of system-wide proxy config

RE: [PATCH] Add support for http_proxy and https_proxy environment variables

2012-09-13 Thread Bert Huijben
> -Original Message- > From: Branko Čibej [mailto:br...@wandisco.com] > Sent: donderdag 13 september 2012 14:19 > To: dev@subversion.apache.org > Subject: Re: [PATCH] Add support for http_proxy and https_proxy > environment variables > > On 13.09.2012 14:03,

Re: [PATCH] Add support for http_proxy and https_proxy environment variables

2012-09-13 Thread C. Michael Pilato
On 09/13/2012 08:19 AM, Branko Čibej wrote: > On 13.09.2012 14:03, C. Michael Pilato wrote: >> - While your approach was the super simple one to take, how do we feel >> about the fact that this would cause all programs which linked against >> Subversion's libs to start noticing those environment va

Re: [PATCH] Add support for http_proxy and https_proxy environment variables

2012-09-13 Thread Branko Čibej
On 13.09.2012 14:03, C. Michael Pilato wrote: > - While your approach was the super simple one to take, how do we feel > about the fact that this would cause all programs which linked against > Subversion's libs to start noticing those environment variables which > are really kind meant to be speci

Re: [PATCH] Add support for http_proxy and https_proxy environment variables

2012-09-13 Thread C. Michael Pilato
On 09/12/2012 07:52 PM, Josh Triplett wrote: > The attached patch implements support for the http_proxy and https_proxy > environment variables. This allows subversion to automatically make use > of system-wide proxy configuration, rather than requiring > subversion-specific proxy configuration; e

[PATCH] Add support for http_proxy and https_proxy environment variables

2012-09-12 Thread Josh Triplett
The attached patch implements support for the http_proxy and https_proxy environment variables. This allows subversion to automatically make use of system-wide proxy configuration, rather than requiring subversion-specific proxy configuration; environment variables also make it easier to have netw