Re: [PATCH] Add serf library version information to svn --version

2013-08-15 Thread Ivan Zhakov
On Thu, Aug 15, 2013 at 8:07 PM, Ben Reser wrote: > On 8/15/13 4:48 AM, Ivan Zhakov wrote: >> Thoughts? > > It'd be nice if this was printed under the linked dependencies section > of `svn --version --verbose`, but I don't see a good way of adding that > since serf is required by the dynamically l

Re: [PATCH] Add serf library version information to svn --version

2013-08-15 Thread Ben Reser
On 8/15/13 4:48 AM, Ivan Zhakov wrote: > Thoughts? It'd be nice if this was printed under the linked dependencies section of `svn --version --verbose`, but I don't see a good way of adding that since serf is required by the dynamically loadable ra layer and isn't a core dependency. Maybe we shoul

Re: [PATCH] Add serf library version information to svn --version

2013-08-15 Thread Ivan Zhakov
On Thu, Aug 15, 2013 at 5:38 PM, Philip Martin wrote: > Ivan Zhakov writes: > >> On Thu, Aug 15, 2013 at 4:14 PM, Philip Martin >> wrote: >>> Philip Martin writes: >>> Ivan Zhakov writes: > Good point. I'll fix it in separate commit. What do you think about > patch itself? >

Re: [PATCH] Add serf library version information to svn --version

2013-08-15 Thread Philip Martin
Ivan Zhakov writes: > On Thu, Aug 15, 2013 at 4:14 PM, Philip Martin > wrote: >> Philip Martin writes: >> >>> Ivan Zhakov writes: >>> Good point. I'll fix it in separate commit. What do you think about patch itself? >>> >>> Is there any reason for the static optimisation? Does perf

Re: [PATCH] Add serf library version information to svn --version

2013-08-15 Thread Ivan Zhakov
On Thu, Aug 15, 2013 at 4:14 PM, Philip Martin wrote: > Philip Martin writes: > >> Ivan Zhakov writes: >> >>> Good point. I'll fix it in separate commit. What do you think about >>> patch itself? >> >> Is there any reason for the static optimisation? Does performance >> matter? Why not simply

Re: [PATCH] Add serf library version information to svn --version

2013-08-15 Thread Philip Martin
Philip Martin writes: > Ivan Zhakov writes: > >> Good point. I'll fix it in separate commit. What do you think about >> patch itself? > > Is there any reason for the static optimisation? Does performance > matter? Why not simply format each time? Ah! You don't have a pool. -- Philip

Re: [PATCH] Add serf library version information to svn --version

2013-08-15 Thread Philip Martin
Ivan Zhakov writes: > Good point. I'll fix it in separate commit. What do you think about > patch itself? Is there any reason for the static optimisation? Does performance matter? Why not simply format each time? -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: [PATCH] Add serf library version information to svn --version

2013-08-15 Thread Ivan Zhakov
On Thu, Aug 15, 2013 at 3:59 PM, Philip Martin wrote: > Ivan Zhakov writes: > >> Log message: >> [[[ >> Add serf library version to svn --version output. >> >> * subversion/libsvn_ra_serf/serf.c >> (RA_SERF_DESCRIPTION): Add version placeholders. >> (ra_serf_get_description): Add serf library

Re: [PATCH] Add serf library version information to svn --version

2013-08-15 Thread Philip Martin
Ivan Zhakov writes: > Log message: > [[[ > Add serf library version to svn --version output. > > * subversion/libsvn_ra_serf/serf.c > (RA_SERF_DESCRIPTION): Add version placeholders. > (ra_serf_get_description): Add serf library version information to RA layer >description. > ]]] > > Thou

[PATCH] Add serf library version information to svn --version

2013-08-15 Thread Ivan Zhakov
Hi, I think it will be useful to have svn --version display serf library version information. Attached patch makes output of svn --version like this: [[[ C:\Ivan\SVN\trunk\Debug\subversion\svn>svn.exe --version svn, version 1.9.0-dev (under development) compiled Aug 7 2013, 15:48:17 on x86/x86