Re: [serf-dev] Re: [PATCH] Add a configuration option to disable HTTP pipelining.

2014-08-21 Thread Lieven Govaerts
On Thu, Aug 21, 2014 at 5:47 PM, Justin Erenkrantz wrote: > On Thu, Aug 21, 2014 at 5:30 PM, Lieven Govaerts wrote: >> Attached patch implements a slightly different approach but I think >> it's a valid workaround for the problem. > > It may be useful to note why we register apps_ssl_info_callbac

Re: [serf-dev] Re: [PATCH] Add a configuration option to disable HTTP pipelining.

2014-08-21 Thread Justin Erenkrantz
On Thu, Aug 21, 2014 at 5:30 PM, Lieven Govaerts wrote: > Attached patch implements a slightly different approach but I think > it's a valid workaround for the problem. It may be useful to note why we register apps_ssl_info_callback in the re-negotiate info callback. (It's because there can only

Re: [PATCH] Add a configuration option to disable HTTP pipelining.

2014-08-21 Thread Lieven Govaerts
On Thu, Aug 21, 2014 at 1:04 PM, Justin Erenkrantz wrote: > On Tue, Aug 19, 2014 at 2:53 PM, Lieven Govaerts wrote: >> However, when the client certificate is requested for a resource >> deeper in the repository, it's likely that say during a large >> checkout, many (pipelined) requests will alre

Re: [PATCH] Add a configuration option to disable HTTP pipelining.

2014-08-21 Thread Justin Erenkrantz
On Tue, Aug 19, 2014 at 2:53 PM, Lieven Govaerts wrote: > However, when the client certificate is requested for a resource > deeper in the repository, it's likely that say during a large > checkout, many (pipelined) requests will already be sent by the client > before the request for the protected

Re: [PATCH] Add a configuration option to disable HTTP pipelining.

2014-08-19 Thread Mark Phippard
On Tue, Aug 19, 2014 at 9:53 AM, Lieven Govaerts wrote: > On Tue, Aug 19, 2014 at 2:34 PM, Mark Phippard wrote: > > On Tue, Aug 19, 2014 at 9:25 AM, Lieven Govaerts wrote: > > > >> There's a bug in OpenSSL's SSL renegotiation algorithm. When it's > >> initiated by the server to request a clien

Re: [PATCH] Add a configuration option to disable HTTP pipelining.

2014-08-19 Thread Lieven Govaerts
On Tue, Aug 19, 2014 at 2:34 PM, Mark Phippard wrote: > On Tue, Aug 19, 2014 at 9:25 AM, Lieven Govaerts wrote: > >> There's a bug in OpenSSL's SSL renegotiation algorithm. When it's >> initiated by the server to request a client certificate, it'll fail >> when on the connection pipelined reques

Re: [PATCH] Add a configuration option to disable HTTP pipelining.

2014-08-19 Thread Mark Phippard
On Tue, Aug 19, 2014 at 9:25 AM, Lieven Govaerts wrote: There's a bug in OpenSSL's SSL renegotiation algorithm. When it's > initiated by the server to request a client certificate, it'll fail > when on the connection pipelined requests are incoming at the server > side. > > Short summary of the

[PATCH] Add a configuration option to disable HTTP pipelining.

2014-08-19 Thread Lieven Govaerts
Hi, attached patch adds a new configuration flag to disable HTTP pipelining. There's a bug in OpenSSL's SSL renegotiation algorithm. When it's initiated by the server to request a client certificate, it'll fail when on the connection pipelined requests are incoming at the server side. Short su