Re: [PATCH] to help benchmark.py run on windows

2011-04-19 Thread Greg Stein
On Tue, Apr 19, 2011 at 17:37, Alan Wood wrote: > On 19 Apr 2011 at 13:07, Greg Stein wrote: >> > >> > On Windows, the path returned by mkdtemp() is something like >> > >> >  C:\users\billga~1\appdata\local\temp\tmpfoobar >> > >> > with no leading slash, so an extra slash makes the URL valid. >> >

Re: [PATCH] to help benchmark.py run on windows

2011-04-19 Thread Alan Wood
On 19 Apr 2011 at 13:07, Greg Stein wrote: > > > > On Windows, the path returned by mkdtemp() is something like > > > >  C:\users\billga~1\appdata\local\temp\tmpfoobar > > > > with no leading slash, so an extra slash makes the URL valid. > > > > The directory path could even have spaces in it, if t

Re: [PATCH] to help benchmark.py run on windows

2011-04-19 Thread Greg Stein
On Tue, Apr 19, 2011 at 11:07, Stephen Butler wrote: > > On Apr 19, 2011, at 15:32 , Neels Hofmeyr wrote: > >> On Mon, 2011-04-18 at 19:47 -0400, Greg Stein wrote: >>> Applied in r1094816. >>> >>> On Mon, Apr 18, 2011 at 18:44, Greg Stein wrote: On Mon, Apr 18, 2011 at 07:04, Alan Wood wrot

Re: [PATCH] to help benchmark.py run on windows

2011-04-19 Thread Neels Hofmeyr
On Tue, 2011-04-19 at 17:07 +0200, Stephen Butler wrote: > On Apr 19, 2011, at 15:32 , Neels Hofmeyr wrote: > > > This attached patch fixes three issues with the script: > 1) use of file:// when I'm sure that file:/// is correct from previous > discussions on this list > > >

Re: [PATCH] to help benchmark.py run on windows

2011-04-19 Thread Stephen Butler
On Apr 19, 2011, at 15:32 , Neels Hofmeyr wrote: > On Mon, 2011-04-18 at 19:47 -0400, Greg Stein wrote: >> Applied in r1094816. >> >> On Mon, Apr 18, 2011 at 18:44, Greg Stein wrote: >>> On Mon, Apr 18, 2011 at 07:04, Alan Wood wrote: Hi devs, I have just been looking at running the

Re: [PATCH] to help benchmark.py run on windows

2011-04-19 Thread Neels Hofmeyr
On Mon, 2011-04-18 at 19:47 -0400, Greg Stein wrote: > Applied in r1094816. > > On Mon, Apr 18, 2011 at 18:44, Greg Stein wrote: > > On Mon, Apr 18, 2011 at 07:04, Alan Wood wrote: > >> Hi devs, > >> I have just been looking at running the benchmarks and have got to the > >> stage where I can

Re: [PATCH] to help benchmark.py run on windows

2011-04-18 Thread Greg Stein
Applied in r1094816. On Mon, Apr 18, 2011 at 18:44, Greg Stein wrote: > On Mon, Apr 18, 2011 at 07:04, Alan Wood wrote: >> Hi devs, >>  I have just been looking at running the benchmarks and have got to the >> stage where I can >> run it on windows. >> >> This attached patch fixes three issues

Re: [PATCH] to help benchmark.py run on windows

2011-04-18 Thread Greg Stein
On Mon, Apr 18, 2011 at 07:04, Alan Wood wrote: > Hi devs, >  I have just been looking at running the benchmarks and have got to the stage > where I can > run it on windows. > > This attached patch fixes three issues with the script: >  1) use of file:// when I'm sure that file:/// is correct fro

Re: [PATCH] to help benchmark.py run on windows

2011-04-18 Thread Gavin Baumanis
Hi Alan, Thanks for your patch. Not too sure if you have been following the dev list discussions or not; but just in case you haven't been; http://svn.haxx.se/dev/archive-2011-04/0243.shtml Which would seem that Greg has been working on the same thing, making changes to the script to allow it

[PATCH] to help benchmark.py run on windows

2011-04-18 Thread Alan Wood
Hi devs, I have just been looking at running the benchmarks and have got to the stage where I can run it on windows. This attached patch fixes three issues with the script: 1) use of file:// when I'm sure that file:/// is correct from previous discussions on this list 2) make sure no \ end u