Re: [PATCH] #include limts.h for ULONG_MAX

2013-03-27 Thread Joe Swatosh
On Wed, Mar 27, 2013 at 6:58 PM, Joe Swatosh wrote: > On Wed, Mar 27, 2013 at 4:03 AM, Stefan Sperling wrote: >> On Wed, Mar 27, 2013 at 10:25:16AM +, Philip Martin wrote: >>> Joe Swatosh writes: >>> >>> > Okay, thanks for giving me hints on this. As a matter of fact, my apr >>> > does NOT h

Re: [PATCH] #include limts.h for ULONG_MAX

2013-03-27 Thread Joe Swatosh
On Wed, Mar 27, 2013 at 4:03 AM, Stefan Sperling wrote: > On Wed, Mar 27, 2013 at 10:25:16AM +, Philip Martin wrote: >> Joe Swatosh writes: >> >> > Okay, thanks for giving me hints on this. As a matter of fact, my apr >> > does NOT have a section like this. It is just doing a straight up copy

Re: [PATCH] #include limts.h for ULONG_MAX

2013-03-27 Thread Stefan Sperling
On Wed, Mar 27, 2013 at 10:25:16AM +, Philip Martin wrote: > Joe Swatosh writes: > > > Okay, thanks for giving me hints on this. As a matter of fact, my apr > > does NOT have a section like this. It is just doing a straight up copy > > of apr.hw. I've downloaded a few different versions of ap

Re: [PATCH] #include limts.h for ULONG_MAX

2013-03-27 Thread Philip Martin
Joe Swatosh writes: > Okay, thanks for giving me hints on this. As a matter of fact, my apr > does NOT have a section like this. It is just doing a straight up copy > of apr.hw. I've downloaded a few different versions of apr and none of > them have a block like that in apr.hw. Heading over to th

Re: [PATCH] #include limts.h for ULONG_MAX

2013-03-26 Thread Joe Swatosh
Okay, thanks for giving me hints on this. As a matter of fact, my apr does NOT have a section like this. It is just doing a straight up copy of apr.hw. I've downloaded a few different versions of apr and none of them have a block like that in apr.hw. Heading over to the apr list now to ask for more

Re: [PATCH] #include limts.h for ULONG_MAX

2013-03-26 Thread Philip Martin
Joe Swatosh writes: > Thanks Philip and Bert, perhaps this along with Philip's changes? > > [[[ > Index: subversion/include/svn_types.h > === > --- subversion/include/svn_types.h (revision 1460925) > +++ subversion/include/svn_t

Re: [PATCH] #include limts.h for ULONG_MAX

2013-03-25 Thread Joe Swatosh
> Bert Huijben writes: > >> Isn't there an apr variant of this macro we can/should use? >> >> Bert From: Joe Swatosh >> Sent: 25-3-2013 01:01 >> To: SVN Dev >> Subject: [PATCH] #include limts.h for ULONG_MAX >> While I found this issue usi

Re: [PATCH] #include limts.h for ULONG_MAX

2013-03-25 Thread Philip Martin
In r1460628 I changed the code to use svn_cstring_strtoui64 and so avoid ULONG_MAX. Bert Huijben writes: > Isn't there an apr variant of this macro we can/should use? > > Bert From: Joe Swatosh > Sent: 25-3-2013 01:01 > To: SVN Dev > Subject: [PATCH] #include limts.h

RE: [PATCH] #include limts.h for ULONG_MAX

2013-03-25 Thread Bert Huijben
Isn't there an apr variant of this macro we can/should use? Bert From: Joe Swatosh Sent: 25-3-2013 01:01 To: SVN Dev Subject: [PATCH] #include limts.h for ULONG_MAX While I found this issue using my very old compiler, it seems reasonable since that is where ULONG_MAX has been defined for a

[PATCH] #include limts.h for ULONG_MAX

2013-03-24 Thread Joe Swatosh
While I found this issue using my very old compiler, it seems reasonable since that is where ULONG_MAX has been defined for a long time. (Since clearly no one else is running into this). [[[ For those of us with somewhat deficient compilers that don't provide ULONG_MAX unless is explicitly includ