Re: [PATCH/RFC] Simplify implementation of lock / unlock operations in FSFS

2015-02-12 Thread Philip Martin
Sergey Raevskiy writes: > Yes, the behaviour is *not* exactly the same -- the index files is updated in > different order. Furthermore, I've realized that current version of algorithm > will set some locks even if update of some index files is failed. I think that is OK. What matters is that t

Re: [PATCH/RFC] Simplify implementation of lock / unlock operations in FSFS

2015-02-11 Thread Sergey Raevskiy
>> Recently I've spent some time investigating how lock and unlock are >> implemented in FSFS and can suggest the following simplification. I >> attempted just to make this part clearer and a new code is intended to >> behave exactly the same. > > It's not exactly the same, index files are written

Re: [PATCH/RFC] Simplify implementation of lock / unlock operations in FSFS

2015-02-11 Thread Philip Martin
Sergey Raevskiy writes: > Recently I've spent some time investigating how lock and unlock are > implemented in FSFS and can suggest the following simplification. I > attempted just to make this part clearer and a new code is intended to > behave exactly the same. It's not exactly the same, inde

[PATCH/RFC] Simplify implementation of lock / unlock operations in FSFS

2015-02-11 Thread Sergey Raevskiy
Hi! Recently I've spent some time investigating how lock and unlock are implemented in FSFS and can suggest the following simplification. I attempted just to make this part clearer and a new code is intended to behave exactly the same. The patch is attached. Log message: [[[ Simplify implementa