Re: apr_token_* conclusions

2016-01-27 Thread William A Rowe Jr
On Wed, Jan 27, 2016 at 10:11 PM, Branko Čibej wrote: > > > > Stating that equivalent-case are treated as equal states that the > > code points "A"-"Z" are all treated as equal, and "a"-"z" are all > > treated as equal (and "A" and "a" would be treated as unique > > of one another) LOL > > I gues

Re: apr_hash_overlay returns hash with duplicate keys

2015-12-10 Thread William A Rowe Jr
Which public API, APR's or svn's? On Dec 10, 2015 11:24 AM, "Ivan Zhakov" wrote: > On 10 December 2015 at 20:20, Julian Foad wrote: > > Ivan Zhakov wrote: > >> On 10 December 2015 at 19:14, Julian Foad > wrote: > >>> APR devs, Subversion devs: > >>> > >>> On Subversion's Mac OS buildbots it ap

Re: [Patch] apr_file_path_merge returns incorrect truepath on certain 'short paths' on Windows

2015-06-18 Thread William A Rowe Jr
Looks great, thanks Brane, and Bert for calling this out. On Thu, Jun 18, 2015 at 3:43 AM, Branko Čibej wrote: > On 17.06.2015 15:53, Branko Čibej wrote: > > Thanks for the reminder! Will do. > On 17 Jun 2015 12:37 pm, "Yann Ylavic" wrote: > >> On Wed, Jun 17, 2015 at 5:41 AM, Branko Čibej wr

Re: [Patch] apr_file_path_merge returns incorrect truepath on certain 'short paths' on Windows

2015-06-15 Thread William A Rowe Jr
Great report, thanks Bert. I'll review. Bill On Mon, Jun 15, 2015 at 7:19 AM, Bert Huijben wrote: > Trying yet another e-mail address... Nice that this just bounces instead > of being moderated :( > > Bert > > > -Original Message- > > From: Bert Huijben [mailto:rhuij...@collab.

Re: Race condition in APR_DECLARE_LATE_DLL_FUNC() implementation

2013-12-06 Thread William A. Rowe Jr.
On Fri, 6 Dec 2013 16:44:52 +0100 Stefan Fuhrmann wrote: > On Fri, Dec 6, 2013 at 6:05 AM, William A. Rowe Jr. > wrote: > > > On Thu, 5 Dec 2013 15:01:05 +0100 > > "Bert Huijben" wrote: > > > > > I think the dll load function should be converted

Re: Race condition in APR_DECLARE_LATE_DLL_FUNC() implementation

2013-12-05 Thread William A. Rowe Jr.
On Thu, 5 Dec 2013 15:01:05 +0100 "Bert Huijben" wrote: > I think the dll load function should be converted to a more stable > pattern, that properly handles multiple threads. And perhaps we > should just assume a few more NT functions to be alsways there > instead of loading them dynamically. T

Re: svn commit: r1339559 - /subversion/site/publish/docs/release-notes/release-history.html

2012-05-20 Thread William A Rowe Jr
sponse' to that particular cve. -Original message- From: Mark Thomas To: Hyrum K Wright , "William A. Rowe Jr." , secur...@apache.org, dev@subversion.apache.org Sent: Sun, May 20, 2012 15:49:56 GMT+00:00 Subject: Re: svn commit: r1339559 - /subversion/site/publish/d

Re: svn commit: r1339559 - /subversion/site/publish/docs/release-notes/release-history.html

2012-05-18 Thread William A. Rowe Jr.
On 5/18/2012 11:57 AM, Greg Stein wrote: > On Thu, May 17, 2012 at 2:02 PM, Daniel Shahaf > wrote: >> ... >> CVE are meant to be a unique identifier to an issue so I think it's >> a (minor?) problem if different downstreamers requests CVE's >> independently. >> ... >> IOW, "Should we be trigger-h

Re: [Patch] RE: Windows drive letter check fails on lower case current working drive

2010-01-19 Thread William A. Rowe Jr.
On 1/19/2010 5:19 AM, Bert Huijben wrote: > > The patch was written on the 1.4.x branch but I svn switch'ed it to trunk for > easy application. I would suggest one bit of alternate code that is a bit more condensed, any concern?; +static int same_drive(const char *path1, const char *path2) +{ +

Re: Hashtable data freed before pool cleanup

2010-01-19 Thread William A. Rowe Jr.
On 1/7/2010 9:12 AM, Bert Huijben wrote: > > Looking at apr's 1.3.x branch: > > In r817810 a change to the hash table implementation was introduced, > which moves the data of a hash table from the main pool to a subpool (as > seen from the pool passed to apr_hash_make). This makes the contents of

Re: Hashtable data freed before pool cleanup

2010-01-19 Thread William A. Rowe Jr.
On 1/7/2010 6:06 PM, Bojan Smojver wrote: > On Thu, 2010-01-07 at 16:26 +0100, Ruediger Pluem wrote: >> This sounds like a valid point. > > +1 > >> I would propose to revert r817810 / r817809 (for 1.3.x / 1.4.x) and >> only keep r817806 (trunk). Graham? >> IMHO we can backport this again later if

Re: Hashtable data freed before pool cleanup

2010-01-19 Thread William A. Rowe Jr.
On 1/17/2010 4:57 AM, William A. Rowe Jr. wrote: > On 1/7/2010 9:12 AM, Bert Huijben wrote: >> >> Looking at apr's 1.3.x branch: >> >> In r817810 a change to the hash table implementation was introduced, >> which moves the data of a hash table from the main