Re: [PATCH] Fix harmless uninitialized read in svn_fs_fs__l2p_index_append

2020-07-26 Thread Orivej Desh
* Daniel Shahaf [2020-07-27] > Orivej Desh wrote on Sat, 25 Jul 2020 23:27 +: > > Clang 10 memory sanitizer reports an uninitialized read of .offset in > > if ((entry > 0 && proto_entry.offset == 0) || eof) > > when read_l2p_entry_from_proto_index set eo

[PATCH] Fix harmless uninitialized read in svn_fs_fs__l2p_index_append

2020-07-25 Thread Orivej Desh
Clang 10 memory sanitizer reports an uninitialized read of .offset in if ((entry > 0 && proto_entry.offset == 0) || eof) when read_l2p_entry_from_proto_index set eof and left the proto_entry unset. [[[ Fix harmless uninitialized read in svn_fs_fs__l2p_index_append * subversion/libsvn_fs_fs/in

Re: heap-use-after-free in object_ref_cleanup

2017-05-28 Thread Orivej Desh
* Stefan Fuhrmann [2017-05-28] > The callstacks suggests that this is a pool cleanup race. > Please try the attached patch and report the results. Thanks! With this patch subversion from trunk no longer crashes, and subversion 1.9.5 does not crash with an empty config, and crashes differently wi

Re: heap-use-after-free in object_ref_cleanup

2017-05-28 Thread Orivej Desh
* Daniel Shahaf [2017-05-23] > > The report says that the use-after-free occured inside the cleanup handler. > It > doesn't say where the accessed object was allocated or freed; to get that > info, > you'd have had to compile APR with pool debugging (--enable-pool-debug), then > the second and

heap-use-after-free in object_ref_cleanup

2017-05-23 Thread Orivej Desh
Hello, I noticed in dmesg that in my repository svnserve occasionally crashes. This happens at exit, so it is not visible to end users. I captured a few sessions at the svn protocol level that resulted in a crash; client commands are quite different in each one; sending an input that crashed `svn

Re: [SVN-4677] svn up fails after a file is replaced by a directory

2017-05-01 Thread Orivej Desh
Stefan, could you please consider this bug report? * Johan Corveleyn [2017-04-07] > On Thu, Apr 6, 2017 at 6:10 AM, Orivej Desh wrote: > > I filed a bug at https://issues.apache.org/jira/browse/SVN-4677 > > Since the mailing list seems more active, I copy it here. > > >

[SVN-4677] svn up fails after a file is replaced by a directory

2017-04-05 Thread Orivej Desh
I filed a bug at https://issues.apache.org/jira/browse/SVN-4677 Since the mailing list seems more active, I copy it here. * * * svn up fails after a file is added, moved, deleted, replaced by a directory, and a file in the directory is deleted This bug was introduced in r1586953 [1], is present