Hi Daniel,
> But I also think the more important question to answer is the one from my
> previous mail --- where in principle does the "is backportable?" line pass
> for the bindings (like the feature/bugfix distinction in the core
> libraries), and on what side on it does adding the unlock_prompt
> >> So, you are saying that there is no legitimate/supported scenario in
> >> which the .py and .so are out of sync with each other?
I can't provide anything authorative on that, other than that
"make install-swig-py" seems to install them together and that I can't
think of any legitimate scenari
Hi Daniel,
> If we backport your unlock_prompt_func patches to 1.7.3, someone
> downgrading the bindings from 1.7.3 to 1.7.2 will get runtime linker
> errors, correct? If so we cannot backport it.
I think that will not happen, since the C function is defined in the
bindings, not in the main subve
Hey Stefan,
> For example, the addition of new functions prevents people from rolling
> back to an earlier 1.7 patch release without breaking scripts which were
> modified to use the new functions after updating to 1.7.3. That would
> be a violation of our release compatibility guidelines.
Hmm, th
Hi folks,
thanks to the hard work by Stefan and Daniel (and lots of mail exchanges
between us), my patches are in! Thanks for that! Now I can start bugging
the git-svn folks to apply my other set of patches ;-)
Looking at the branches available, I think these changes would become
available in the
Hi Daniel,
> > Index: subversion-trunk/subversion/bindings/swig/python/tests/client.py
> > ===
> > --- subversion-trunk.orig/subversion/bindings/swig/python/tests/client.py
> > 2012-02-07 20:13:48.666552472 +0100
> > +++ subversion
keyring_unlock_prompt_func): Merge declaration with
implementation and move both below the include of svn_auth.h.
Patch by: Matthijs Kooijman
Index: subversion-trunk/subversion/bindings/swig/core.i
===
--- subversion-trunk.orig/su
Hey Stefan,
> So, you'll have to drop the {% %} (which is effectively my patch again)
> ;-p
Hold on there, it seems that doesn't work either. Perhaps the
SVN_AUTH_PARAM_GNOME_KEYRING_UNLOCK_PROMPT_FUNC constant isn't defined
when swig runs or something, I'll have a closer look now.
Gr.
Matthijs
Hey Stefan,
> Thanks. I've already committed a similar fix in r1241585.
> I wasn't quite sure if it was gonna work but glad you had the same idea :)
Actually, I just tried your fix and it doesn't work. It'll fix the build
error on win32, but it also breaks the binding on systems that do have
gnom
Hey Stefan,
> FYI, the latter patch fails to compile on Windows.
> See
> http://ci.apache.org/builders/svn-slik-w2k3-x64-local/builds/6580/steps/Build%20Bindings/logs/stdio
Woops, i forgot to #ifdef the declaration like I did with the
implmentation. I reproduced the error here by disabling gnome-
/bindings/swig/python/tests/client.py
(test_platform_providers): Improve testcase.
Patch by: Matthijs Kooijman
Index: subversion-trunk/subversion/bindings/swig/python/tests/client.py
===
--- subversion-trunk.orig/subversion/bindings
.
Patch by: Matthijs Kooijman
]]]
Index: subversion-trunk/subversion/bindings/swig/include/svn_containers.swg
===
--- subversion-trunk.orig/subversion/bindings/swig/include/svn_containers.swg 2012-02-07 19:18:00.948407883 +0100
+++ subve
Hi Daniel,
> > + # ctx.config.config (ctx.config is opaque).
>
> What do you mean by that?
>
> % PYTHONPATH=$prefix/svn-t1/lib/svn-python/ \
> python -c 'import svn, svn.core, svn.client;
> print svn.core.svn_config_get_config(None, None)["config"]'
> 0xb734d998> >
I meant this
ments.py
Let this example use svn_auth_get_platform_specific_client_providers.
Patch by: Matthijs Kooijman
]]]
Index: subversion-trunk/subversion/bindings/swig/include/svn_containers.swg
===
--- subversion-trunk.orig/subversion/bindi
Hi folks,
> over a year ago, I submitted a patch to make the
> svn_auth_get_platform_specific_client_providers perl bindings work, to
> allow git-svn to work with gnome_keyring. Since then, I've been working
> on some further improvements, which I've attached as patches.
has anyone got a chance to
Hey Daniel,
> This looks trivial so I'll apply it,
Thanks.
> but I'd like to note that 'patch -p1' rejects this for some reason.
Weird, it workd for me. Patches were created using quilt, but that
shouldn't matter I guess.
Perhaps this is a CRLF vs LF issue? I see the file in question has
svn:eol
client.svn_client_create_context instead of client.ctx_t.
Patch by: Matthijs Kooijman
]]]
Index: subversion-trunk/tools/examples/get-location-segments.py
===
--- subversion-trunk.orig/tools/examples/get-location-segments.py 2012-01-05
Hi Hyrum,
> I guess I also should have asked if this something which should go
> into the 1.6.x line (I imagine so).
The sooner the better, since that would make it more feasible to fix up
git to actually use this.
Gr.
Matthijs
signature.asc
Description: Digital signature
Hi Hyrum,
> Committed to trunk in r1035745.
Awesome, thanks!
Now it's time to bugger the git maintainers again for the other end of
this patch :-)
Gr.
Matthijs
signature.asc
Description: Digital signature
Hi folks,
this is a resubmit of a patch that got lost in the list earlier.
The patch is a trivial patch, which adds perl bindings for the
apr_array_header_t **providers type, which fixes the
svn_auth_get_platform_specific_client_providers function.
The patch also includes a basic test case.
Gr.
Hey Folks,
> I've attached an updated patch with a test case. The testcase is a bity
> ugly, since it tests each element of the returned array and keeps the
> result in its own variable. This is needed since I can't predict how
> many elements there will be in the returned array, but I didn't want
Hi folks,
> I believe the swig perl tests (invoked by running 'make
> check-swig-pl') are in subversion/bindings/swig/perl/native/t/
Ah, I'd looked over that very small directory name, I guess :-)
I've attached an updated patch with a test case. The testcase is a bity
ugly, since it tests each el
Hi Hyrym,
thanks for your thoughts.
> Would it be possible to add a test to the Perl bindings tests which
> exercises this new code?
Where do these live? I looked around the tests directory a bit, but I
didn't think there were tests for bindings?
> Additionally, you should probably provide a log
Hi folks,
> While writing this, I've finally found the "include/svn_containers.swg"
> file containing all kinds of typemaps for the apr_*_t types. I'll try
> poking in there a bit, I'll keep you posted.
Using the following patch (which just appends a bit to the end of the file),
the svn_auth_get_
Hi folks,
while trying to get git-svn to work with gnome-keyring, I found that the
(perl) bindings for the svn_auth_get_platform_specific_client_providers
function are missing. Or actually, a binding is generated, but it
ends with:
/* FIXME: Missing argout typemap:
svn_auth_get_platform_spec
25 matches
Mail list logo
