Re: Worried about single-db performance

2010-09-07 Thread Matthew Bentham
On 07/09/2010 13:02, Bert Huijben wrote: -Original Message- From: Matthew Bentham [mailto:mj...@artvps.com] Sent: dinsdag 7 september 2010 13:48 To: Bert Huijben Cc: 'Justin Erenkrantz'; 'Greg Stein'; 'Johan Corveleyn'; 'Subversion Development&#x

Re: Worried about single-db performance

2010-09-07 Thread Matthew Bentham
On 06/09/2010 15:18, Bert Huijben wrote: -Original Message- From: Matthew Bentham [mailto:mj...@artvps.com] Sent: maandag 6 september 2010 15:07 To: Justin Erenkrantz Cc: Bert Huijben; Greg Stein; Johan Corveleyn; Subversion Development Subject: Re: Worried about single-db performance

Re: Worried about single-db performance

2010-09-06 Thread Matthew Bentham
On 04/09/2010 17:33, Justin Erenkrantz wrote: Aha. Adding exclusive locking into our pragma [http://www.sqlite.org/pragma.html] calls in "svn_sqlite__open": "PRAGMA locking_mode=exclusive;" brings the time for "svn st" down from 0.680 to 0.310 seconds. And, yes, the I/O percentages drop drama

Re: About character encoding of the text files

2010-08-25 Thread Matthew Bentham
On 25/08/2010 17:01, Ivan Cenov wrote: 25.8.2010 ??. 08:54, B Smith-Mannschott : The property svn:mime-type carries charset information as an additional field: $ svn propset svn:mime-type "text/plain;charset=Windows-1251" file1.txt file2.txt ... // ben Hi, I tried with *

Re: BUG: when performing a checkout use the cased url as in the download URL

2010-07-22 Thread Matthew Bentham
On 22/07/2010 14:08, s...@stsp.name wrote: On Thu, Jul 22, 2010 at 10:58:44PM +1000, dave b wrote: Can we at least agree that the current state is suboptimal ? Sure, but it's the state of windows that is suboptimal. There simply isn't anything we can reasonably do about it. Stefan What if

Re: [Patch] - Fix compilation of direct_uri-test.c on OS/2

2010-06-28 Thread Matthew Bentham
On 28/06/2010 10:29, Bert Huijben wrote: -Original Message- From: Julian Foad [mailto:julian.f...@wandisco.com] Sent: maandag 28 juni 2010 10:48 To: Paul Smedley Cc: dev@subversion.apache.org Subject: Re: [Patch] - Fix compilation of direct_uri-test.c on OS/2 On Sun, 2010-06-27, Paul

Re: svn commit: r920526 - /subversion/trunk/subversion/libsvn_wc/update_editor.c

2010-03-09 Thread Matthew Bentham
On 09/03/2010 15:40, Julian Foad wrote: On Tue, 2010-03-09 at 15:12 +, Matthew Bentham wrote: Revisions 920521 and later fail some tests for me. The first test program in 'make check' that fails is 'checkout_tests.py'. After that quite a few fail, including

svn commit: r920526 - /subversion/trunk/subversion/libsvn_wc/update_editor.c

2010-03-09 Thread Matthew Bentham
Revisions 920521 and later fail some tests for me. The first test program in 'make check' that fails is 'checkout_tests.py'. After that quite a few fail, including commit_tests.py and copy_tests.py. I'm letting make check run to completion now for current head (r920875) and I'll post the lo

Re: [PATCH] wc-ng - Remove use of entry_t from calculate_target_mergeinfo

2010-03-03 Thread Matthew Bentham
On 02/03/2010 17:18, Matthew Bentham wrote: On 02/03/2010 13:40, Matthew Bentham wrote: On 02/03/2010 13:06, Greg Stein wrote: ... On Tue, Mar 2, 2010 at 04:45, Matthew Benthamwrote: Because of the fragility around entry->copied, I can't really tell whether this patch is Righ

Re: [PATCH] wc-ng - Remove use of entry_t from calculate_target_mergeinfo

2010-03-02 Thread Matthew Bentham
On 02/03/2010 13:40, Matthew Bentham wrote: On 02/03/2010 13:06, Greg Stein wrote: On Tue, Mar 2, 2010 at 04:45, Matthew Bentham wrote: Trying to remove more uses of svn_wc_entry_t, it seems there is no way at the moment to get the equivalent of entry->copied using node routines. Is t

Re: [PATCH] wc-ng - Remove use of entry_t from calculate_target_mergeinfo

2010-03-02 Thread Matthew Bentham
On 02/03/2010 13:06, Greg Stein wrote: On Tue, Mar 2, 2010 at 04:45, Matthew Bentham wrote: Trying to remove more uses of svn_wc_entry_t, it seems there is no way at the moment to get the equivalent of entry->copied using node routines. Is this the sort of thing that is needed? [[[ wc

Re: [PATCH] wc-ng - Remove use of entry_t from calculate_target_mergeinfo

2010-03-02 Thread Matthew Bentham
On 02/03/2010 10:39, Philip Martin wrote: Matthew Bentham writes: +svn_wc__node_is_status_copied(svn_boolean_t *is_copied, + svn_wc_context_t *wc_ctx, + const char *local_abspath, + apr_pool_t *scratch_pool

[PATCH] wc-ng - Remove use of entry_t from calculate_target_mergeinfo

2010-03-02 Thread Matthew Bentham
e.h Add svn_wc__node_is_status_copied() * subversion/libsvn_client/copy.c (calculate_target_mergeinfo): Remove unused 'no_repos_access' parameter, replace use of svn_wc__get_entry with node routines. Patch by: Matthew Bentham ]]] Index: subversion/include/private/svn

Re: Is sqlite fast enough?

2010-02-22 Thread Matthew Bentham
On 22/02/2010 11:42, Matthew Bentham wrote: On 22/02/2010 11:13, Philip Martin wrote: Matthew Bentham writes: For me on CYGWIN_NT-6.0-WOW64 brahe 1.7.1(0.218/5/3) 2009-12-07 11:48 i686 Cygwin Thanks for testing! $ svn --version svn, version 1.6.9 (r901367) Create the test repo using

Re: Is sqlite fast enough?

2010-02-22 Thread Matthew Bentham
On 22/02/2010 11:13, Philip Martin wrote: Matthew Bentham writes: For me on CYGWIN_NT-6.0-WOW64 brahe 1.7.1(0.218/5/3) 2009-12-07 11:48 i686 Cygwin Thanks for testing! $ svn --version svn, version 1.6.9 (r901367) Create the test repo using the shell script, repeat "$ time svn stat

Re: Is sqlite fast enough?

2010-02-19 Thread Matthew Bentham
On 18/02/2010 21:58, kmra...@rockwellcollins.com wrote: Greg Stein wrote on 02/18/2010 03:31:19 PM: Awesome work! We've just been assuming/hoping it would be fast enough, and would resolve any problems "later". It is good to see we're in the right ballpark. On Thu, Feb 18, 2010 at 13:21, Phili

Re: [PATCH] wc-ng: remove a use of svn_wc_entry_t from libsvn_client

2010-02-19 Thread Matthew Bentham
On 18/02/2010 11:08, Matthew Bentham wrote: On 17/02/2010 18:40, Greg Stein wrote: On Wed, Feb 17, 2010 at 12:22, Matthew Bentham wrote: ... Revised patch attached fixes the unit test (and hopefully the indentation, if I've understood the style correctly), but I have no real instinct

Re: [PATCH] wc-ng: remove a use of svn_wc_entry_t from libsvn_client

2010-02-18 Thread Matthew Bentham
On 17/02/2010 18:40, Greg Stein wrote: On Wed, Feb 17, 2010 at 12:22, Matthew Bentham wrote: ... Revised patch attached fixes the unit test (and hopefully the indentation, if I've understood the style correctly), but I have no real instinct as to whether I should be modifying a libs

Re: [PATCH] wc-ng: remove a use of svn_wc_entry_t from libsvn_client

2010-02-17 Thread Matthew Bentham
* * subversion/libsvn_wc/node.c (svn_wc__internal_node_get_url): Find the URL of deleted nodes Patch by: Matthew Bentham ]]] Index: subversion/libsvn_client/commit_util.c === --- subversion/libsvn_client/commit_util.c (revision

Re: [PATCH] wc-ng: remove a use of svn_wc_entry_t from libsvn_client

2010-02-17 Thread Matthew Bentham
URL of deleted nodes Patch by: Matthew Bentham ]]] Index: subversion/libsvn_client/commit_util.c === --- subversion/libsvn_client/commit_util.c (revision 909397) +++ subversion/libsvn_client/commit_util.c (working copy) @@

Re: [PATCH] wc-ng: remove a use of svn_wc_entry_t from libsvn_client

2010-02-16 Thread Matthew Bentham
Philip Martin wrote: lock_tests.py 13 is failing: Darn, I thought I had fixed that problem :-) But I now realise I was confused between "lock_tests.py" and "locks-test.exe" (the latter doesn't even test libsvn_client). A complete 'make check' is impossible for me on cygwin, it takes about 4h

Re: [PATCH] wc-ng: remove a use of svn_wc_entry_t from libsvn_client

2010-02-15 Thread Matthew Bentham
Greg Stein wrote: For log messages, we also like to provide attribution, so at the end of the above message you would have: Patch by: Matthew Bentham btw I think this is not properly explained by http://subversion.apache.org/docs/community-guide/conventions.html#log-messages or http

Re: [PATCH] wc-ng: remove a use of svn_wc_entry_t from libsvn_client

2010-02-15 Thread Matthew Bentham
Hyrum K. Wright wrote: On Feb 12, 2010, at 8:10 AM, Greg Stein wrote: On Fri, Feb 12, 2010 at 10:39, Matthew Bentham wrote: Index: subversion/libsvn_client/commit_util.c === --- subversion/libsvn_client/commit_util.c

[PATCH] wc-ng: remove a use of svn_wc_entry_t from libsvn_client

2010-02-12 Thread Matthew Bentham
I understand from thread "WC-NG: How can we help with 1.7-readiness?" that this sort of thing is helpful. I am a massive newbie, please forgive me if I do something obviously wrong. [[[ wc-ng: work towards eliminating svn_wc_entry_t * subversion/libsvn_client/commit_util.c (add_lock_token):

Re: performance on cygwin

2010-02-10 Thread Matthew Bentham
s...@stsp.name wrote: On Wed, Feb 10, 2010 at 11:57:35AM +, Matthew Bentham wrote: I've been hearing rumours of performance improvements to Windows svn clients with the 'wc-ng' work. A couple of weeks ago I decided to have a go with subversion trunk to see what it wo

performance on cygwin

2010-02-10 Thread Matthew Bentham
ore, but still nowhere near as fast as subversion 1.6. That's where I am for now, I'm going to continue noodling with it but I hope these results are interesting. If anyone has anything that they would like me to try I would love to help. All the best, Matthew Bentham ART VPS Ltd.