;, line 1322, in
_find_libintl
ver = int(match.group(1), 0)
AttributeError: 'NoneType' object has no attribute 'group'
--
Masaru Tsuchiyama
_repospath.
() : fix help message.
() : add --svnrdump-path and --svn-path.
() : add --trust-server-cert.
() : add --no-auth-cache.
() : add --non-interactive.
() : add --print-stderr.
]]]
--
Masaru Tsuchiyama
Index: tools/server-side/svn-backu
Hello
Could you review my patch?
2013-09-08 23:25 GMT+09:00 Masaru Tsuchiyama :
> Ben Reser wrote:
> > On 8/18/13 5:34 AM, Daniel Shahaf wrote:
> >> Haven't looked at the rest of the patch, perhaps Ben will as he reviewed
> >> an earlier iteration. (but I
Does anybody review my patch?
Let me know a reason if my patch is not approprite
I re-create a patch for the lastest revison.
Regards.
--
Masaru Tsuchiyama
Index: build/generator/gen_win_dependencies.py
===
--- build/generator
> It's starred in my mailbox.
>
Hello Ben
Are you still busy?
--
Masaru Tsuchiyama
Does anybody review my patch?
Regards.
--
Masaru Tsuchiyama
Julian Foad wrote:
Masaru Tsuchiyama wrote:
the last two changes and the first change are adding new functionality.
Those change makes it easy to debug i18n feature.
I make a new patch.
[[[
creae LC_MESSAGES directories and
Julian Foad wrote:
This looks fine. I can't test it, but as it's trivial and non-critical I'm
willing to apply it anyway.
Committed in r1518290.
Thank you.
--
Masaru Tsuchiyama
Masaru Tsuchiyama wrote:
> [[[
> create po directory only if it doesn't exist to suppress a warning
>
> * build/generator/templates/build_locale.ezt
>() : create mo directory only if the directory doesn't exist,
> to suppress a warning.
> ]]]
I misty
Masaru Tsuchiyama wrote:
> Julian Foad wrote:> Masaru Tsuchiyama wrote:
> >>> () : create mo directory only if the directory doesn't exist,
> >>>to suppress a warning.
> >
> > OK, good.
>
> This change is independent.
&
Julian Foad wrote:> Masaru Tsuchiyama wrote:
>
>> Does anybody comment my patch?
>
> Hi Masaru.
>
> It's not clear what is the reason for these changes. Your log
message needs to answer the question "Why?".
>
>> Masaru Tsuchiyama wrote:
>>
Philip Martin wrote:
masaru tsuchiyama writes:
+ if (!fb->adding_file)
+{
+ if (fb->use_commit_times && fb->changed_date)
+{
+ SVN_ERR(svn_io_set_file_affected_time(fb->changed_date,
+
Hi.
Does anybody comment my patch?
--
Masaru Tsuchiyama
Masaru Tsuchiyama wrote:
Hi.
Does anybody comment my patch?
(2013/07/31 21:53), Masaru Tsuchiyama wrote:
Hi.
Running gen-make.py with --with-libintl option raises AttributeError
exception
when using svn-win32-libintl.zip
at
http
Daniel Shahaf wrote:
On Sat, Aug 03, 2013 at 03:52:49PM +0300, Daniel Shahaf wrote:
Masaru Tsuchiyama wrote on Sat, Aug 03, 2013 at 16:06:06 +0900:
If I run the these scripts at Release\subversion\tests\cmdline, I don't
get a file-not-found error.
So perhaps the right fix is not your
Hello Daniel
Could you comment the updated patch?
> I prefer that someone else review the semantics, i.e., the actual
> feature being added.
Does anybody comment for the feature?
--
Masaru Tsuchiyama
masaru tsuchiyama wrote:
> You still have several places where your cod
Does anybody comment my patch?
--
Masaru Tsuchiyama
Masaru Tsuchiyama wrote:
Hi
I attach a patch to create LC_MESSAGES directories and
copy subversion.mo files to the directories and do some extra works.
[[[
* build/generator/gen_win.py
(POFile.__init__) : set class member 'lan
Hello
Does anybody comment my patch?
--
Masaru Tsuchiyama
Masaru Tsuchiyama wrote:
> Hi
>
> I attach a patch to fix the following compiler error on VS2008
> "CVTRES : fatal error CVT1103: cannot read file".
>
> I got the error on tests projects.
&g
Hello
Does anybody comment my patch?
--
Masaru Tsuchiyama
Masaru Tsuchiyama wrote:
> Hello
>
> I attach a patch to implement command line options for smtp servers.
>
> [[[
> add command line options to mailer.py
>
> * tools/hook-scripts/mailer/mailer.py
>
Daniel Shahaf wrote:
r1515111, thanks.
Masaru Tsuchiyama wrote on Sun, Aug 18, 2013 at 22:43:58 +0900:
- # client converts to local encoding and local eoln style.
+ # client converts to local encoding and local eol style.
thanks
--
Masaru Tsuchiyama
those potential problems.
Thank you for the commit.
But I think you should catch a exception which parser.readfp() throws,
and print approprite error mesage.
I think Users who don't know Python prefer an well-formatted
error message to stack trace.
Regards.
--
Masaru Tsuchiyama
I attach a patch to fix typo in comment.
[[[
fix typo in comment
* subversion/tests/cmdline/prop_tests.py
(prop_value_conversions) : fix typo in comment.
]]]
Regards.
--
Masaru Tsuchiyama
Index: subversion/tests/cmdline/prop_tests.py
ename.
Fixed in the attached patch.
Regards.
--
Masaru Tsuchiyama
Index: gen-make.py
===
--- gen-make.py (revision 1515099)
+++ gen-make.py (working copy)
@@ -278,6 +278,9 @@ if __name__ == '__main__':
except getopt
Daniel Shahaf wrote:
+# pass "--" to tell commands that 'self.__repospath' is not a
command-line option.
+cmd = [ self.__svn_path, "log", "-l 1", "-q", "--", self.__repospath ]
["-l 1"] should be eit
from command line
or config.
(setup_option_parser) : create instance of OptionParser.
(usage) : print usage by using OptionParser.
(): parse command line by using OptionParser.
]]]
--
Masaru Tsuchiyama
Index: tools/hook-scripts/mailer/mailer.py
(2013/08/08 0:15), Daniel Shahaf wrote:
masaru tsuchiyama wrote on Thu, Aug 01, 2013 at 00:11:30 +0900:
* gen-make.py
() : use default value as conf when args[0] is line ending.
I don't use windows, but I think the right fix in this case is to
prevent ("\n" in sys.argv) fro
: add --print-stderr.
]]]
--
Masaru Tsuchiyama
Index: tools/server-side/svn-backup-dumps.py
===
--- tools/server-side/svn-backup-dumps.py (revision 1514160)
+++ tools/server-side/svn-backup-dumps.py (working co
local path,
svnrdump for an URL.
(SvnBackup.create_dump) : pass "--" before self.__repospath.
() : fix help message.
() : add --svnrdump-path and --svn-path.
() : add --trust-server-cert.
() : add --no-auth-cache.
() : add --non-interactive.
() : add --print-stderr.
]]]
> You still have several places where your code exceeds 80 characters.
Fixed at attached patch.
>> Encoding problem? I see a Yen symbol where a backslash should be.
What do you see in the attached file? I use Google web mailer.
2013/8/8 Daniel Shahaf
> Masaru Tsuchiyama wrote
e attached file, not inline text?
+ 'svn:date', '2001-01-01T00:00:00.00Z',
+ secs_svn_date = time.mktime( (2001, 1, 1, 0, 0, 0, 0, 0, 0) )
Personally I wouldn't use all-zeroes as the test value, that's too
likely to false
> Typo, "revision_regex"
fixed at the attached patch.
> > +cmd = [ self.__svnadmin_path, "dump",
> > +"--incremental", "-r", revparam,
self.__repospath ]
>
> That doesn't look right. If self.__repospath can be a local path to a
> repository root, you shouldn'
or_url for an URL
(SvnBackup.create_dump) : invoke svnadmin for a local path,
svnrdump for an URL.
() : fix help message.
() : add --svnrdump-path and --svn-path.
() : add --trust-server-cert.
() : add --no-auth-cache.
]]]
Regards.
--
Masaru Tsuchiyama
In
Hi.
Does anybody comment my patch?
(2013/08/04 9:36), Masaru Tsuchiyama wrote:
> Hello
>
> I attach a patch to add support for svnrdump to svn-backup-dumps.py.
>
> [[[
> add support for svnrdump to svn-backup-dumps.py
>
> * tools/server-side/svn-backup-dumps.
Hi.
Does anybody comment my patch?
(2013/08/01 0:11), masaru tsuchiyama wrote:
Hi
I attach a patch to fix exception when running gen-make.py
by the attached bat file which contains line ending after last ^.
( I rename the bat file to txt for security reason)
[[[
Fix exception when the
Hi.
Does anybody comment my patch?
(2013/07/31 21:53), Masaru Tsuchiyama wrote:
Hi.
Running gen-make.py with --with-libintl option raises AttributeError exception
when using svn-win32-libintl.zip
at
http://subversion.tigris.org/servlets/ProjectDocumentList?folderID=2627&expandFolde
r=
Hi.
Does anybody comment my patch?
(2013/07/31 22:29), Masaru Tsuchiyama wrote:
Hi
I attach a patch to create LC_MESSAGES directories and
copy subversion.mo files to the directories and do some extra works.
[[[
* build/generator/gen_win.py
(POFile.__init__) : set class member 'lan
g the test projects in parallel.
[[[
Fix compiler errors on VS2008 for test projects.
* build/generator/templates/vcnet_vcproj.ezt
() : append Intermediate Directory to $(ProjectName)
not to conflict output directories.
]]]
--
Masaru Tsuchiyama
Index: build/generator/templates/vcnet_
get_head_rev_for_local for a local
path, get_head_rev_for_url for an URL
(SvnBackup.create_dump) : invoke svnadmin for a local path,
svnrdump for an URL.
() : fix help message.
() : add --svnrdump-path and --svn-path.
]]]
Regards.
--
Masaru
this in the attached patch.
> Inheriting could be a later patch. Another issue in the current patch
> is the use of apr_time_now when the property is removed; changing that
> affects the regression test.
I added a test in update_with_use_commit_times() at
subversion/tests/cmdline/upda
> One of your later patches had a *.txt extension but
application/octet-stream
> MIME type. It would be good if you could get your client to set text/*
> MIME type --- this actually changes the way the patch renders in many
> devs' clients, makes it easier for them to read/review/reply the patch
> Please send patches as text/plain (*.txt extension often does this).
I understand.
> Masaru Tsuchiyama wrote on Sun, Jul 28, 2013 at 20:00:27 +0900:
> > +++ subversion/tests/cmdline/svntest/main.py(working copy)
> > @@ -412,12 +412,19 @@
> >if not
Hi.
I tried to compile it on Windows (with VS2008).
But I got a compler at libsvn_fs_x.
subversion\libsvn_fs_x\cached_data.c(1042) : error C4115: 'rep_state' : named
type definition in parentheses
I attach a patch to fix the compiler error.
Regards.
--
Masaru Tsuchiyama
fs
when args[0] is line ending.
]]]
--
Masaru Tsuchiyama
gen-make.py -t dsp ^
--with-httpd=..\common\httpd-2.2.25 ^
--with-sqlite=..\common\sqlite-amalgamation-3071700 ^
--with-swig=C:\swigwin-2.0.10
py mo files to the LC_MESSAGES directories as subversion.mo files.
]]]
Regards.
--
Masaru Tsuchiyama
locale.patch
Description: Binary data
self._find_libintl(show_warnings)
> File "build\generator\gen_win_dependencies.py", line 1185, in _find_libintl
> ver = int(match.group(1), 0)
> AttributeError: 'NoneType' object has no attribute 'group'
--
Masaru Tsuchiyama
> Author: rhuijben
> Dat
ion, and reraise the exception.
]]]
Regards
--
Masaru Tsuchiyama
main.patch
Description: Binary data
Hi.
I attache new patch.
[[[
add 'svn:use-commit-times' property. If a file has 'svn:use-commit-times'
property,
the timestamp of the file is modified to commit time.
* subversion/include/svn_props.h
(): add SVN_PROP_USE_COMMIT_TIMES and SVN_PROP_USE_COMMIT_TIMES_VALUE
(): ad
Hi.
Does anybody comment my patch?
--
Masaru Tsuchiyama
Hi.
Thank you for reverting r1485650.
r1506966 needs to be merged to 1.8.x branch.
Could you noninate it?
--
Masaru Tsuchiyama
Hi.
> That is the problem. That string should be UTF-8. How does it get to
> be shift-JIS? The translations should be in UTF-8. Are you using old
> i18l tools?
cmdline_stream_printf at svnadmin.c calls svn_cmdline_cstring_from_utf8().
svn_cmdline_cstring_from_utf8 convert UTF-8 to Shift JIS.
ls svn_utf__cstring_is_valid().
5. Then svn_utf__cstring_is_valid() returns 0 for Shift-JIS string.
(Variable 'state' is 8 [FSM_ERROR])
6. check_cstring_utf8() returns APR_EINVAL.
--
Masaru Tsuchiyama
> Masaru Tsuchiyama writes:
>
> > The output of 'svnadmin dump' is garble
The output of svn_cmdline_cstring_from_utf8_fuzzy is used as stdout
output.
--
Masaru Tsuchiyama
ng without --with-libintl, it doesn't get the exception.
This exception was introduced at r1504501 and was partially fixed at r1504947.
Regards.
--
Masaru Tsuchiyama
(SVN_PROP_NODE_ALL_PROPS) add SVN_PROP_USE_COMMIT_TIMES to
SVN_PROP_NODE_ALL_PROPS.
* subversion/libsvn_wc/workqueue.c
(run_file_install): set use_commit_times flag to TRUE if
'svn:use-commit-times' property is set.
]]]
--
Masaru Tsuchiyama
test.pl
Description: Binary data
svn-use-commit-times.patch
Description: Binary data
Hi.
I found a typo in comment.
I resend a patch.
--
Masaru Tsuchiyama
> Hi.
>
> Thank you for the review.
> I attach a fixed patch.
>
> [[[
>issue #4299: add sub command 'youngest' to svn
>
>* subversion/svn/cl.h
> (svn_cl__opt_state_t
gest' sub command handler.
]]]
--
Masaru Tsuchiyama
> On 07/20/2013 02:42 AM, Masaru Tsuchiyama wrote:
> > Hi.
> >
> > I implement 'youngest' sub command to svn, and attach a patch.
> >
>
> Masaru,
>
> Thanks for the patch. I didn't
ions): Add --new-line option.
(svn_cl__cmd_table): Add 'youngest' entry.
(sub_main): Add 'n' option.
* subversion/svn/youngest-cmd.c
(svn_cl__youngest): implement the 'youngest' sub command handler.
]]]
--
Masaru Tsuchiyama
> Hi.
>
&g
Hi.
I implement 'youngest' sub command to svn, and attach a patch.
--
Masaru Tsuchiyama
> On 07/19/2013 08:37 PM, Masaru Tsuchiyama wrote:
> > Hi.
> >
> > I attach a patch to add sub command 'youngest' to svnrdump.
> >
> &g
ting youngest option.
]]]
--
Masaru Tsuchiyama
svnrdump.patch
Description: Binary data
Hi.
I attach a patch to fix typo in gen_win_dependencies.py.
Regards.
--
Masaru Tsuchiyama
gen_win_dependencies.patch
Description: Binary data
Hi.
I attach a patch to fix typo in svn_private_config.hw.
Regards.
--
Masaru Tsuchiyama
svn_private_config.patch
Description: Binary data
Hi
I attach a patch to fix KeyError Exception without setting
--with-berkeley-db option.
--
Masaru Tsuchiyama
gen_win.patch
Description: Binary data
Hi.
I attach a patch to fix typo in website.
Regards.
--
Masaru Tsuchiyama
release_note.patch
Description: Binary data
The crash also happens on WinXP SP2.
I use svn.exe client
serf: trunk r1375
subversion: trunk r947299
apache: 2.2.15
The attached file is the callstack when doing
svn co http://svn.apache.org/repos/asf/subversion/trunk
Regards.
Masaru.
2010/5/17 Stefan Küng :
> On 16.05.2010 18:31, Bert Huijbe
Thanks.
Masaru.
2009/12/14 Bert Huijben :
>> -Original Message-
>> From: masaru tsuchiyama [mailto:m.tma...@gmail.com]
>> Sent: zaterdag 12 december 2009 13:36
>> To: Stefan Sperling
>> Cc: Hyrum K. Wright; dev@subversion.apache.org
>> Subject:
Hi.
I'll send the patch again.
[[[
Fix warning PRJ0009 when building with Visual Studio.
* build/generator/neon.vcproj.ezt
* build/generator/serf.vcproj.ezt
* build/generator/svn_config.vcproj.ezt
* build/generator/svn_locale.vcproj.ezt
* build/generator/templates/vcnet_vcproj.ezt
* build/genera
Hi.
I had attached 'BuildLogFile.patch' in the mail.
Regards.
Masaru.
2009/12/12 Hyrum K. Wright :
> I may be dense, but I don't think there was a patch attached to your original
> mail...
>
> On Dec 11, 2009, at 8:14 PM, masaru tsuchiyama wrote:
>
>>
Hi.
[[[
Fix warning PRJ0009 when building with Visual Studio.
* build/generator/neon.vcproj.ezt
* build/generator/serf.vcproj.ezt
* build/generator/svn_config.vcproj.ezt
* build/generator/svn_locale.vcproj.ezt
* build/generator/templates/vcnet_vcproj.ezt
* build/generator/zlib.vcproj.ezt
Add
66 matches
Mail list logo
