Re: [PATCH] support printing changed properties in svnlook

2011-01-06 Thread Erik Johansson
member; please review those semantics"? Yes it is, sorry for leaving that out. I was trying to get all the cases right that I totally forgot to add a summary. I'm interested in getting your input on the implementation and what you think about the proposed semantics. Thanks, // Eri

Re: [PATCH] support printing changed properties in svnlook

2011-01-05 Thread Erik Johansson
12. Replace node (w/ or w/o props) with copied node w/ modified props => mod_props contains all modified props We don't include any props from the deleted node (case 3 and 4) but the modified props from the copied node (case 8). // Erik -- Erik Johansson Home Page: http://ej

Re: [PATCH] Correct documentation for svn_repos_node_editor and friends

2010-12-29 Thread Erik Johansson
On Mon, Dec 13, 2010 at 21:35, Erik Johansson wrote: > An attempt to untangle the mess discussed in > http://svn.haxx.se/dev/archive-2010-12/0258.shtml Take 2. I have tried to update the documentation according to the comments to the previous patch. Please let me know what you think. /

Re: [PATCH] support printing changed properties in svnlook

2010-12-22 Thread Erik Johansson
On Fri, Dec 10, 2010 at 15:08, Daniel Shahaf wrote: > [ I'm somewhat confused about this issue. ] > > Erik Johansson wrote on Thu, Dec 09, 2010 at 21:41:38 +0100: >> On Wed, Dec 8, 2010 at 23:22, Daniel Shahaf wrote: >> > Erik Johansson wrote on Wed, D

Re: [PATCH] support printing changed properties in svnlook

2010-12-22 Thread Erik Johansson
linked >> list was that svn_repos_node_t did that and I wanted them to be >> similar. >> > > Hmm.  I haven't seen that struct before: svn_repos_node_t indeed uses an > explicit tree structure. > > What do you think will be more useful to consumers of the API?  A hash > allows both random access and iteration --- do APR arrays or linked > lists have advantages that outweigh that? A hash seemed like overkill, but if you think it is better I have no problem using that. // Erik -- Erik Johansson Home Page: http://ejohansson.se/ PGP Key: http://ejohansson.se/erik.asc

Re: [PATCH] Correct documentation for svn_repos_node_editor and friends

2010-12-22 Thread Erik Johansson
On Sat, Dec 18, 2010 at 20:43, Daniel Shahaf wrote: > Erik Johansson wrote on Tue, Dec 14, 2010 at 19:19:17 +0100: >> [[[ >> r846201 added svn_repos_replay as a "replacement not so much for >> svn_repos_dir_delta, but for at least a whole class of functionality that

Re: [PATCH] Correct documentation for svn_repos_node_editor and friends

2010-12-14 Thread Erik Johansson
s name to '*.txt' or trying some other trick to encourage your > client software to mark it as a plain-text MIME type.  Cheers. Trying again... -- Erik Johansson Home Page: http://ejohansson.se/ PGP Key: http://ejohansson.se/erik.a

Re: [PATCH] support printing changed properties in svnlook

2010-12-13 Thread Erik Johansson
only use for it would be internal to the application in which case it will use its version of the struct even if we change it. - If we add the new field to the end of the struct there should be no problems for applications built with an old version of the struct; they will simply not

[PATCH] Correct documentation for svn_repos_node_editor and friends

2010-12-13 Thread Erik Johansson
version/include/svn_repos.h (svn_repos_node_editor, svn_repos_node_from_baton): Doc update ]]] -- Erik Johansson Home Page: http://ejohansson.se/ PGP Key: http://ejohansson.se/erik.asc

Re: [PATCH] support printing changed properties in svnlook

2010-12-10 Thread Erik Johansson
On Fri, Dec 10, 2010 at 13:53, Julian Foad wrote: > Great.  Do you feel up to writing some Python tests for this to add to > the regression test suite?  That would be very useful. Sure, will do. // Erik -- Erik Johansson Home Page: http://ejohansson.se/ PGP Key: http://ejohansson.se/erik.asc

Re: [PATCH] support printing changed properties in svnlook

2010-12-10 Thread Erik Johansson
ed it by calling svn_fs_check_path() and checking that node kind != svn_node_none before calling svn_fs_node_prop(). It will be in the next patch version. Thanks for testing. // Erik -- Erik Johansson Home Page: http://ejohansson.se/ PGP Key: http://ejohansson.se/erik.asc

Re: [PATCH] support printing changed properties in svnlook

2010-12-09 Thread Erik Johansson
On Wed, Dec 8, 2010 at 23:22, Daniel Shahaf wrote: > Erik Johansson wrote on Wed, Dec 08, 2010 at 17:17:47 +0100: >> To support this, the editor created by svn_repos_node_editor has been >> modified >> to record changes to properties (requires the replay to be done with del

[PATCH] support printing changed properties in svnlook

2010-12-08 Thread Erik Johansson
Support printing changed properties. ]]] -- Erik Johansson Home Page: http://ejohansson.se/ PGP Key: http://ejohansson.se/erik.asc Index: subversion/include/svn_repos.h === --- subversion/include/svn_repos.h (revision 1043363) +++ subversio