Re: Proposal: Rename svnrdump

2010-07-26 Thread David Glasser
On Mon, Jul 26, 2010 at 8:30 AM, Justin Erenkrantz wrote: > On Mon, Jul 26, 2010 at 8:10 AM, Hyrum K. Wright > wrote: >> +1.  The charter for svnadmin is currently, and should remain, solely >> focused on local access to a repository. > > Why? > > svnadmin dump --remote > > seems the most intuit

Re: svn commit: r966431 - /subversion/trunk/subversion/libsvn_ra/compat.c

2010-07-21 Thread David Glasser
Thanks for acting on this! I wish I had the time to actually fix the bugs people show me these days. On Wed, Jul 21, 2010 at 2:40 PM, wrote: > Author: rhuijben > Date: Wed Jul 21 21:40:10 2010 > New Revision: 966431 > > URL: http://svn.apache.org/viewvc?rev=966431&view=rev > Log: > Following up

Re: svn commit: r27653 - in trunk/subversion: libsvn_client libsvn_ra

2010-07-20 Thread David Glasser
Let's play "incredibly late code review"! The fallback implementation svn_ra__file_revs_from_log incorrectly ignores its "path" argument. (The only call from libsvn_client hardcodes "" as that argument, so people using libsvn_client instead of libsvn_ra directly will not notice.) Also, if pointe

Re: useful extra check in FS fold_change function

2010-03-22 Thread David Glasser
On Mon, Mar 22, 2010 at 9:46 AM, C. Michael Pilato wrote: > C. Michael Pilato wrote: >> David Glasser wrote: >>>> Is the attached patch what you had in mind?  (Plus similar logic for FSFS, >>>> of course.) >>> Ah, yes, that's what I meant

Re: useful extra check in FS fold_change function

2010-03-19 Thread David Glasser
On Fri, Mar 19, 2010 at 10:26 AM, C. Michael Pilato wrote: > David Glasser wrote: >> When dealing with some nasty cases in the almost-retired old Google >> Code subversion backend, I found a kind of data corruption that the FS >> code wasn't catching even though it

useful extra check in FS fold_change function

2010-03-18 Thread David Glasser
When dealing with some nasty cases in the almost-retired old Google Code subversion backend, I found a kind of data corruption that the FS code wasn't catching even though it caught relatively similar issues. Specifically, find the fold_change function in both of the FS implementations. There's a

Re: svn client protocol (svn:// uri) specification + any client implementation , if any

2010-03-16 Thread David Glasser
Since you specify "Apache licensed" I assume you are familiar with SVNKit. By the way, be aware that the Subversion project's compatibility efforts don't apply to the svn wire protocols, which are only documented for the convenience of developers. While we aren't going to go out of our way to brea

Re: Will subversion participate in Google Summer of Code 2010?

2010-02-23 Thread David Glasser
On Tue, Feb 23, 2010 at 6:07 AM, Hyrum K. Wright wrote: > > On Feb 23, 2010, at 7:57 AM, Azhagu Selvan wrote: > >> On Monday 22 February 2010 08:56 PM, Daniel Näslund wrote: >>> On Sun, Feb 21, 2010 at 07:28:13AM -0800, Justin Erenkrantz wrote: >>> On Sun, Feb 21, 2010 at 5:11 AM, Daniel Näsl

Re: More strict file permissions for the administrative ".svn" directories

2010-01-14 Thread David Glasser
On Tue, Jan 12, 2010 at 10:40 AM, Ivan Zahariev wrote: > Hi devs, > > I've first discussed this at the "users" list and there was no big > interest but also no negative feedback there. Therefore I'm suggesting > this to you now: > > Would you make the ".svn" directories not accessible by "others"

Re: Obliterate - an elementary case is now working

2009-12-27 Thread David Glasser
That's great to hear! What's the effect on WCs? Do WCs with the bad rev get "fixed" on update? Do WCs that never had the bad rev skip over it fine? --dave On Tue, Dec 22, 2009 at 11:21 AM, Julian Foad wrote: > Hi, Obliterate fans. > > As of r893267, if you compile with "-DSVN_WITH_EXPERIMENTAL_

Re: 1.6.7 Release Status

2009-12-21 Thread David Glasser
On Mon, Dec 21, 2009 at 9:51 PM, Justin Erenkrantz wrote: > On Mon, Dec 21, 2009 at 5:58 PM, Hyrum K. Wright > wrote: >> Personally, I don't like any of them, and am hoping there is still some way >> of using Subversion commits to www/.  Thoughts? > > I'm not sure what Greg thinks, but if tigris

Re: svn commit: r886164 - in /subversion/trunk/subversion: svn/main.c tests/cmdline/getopt_tests_data/svn_help_log_switch_stdout

2009-12-02 Thread David Glasser
On Wed, Dec 2, 2009 at 7:46 AM, Paul Burba wrote: > On Wed, Dec 2, 2009 at 9:52 AM,   wrote: >> Author: cmpilato >> Date: Wed Dec  2 14:52:49 2009 >> New Revision: 886164 >> >> URL: http://svn.apache.org/viewvc?rev=886164&view=rev >> Log: >> Fixup a blatant, flagrant, evil lie of the Devil found i

Re: should be able to repos_replay r0, right?

2009-11-24 Thread David Glasser
On Tue, Nov 24, 2009 at 6:54 AM, C. Michael Pilato wrote: > David Glasser wrote: >> There's no reason you shouldn't expect be able to call repos_replay on >> the root of r0, right? >> >> As of now if send_deltas is true it tries to create a root for r-1, >

should be able to repos_replay r0, right?

2009-11-23 Thread David Glasser
There's no reason you shouldn't expect be able to call repos_replay on the root of r0, right? As of now if send_deltas is true it tries to create a root for r-1, which predictably fails. I think we can just hardcode it to call set_target_revision(0) and then return. --dave -- glas...@davidglas

Re: Merge mode (Was Classifying files as binary or text)

2009-11-18 Thread David Glasser
I'm not a MIME expert, but isn't there a thing where you can add key/value pairs after a MIME type which customize its meaning? Maybe that could be used for this? --dave On Tue, Nov 17, 2009 at 7:05 PM, Julian Foad wrote: > I need to spend some time replying, late at night though it is. > > Let