Re: [PATCH] Check the change argument for a double minus at the start.

2024-05-21 Thread Timofey Zhakov
On Tue, May 21, 2024 at 9:23 PM Nathan Hartman wrote: > > On Mon, May 20, 2024 at 10:37 AM Timofey Zhakov wrote: > > > > On Mon, May 20, 2024 at 7:03 AM Nathan Hartman > > wrote: > > > > > > On Sun, May 19, 2024 at 4:09 PM Timofey Zhakov wrote: > > > > > > > > Hi, > > > > > > > > I found a lit

Re: [PATCH] Check the change argument for a double minus at the start.

2024-05-21 Thread Nathan Hartman
On Mon, May 20, 2024 at 10:37 AM Timofey Zhakov wrote: > > On Mon, May 20, 2024 at 7:03 AM Nathan Hartman > wrote: > > > > On Sun, May 19, 2024 at 4:09 PM Timofey Zhakov wrote: > > > > > > Hi, > > > > > > I found a little bug in parsing a change revision: If the number, > > > given to the --cha

Move change revision parser to libsvn_subr

2024-05-21 Thread Timofey Zhakov
Hi, When I was fixing a bug related to the change revision argument (-c), I noticed that the function which parses the change revision argument is implemented implicitly in the sub_main (in file svn.c) [1], while other revision parsers such as svn_opt_parse_revision_to_range are implemented in the

Re: [PATCH] Check the change argument for a double minus at the start.

2024-05-21 Thread Timofey Zhakov
>> [...] > > Found another similar issue in -c option. > > The following works correctly: > > $ ~/svn/1.14.3/bin/svn diff -c '0-1' file:///tmp/svnrepos > svn: E205000: There is no change 0 > > However, the following aborts: > > $ ~/svn/1.14.3/bin/svn diff -c '1-0' file:///tmp/svnrepos > svn: E23500

Re: [PATCH] Specify editor guidelines from the EditorConfig file.

2024-05-21 Thread Timofey Zhakov
Thank you for reasoning your point. After doing additional research, I found that the `rulers` is used less, so I decided to not add it. I updated the patch and log message. For sure I included details about support in different editors to the code and log message. [[[ Specify guidelines and max

Re: [PATCH] Specify editor guidelines from the EditorConfig file.

2024-05-21 Thread Daniel Sahlberg
Den mån 20 maj 2024 kl 18:53 skrev Timofey Zhakov : > Hello, > > Thank you for rapid response, > > On Mon, May 20, 2024 at 6:16 PM Daniel Sahlberg > wrote: > > > > Hi > > > > I can find very little information about the guidelines keyword. > > > > Is this a widely supported option in .editorconfi