Re: Pristines-on-demand: authz denied during textbase sync

2022-02-19 Thread Daniel Shahaf
Daniel Shahaf wrote on Sat, Feb 19, 2022 at 13:35:22 +: > Julian Foad wrote on Fri, Feb 18, 2022 at 17:00:02 +: > > I committed the proposed fix in r1898184: > > [[[ > > On the 'pristines-on-demand-on-mwf' branch: fix authz_tests.py 31. > > > > This test runs an 'update' after read access

Linking to the archives (was: Re: A two-part vision for Subversion and large binary objects.)

2022-02-19 Thread Daniel Shahaf
Julian Foad wrote on Fri, Feb 18, 2022 at 09:01:27 +: > I asked about this in this thread a few weeks ago; you could see there > for further discussion. (I tried to dig up a link but having trouble > finding myself in the archives.) FWIW, if you have a mail locally, you can pipe it to

Re: multi-wc-format review

2022-02-19 Thread Mark Phippard
On Sat, Feb 19, 2022 at 10:39 AM Stefan Kueng wrote: > > This use-case is already supported by the use of the oldest WC format by > > default, isn't it? > > ah, yes. If the oldest supported format is used then of course the env > variable isn't necessary. I was under the impression that the newes

Re: Make 'svn patch' keep permissions of patched files

2022-02-19 Thread Daniel Shahaf
Stefan Sperling wrote on Thu, Feb 10, 2022 at 09:29:12 +0100: > On Thu, Feb 10, 2022 at 12:10:08AM -0600, Karl Fogel wrote: > > On 09 Feb 2022, Ruediger Pluem wrote: > > > When rebuilding my own Subversion build I stumbled across the following > > > patch that I add to my build: > > > > > > Index:

Re: multi-wc-format review

2022-02-19 Thread Stefan Kueng
On 19.02.2022 16:31, Daniel Shahaf wrote: Stefan Kueng wrote on Sat, Feb 19, 2022 at 16:11:59 +0100: I guess I'm a little late to this discussion, but I just upgraded today to the svn trunk and saw the new APIs. From what I understand is that new clients can choose which WC format to use dur

Re: multi-wc-format review

2022-02-19 Thread Daniel Shahaf
Stefan Kueng wrote on Sat, Feb 19, 2022 at 16:11:59 +0100: > I guess I'm a little late to this discussion, but I just upgraded today to > the svn trunk and saw the new APIs. > From what I understand is that new clients can choose which WC format to use > during checkout/upgrade? > Yes. By defaul

Re: Pristines-on-demand: authz denied during textbase sync

2022-02-19 Thread Daniel Shahaf
Julian Foad wrote on Sat, Feb 19, 2022 at 14:00:46 +: > Thanks, Daniel. I'll take a look at this some time in the next few days > unless someone beats me to it. > > Daniel Shahaf wrote: > > [...] What race condition is that? The change to authz happened before the > >sync, not between the sy

Re: multi-wc-format review

2022-02-19 Thread Stefan Kueng
I guess I'm a little late to this discussion, but I just upgraded today to the svn trunk and saw the new APIs. From what I understand is that new clients can choose which WC format to use during checkout/upgrade? If that's correct, I'd like to propose a small enhancement: * provide an env vari

multi-wc-format review

2022-02-19 Thread Daniel Shahaf
1. How can a user ask a working copy what range of minor versions it supports? Cf. "Compatible With Version:" in `svnadmin info` output. I see these: % subversion/svn/svn info wc --show-item=wc-format 31 % subversion/svn/svn info wc --show-item=wc-format-min 31 % subversion/s

Re: Pristines-on-demand: authz denied during textbase sync

2022-02-19 Thread Julian Foad
Thanks, Daniel. I'll take a look at this some time in the next few days unless someone beats me to it. Daniel Shahaf wrote: > [...] What race condition is that? The change to authz happened before the >sync, not between the sync and the main operation. Yes, it's not directly related to this; it

Re: Pristines-on-demand: authz denied during textbase sync

2022-02-19 Thread Daniel Shahaf
Daniel Shahaf wrote on Sat, Feb 19, 2022 at 13:35:22 +: > This seems to have regressed the failure mode of «svn cat iota@BASE» > when iota is locally-modified and has no read access. > > To reproduce: > Here's a patch too: [[[ Index: subversion/tests/cmdline/authz_tests.py =

Re: Pristines-on-demand: authz denied during textbase sync

2022-02-19 Thread Daniel Shahaf
Julian Foad wrote on Thu, Feb 17, 2022 at 22:20:17 +: > Proposed fix: in "text base sync" phase, ignore auth error while > fetching any text base; continue with trying to fetch the rest. > > That works in terms of the test case passing. > > Can anyone think of issues with this approach, not l

Re: svn commit: r1897443 - in /subversion/trunk/subversion/tests/cmdline/svntest: actions.py main.py

2022-02-19 Thread Daniel Shahaf
Daniel Shahaf wrote on Tue, Feb 08, 2022 at 11:47:47 +: > Jun Omae wrote on Sat, Feb 05, 2022 at 00:28:51 +0900: > > After r1897443, prop_tests.py 12 is failing on Windows. > > > > svntest.Failure: Repository diskpath in stderr: [ > > "svn: E175008: While handling the 'cash-sound' property on