Re: Make: missing dependency on config_keys.inc

2022-02-10 Thread Daniel Shahaf
Julian Foad wrote on Thu, Feb 10, 2022 at 11:05:46 +: > A little build annoyance: > > When I added > > #define SVN_CONFIG_OPTION_WC_PRISTINES_MODE "pristines-mode" > > in 'subversion/include/svn_config.h', our build system regenerated > 'config_keys.inc' to include that new definit

Re: Make 'svn patch' keep permissions of patched files

2022-02-10 Thread Karl Fogel
On 10 Feb 2022, Stefan Sperling wrote: On Thu, Feb 10, 2022 at 12:10:08AM -0600, Karl Fogel wrote: I'm curious: what is the case that causes the patched target file to have different permissions than it had before the patch? (Or am I misunderstanding what you're saying?) Possibly related to

Re: [PATCH] Sketch of per-user/per-wc config for pristines-mode

2022-02-10 Thread Karl Fogel
On 10 Feb 2022, Julian Foad wrote: Julian Foad wrote: pristines-on-demand behaviour needs to be made conditional on WC format. [...] Once that is done, I plan to return to this per-WC config option storage. Now that we have (just) decided the default WC format will be the old format (31) an

Re: [PATCH] Sketch of per-user/per-wc config for pristines-mode

2022-02-10 Thread Evgeny Kotkov
Julian Foad writes: > Some people said it should be in wc.db. Evgeny wrote, "this sounds like > a property associated with a specificwc_id in the database. I would say > that this pretty much rules out optionsof storing it outside the wc.db." > But (Brane wrote) "WC_ID is hardcoded to 1 pretty m

Re: [PATCH] Sketch of per-user/per-wc config for pristines-mode

2022-02-10 Thread Julian Foad
Julian Foad wrote: > pristines-on-demand behaviour needs to be made conditional on WC format. > [...] > Once that is done, I plan to return to this per-WC config option storage. Now that we have (just) decided the default WC format will be the old format (31) and upgrading a WC will be optional, t

Re: Multi-WC-format branch: preparing for merge to trunk

2022-02-10 Thread Julian Foad
r1897943 makes the default for "--compatible-version" (and tests) be "1.8". - Julian

Re: Multi-WC-format branch: preparing for merge to trunk

2022-02-10 Thread Mark Phippard
On Thu, Feb 10, 2022 at 7:25 AM Julian Foad wrote: > > It strikes me now, given Subversion's "mature, stable" phase of life, > that we should default to backward compatibility. > > Change the default to --compatible-version=1.8 (same as =1.14), instead > of 1.15 (format 32). Both for "checkout" an

Re: Multi-WC-format branch: preparing for merge to trunk

2022-02-10 Thread Julian Foad
It strikes me now, given Subversion's "mature, stable" phase of life, that we should default to backward compatibility. Change the default to --compatible-version=1.8 (same as =1.14), instead of 1.15 (format 32). Both for "checkout" and "upgrade". The user will need to specify "--compatible-versio

Make: missing dependency on config_keys.inc

2022-02-10 Thread Julian Foad
A little build annoyance: When I added #define SVN_CONFIG_OPTION_WC_PRISTINES_MODE "pristines-mode" in 'subversion/include/svn_config.h', our build system regenerated 'config_keys.inc' to include that new definition. In subversion/libsvn_subr/cmdline.c:905 says: #include "config_keys.

Re: Multi-WC-format branch: preparing for merge to trunk

2022-02-10 Thread Julian Foad
> I think this branch is now ready to merge to trunk. I am now asking for review. To help, here is an overview of the branch changes, compiled from its log messages: Instead of supporting just one format, introduce a curren

Re: A two-part vision for Subversion and large binary objects.

2022-02-10 Thread Julian Foad
My current plan: * multi-wc-format is, I consider, ready for merge to trunk. See thread [1]. -> Please review it. - I can post a diff and a summary log message to help reviewers. * Make pristines-on-demand behaviour conditional on WC format. - The changes are mostly simple if a bit fi

Re: Make 'svn patch' keep permissions of patched files

2022-02-10 Thread Stefan Sperling
On Thu, Feb 10, 2022 at 12:10:08AM -0600, Karl Fogel wrote: > On 09 Feb 2022, Ruediger Pluem wrote: > > When rebuilding my own Subversion build I stumbled across the following > > patch that I add to my build: > > > > Index: subversion/libsvn_client/patch.c > >