Re: [PATCH] limit diff effort to fix performance issue

2021-06-02 Thread Johan Corveleyn
On Wed, Jun 2, 2021 at 4:05 PM Daniel Shahaf wrote: > > Stefan Sperling wrote on Wed, 02 Jun 2021 12:20 +00:00: > > The test suite is passing, which implies that trivial diffs aren't affected > > by this change. I expect that most, if not all, diffs which people actually > > want to read will rema

Re: [PATCH] limit diff effort to fix performance issue

2021-06-02 Thread Nathan Hartman
On Wed, Jun 2, 2021 at 8:20 AM Stefan Sperling wrote: > I've heard of several instances where users complain that 'svn update' > takes an extraordinary amount of time to run (in terms of hours). Ouch! P vs NP situation? In general I think it is reasonable to limit effort in order to generate a

Re: [PATCH] limit diff effort to fix performance issue

2021-06-02 Thread Daniel Shahaf
Stefan Sperling wrote on Wed, 02 Jun 2021 12:20 +00:00: > The test suite is passing, which implies that trivial diffs aren't affected > by this change. I expect that most, if not all, diffs which people actually > want to read will remain unaffected. But I cannot tell with 100% certainty. Not with

Re: [PATCH] limit diff effort to fix performance issue

2021-06-02 Thread C. Michael Pilato
On Wed, Jun 2, 2021 at 8:20 AM Stefan Sperling wrote: > ther diff implementations limit the effort spent by aborting after a > certain number of search iterations, and then simply use the valid > traversal which was most recently discovered. The libxdiff code used by Git > does this, as does the

[PATCH] limit diff effort to fix performance issue

2021-06-02 Thread Stefan Sperling
I've heard of several instances where users complain that 'svn update' takes an extraordinary amount of time to run (in terms of hours). At elego we have received files which reproduce such behaviour. These files are XML files that are almost 100MB in size. While versioning such data is not the pr