On Sat, Nov 14, 2020 at 4:51 AM Branko Čibej wrote:
>
> On 13.11.2020 17:37, Nathan Hartman wrote:
> > On Fri, Nov 13, 2020 at 9:20 AM Branko Čibej wrote:
> >> On 07.09.2020 15:30, hartmannat...@apache.org wrote:
> >>> Author: hartmannathan
> >>> Date: Mon Sep 7 13:30:38 2020
> >>> New Revision:
On 27.01.2021 13:00, Johan Corveleyn wrote:
^^ some lines indented with tabs instead of spaces
^^ curly brace should be on next line
^^ The comment above, describing how the JVM crashes, refers to the
situation before you actually fixed that :-). Can you rephrase it a
bit, so it is still a
On 2021/01/28 7:33, Johan Corveleyn wrote:
> On Wed, Jan 27, 2021 at 10:19 PM Yasuhito FUTATSUKI
> wrote:
>>
>> On 2021/01/28 5:43, Johan Corveleyn wrote:
>>> On Mon, Mar 16, 2020 at 5:11 AM wrote:
>>> [[[
>>> C:\test>set EDITOR="C:\Program Files\Notepad++\notepad++" -nosession
>>> -multiInst
On 27.01.2021 22:56, Johan Corveleyn wrote:
Thanks for explaining. Hm, maybe it would be good to note this in some
form in the commit message, yes. Just to make sure others scrolling
through this in the future are not puzzled by it. Something like:
"While here, remove the early exit on null jclo
On 27.01.2021 23:04, Johan Corveleyn wrote:
BTW, if you would subscribe to comm...@subversion.apache.org (by
sending a mail to commits-subscribe@s.a.o), you would see the
log-message-changes (and all commits) from that side too. Not required
of course, but I use it as a means to follow along a b
On Wed, Jan 27, 2021 at 10:19 PM Yasuhito FUTATSUKI
wrote:
>
> On 2021/01/28 5:43, Johan Corveleyn wrote:
> > On Mon, Mar 16, 2020 at 5:11 AM wrote:
> >>
> >> Author: jamessan
> >> Date: Mon Mar 16 04:11:36 2020
> >> New Revision: 1875230
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1875230&vi
On Wed, Jan 27, 2021 at 10:47 PM Alexandr Miloslavskiy
wrote:
>
> On 27.01.2021 11:34, Johan Corveleyn wrote:
> >> + jobject jrequest;
> >> + jobject jresponse;
> >
> > These new fields are not mentioned in the log message.
> >
> >> @@ -523,7 +527,10 @@ jobject create_Channel(const char *class
>
On Wed, Jan 27, 2021 at 10:32 PM Alexandr Miloslavskiy
wrote:
>
> On 27.01.2021 11:13, Johan Corveleyn wrote:
> >> +void
> >> +OperationContext::closeTunnel(void *tunnel_context, void *)
> >> +{
> >> + TunnelContext* tc = static_cast(tunnel_context);
> >> + jobject jclosecb = tc->jclosecb;
> >>
On 27.01.2021 11:34, Johan Corveleyn wrote:
+ jobject jrequest;
+ jobject jresponse;
These new fields are not mentioned in the log message.
@@ -523,7 +527,10 @@ jobject create_Channel(const char *class
jmethodID ctor = env->GetMethodID(cls, "", "(J)V");
^^ also not mentioned in log me
On Wed, Jan 27, 2021 at 10:16 PM Alexandr Miloslavskiy
wrote:
>
> Thanks for reviewing! You're quite the savior of this branch :)
Heh, you're welcome :). And thanks for bringing it here in the first place.
> On 27.01.2021 11:02, Johan Corveleyn wrote:
> > was wondering what you meant by "This e
On 27.01.2021 11:13, Johan Corveleyn wrote:
+void
+OperationContext::closeTunnel(void *tunnel_context, void *)
+{
+ TunnelContext* tc = static_cast(tunnel_context);
+ jobject jclosecb = tc->jclosecb;
+ delete tc;
+
+ JNIEnv *env = JNIUtil::getEnv();
+ if (JNIUtil::isJavaExceptionThrown())
+
On 27 Jan 2021, Yasuhito FUTATSUKI wrote:
This is because SVN_MERGE does not execute through a shell, whole
value is treated as a single path. On the other hand, SVN_EDITOR
is passed to system() and is interpreted by a shell.
Ah, thank you for the explanation. What I saw makes sense now.
H
On 27 Jan 2021, Daniel Shahaf wrote:
You're welcome. I see only a few more nits; see below. (Some of
them I noticed in the first iteration too, but I didn't want to
pick too many nits then.) I'm happy that the patch is correct
and committable, though it won't make the "Major features in this
On 2021/01/28 5:43, Johan Corveleyn wrote:
> On Mon, Mar 16, 2020 at 5:11 AM wrote:
>>
>> Author: jamessan
>> Date: Mon Mar 16 04:11:36 2020
>> New Revision: 1875230
>>
>> URL: http://svn.apache.org/viewvc?rev=1875230&view=rev
>> Log:
>> Followup to r1874093, add Windows-specific argument escaping
Thanks for reviewing! You're quite the savior of this branch :)
On 27.01.2021 11:02, Johan Corveleyn wrote:
> was wondering what you meant by "This error is easily seen
> when running JavaHL tests"
If you checkout r1882518, tests die with 'Bad global or local ref passed
to JNI' before this erro
On Mon, Mar 16, 2020 at 5:11 AM wrote:
>
> Author: jamessan
> Date: Mon Mar 16 04:11:36 2020
> New Revision: 1875230
>
> URL: http://svn.apache.org/viewvc?rev=1875230&view=rev
> Log:
> Followup to r1874093, add Windows-specific argument escaping
>
> Rather than directly using apr_pescape_shell(),
On Fri, Dec 18, 2020 at 1:51 AM Nathan Hartman wrote:
>
> On Thu, Dec 17, 2020 at 7:00 PM Johan Corveleyn wrote:
> > Just as a heads up: I was ready to vote for an approve r1880192 (issue
> > #4862 -- Merge: the resulting mergeinfo is non-deterministic) for
> > 1.14.x, but as Yasuhito also discov
Daniel Sahlberg wrote on Wed, Jan 27, 2021 at 08:57:01 +0100:
> Also
> the error number is different E720003 but the message is the same).
(Just making sure you're aware of tools/dev/which-error.py.)
> My feeling is that this is a fairly uncommon error and I wonder about the
> cost of having an e
Karl Fogel wrote on Tue, Jan 26, 2021 at 22:18:25 -0600:
> If it passes the test suite, and you don't see any obvious further to the
> patch, I'll commit. Thanks again for your help, Daniel!
You're welcome. I see only a few more nits; see below. (Some of them I
noticed in the first iteration to
On Thu, Oct 15, 2020 at 12:12 PM wrote:
>
> Author: amiloslavskiy
> Date: Thu Oct 15 10:12:52 2020
> New Revision: 1882518
>
> URL: http://svn.apache.org/viewvc?rev=1882518&view=rev
> Log:
> JavaHL: Introduce tests showing JVM crashes with TunnelAgent
>
> The crashes will be addressed in subsequen
On Wed, Jan 27, 2021 at 11:03 AM Thomas Singer
wrote:
>
> Hi Johan,
>
> Yes, I mean those of Alex' patches that hang around in pending state
> since October. Thank you for reviewing them.
>
> I'm not sure whether other patches from Alex from August
>
> - [PATCH] Fix JavaHL crash in RequestChannel.
On Wed, Jan 27, 2021 at 2:40 AM Johan Corveleyn wrote:
>
> On Tue, Jan 26, 2021 at 9:56 PM Johan Corveleyn wrote:
> >
> > On Tue, Jan 26, 2021 at 7:43 PM Alexandr Miloslavskiy
> > wrote:
> > >
> > > On 25.01.2021 1:55, Johan Corveleyn wrote:
> > >
> > > > As an update: I've started looking into
On 27.01.2021 11:13, Johan Corveleyn wrote:
On Thu, Oct 15, 2020 at 12:16 PM wrote:
Author: amiloslavskiy
Date: Thu Oct 15 10:15:47 2020
New Revision: 1882522
URL: http://svn.apache.org/viewvc?rev=1882522&view=rev
Log:
JavaHL: Fix crash in TunnelAgent.CloseTunnelCallback after GC
When jobject
On Thu, Oct 15, 2020 at 12:16 PM wrote:
>
> Author: amiloslavskiy
> Date: Thu Oct 15 10:16:39 2020
> New Revision: 1882523
>
> URL: http://svn.apache.org/viewvc?rev=1882523&view=rev
> Log:
> JavaHL: Fix crash when TunnelAgent continues reading after being closed
>
> The problem here is that when '
On Thu, Oct 15, 2020 at 12:16 PM wrote:
>
> Author: amiloslavskiy
> Date: Thu Oct 15 10:15:47 2020
> New Revision: 1882522
>
> URL: http://svn.apache.org/viewvc?rev=1882522&view=rev
> Log:
> JavaHL: Fix crash in TunnelAgent.CloseTunnelCallback after GC
>
> When jobject reference is kept across dif
On Thu, Oct 15, 2020 at 12:14 PM wrote:
>
> Author: amiloslavskiy
> Date: Thu Oct 15 10:14:30 2020
> New Revision: 1882520
>
> URL: http://svn.apache.org/viewvc?rev=1882520&view=rev
> Log:
> JavaHL: Fix 'JNI call made with exception pending' error
>
> It is incorrect to call Java method with 'Call
Hi Johan,
Yes, I mean those of Alex' patches that hang around in pending state
since October. Thank you for reviewing them.
I'm not sure whether other patches from Alex from August
- [PATCH] Fix JavaHL crash in RequestChannel.nativeRead
- [PATCH] Fix JavaHL crash in TunnelAgent.CloseTunnelCal
On Wed, Jan 27, 2021 at 10:30 AM Thomas Singer
wrote:
>
> Please include Alexandr Miloslavskii's JavaHL fixes with SVN 1.14.1.
> Thanks in advance.
Yep, working on it :-). I assume you're referring to the
javahl-1.14-fixes branch, which he pointed to in the dev@ thread with
subject "A series of J
Please include Alexandr Miloslavskii's JavaHL fixes with SVN 1.14.1.
Thanks in advance.
--
Best regards,
Thomas Singer
On 2021-01-22 14:36, Stefan Sperling wrote:
I am volunteering to prepare release artifacts for new 1.14 and
1.10 releases soon. Hopefully, these artifacts will be up for
test
On 2021/01/27 16:30, Karl Fogel wrote:
> On 26 Jan 2021, Daniel Shahaf wrote:
>> +1 to using sys.executable. Fixing the quoting while in there would be
>> nice to have, but as it's not a regression it's not a blocker either.
>> Happy to leave the details to you.
>
> Well, things turn out to be a
30 matches
Mail list logo
