On Thu, Jul 30, 2020 at 9:56 PM Daniel Shahaf
wrote:
> Nathan Hartman wrote on Thu, 30 Jul 2020 19:17 -0400:
> > On Wed, Jul 29, 2020 at 6:28 PM Daniel Shahaf
> > wrote:
> > > Nathan Hartman wrote on Tue, 28 Jul 2020 10:42 -0400:
> > > > Committed in r1880374.
> > >
> > > Thanks. Nominate these
Nathan Hartman wrote on Thu, 30 Jul 2020 19:17 -0400:
> On Wed, Jul 29, 2020 at 6:28 PM Daniel Shahaf
> wrote:
> > Nathan Hartman wrote on Tue, 28 Jul 2020 10:42 -0400:
> > > Committed in r1880374.
> >
> > Thanks. Nominate these for backport?
> >
> > My +1 on the FSFS part for 1.14.x. (ENOTI
On 2020/07/30 22:20, C. Michael Pilato wrote:
> The patch seems to work pretty well (for svn_repos_fs_commit_txn), but
> there are two issues I have with it.
>
> First, unless I'm mistaken, there's no way to get the conflict_p back as
> part of the 2-tuple return value -- if there's a conflict,
>
On Wed, Jul 29, 2020 at 6:28 PM Daniel Shahaf
wrote:
> Nathan Hartman wrote on Tue, 28 Jul 2020 10:42 -0400:
> > Committed in r1880374.
>
> Thanks. Nominate these for backport?
>
> My +1 on the FSFS part for 1.14.x. (ENOTIME to review the FSX part
> currently.)
For FSFS, +1.
For FSX, I'd like
The patch seems to work pretty well (for svn_repos_fs_commit_txn), but
there are two issues I have with it.
First, unless I'm mistaken, there's no way to get the conflict_p back as
part of the 2-tuple return value -- if there's a conflict,
svn.repos.fs_commit_txn() is going to raise an Exception.
Julian Foad wrote on Thu, 30 Jul 2020 09:11 +00:00:
> (Off the top of my head, did sub tests 1-8 fail with "already locked"
> and 9 is the odd one out?)
In the file "output" inside the tarball you sent, yes. I haven't run
the tests on my machine.
Thanks for the response, Daniel. I'm away and it will be a few days before I
can check and respond completely.
(Off the top of my head, did sub tests 1-8 fail with "already locked" and 9 is
the odd one out?)
30 Jul 2020 00:00:32 Daniel Shahaf :
> (I wasn't going to comment on this since I don't
On 2020/07/30 17:47, Yasuhito FUTATSUKI wrote:
> On 2020/07/29 23:43, C. Michael Pilato wrote:
>> Makes sense to me as a way to get access to all the things that can be
>> returned in an errorful situation.
>
> Okey, I implemented it. The attached patch add "conflict_p" and "new_rev"
> attributes
On 2020/07/29 23:43, C. Michael Pilato wrote:
> Makes sense to me as a way to get access to all the things that can be
> returned in an errorful situation.
Okey, I implemented it. The attached patch add "conflict_p" and "new_rev"
attributes to SubversionException instance on svn_fs.commit_txn and
9 matches
Mail list logo
