Re: FSFS commit failure should release txn proto-rev lock

2020-07-29 Thread Daniel Shahaf
(I wasn't going to comment on this since I don't know this part of the code too well, but given the crickets…) So, the undesired behaviour is this: > This commit failed unexpectedly: > Traceback (most recent call last): > File > "/home/julianfoad/tmp/svn/wd-nv-7983/test-release-proto-rev-lock-

Re: [PATCH] Fix harmless uninitialized read in svn_fs_fs__l2p_index_append

2020-07-29 Thread Daniel Shahaf
Nathan Hartman wrote on Tue, 28 Jul 2020 10:42 -0400: > On Mon, Jul 27, 2020 at 3:28 AM Daniel Shahaf wrote: > > Nathan Hartman wrote on Mon, 27 Jul 2020 03:29 +00:00: > > > I've reviewed the first one so far. In reviewing, my concern was > > > whether changing the order of the expressions could

Re: Python bindings API confusion

2020-07-29 Thread C. Michael Pilato
Makes sense to me as a way to get access to all the things that can be returned in an errorful situation. On Wed, Jul 29, 2020 at 7:17 AM Yasuhito FUTATSUKI wrote: > On 2020/07/29 7:45, Yasuhito FUTATSUKI wrote: > > On 2020/07/29 1:02, Yasuhito FUTATSUKI wrote: > >> On 2020/07/28 23:34, C. Micha

Re: Python bindings API confusion

2020-07-29 Thread Yasuhito FUTATSUKI
On 2020/07/29 7:45, Yasuhito FUTATSUKI wrote: > On 2020/07/29 1:02, Yasuhito FUTATSUKI wrote: >> On 2020/07/28 23:34, C. Michael Pilato wrote: >>> Hey, all. >>> >>> I'm writing some code that performs commits via the Subversion Python >>> bindings, and I'm struggling to understand some things I see