Re: Python bindings API confusion

2020-07-28 Thread Yasuhito FUTATSUKI
On 2020/07/29 1:02, Yasuhito FUTATSUKI wrote: > On 2020/07/28 23:34, C. Michael Pilato wrote: >> Hey, all. >> >> I'm writing some code that performs commits via the Subversion Python >> bindings, and I'm struggling to understand some things I see there. >> >> In the svn_fs.i interface file, there's

Re: Python bindings API confusion

2020-07-28 Thread Yasuhito FUTATSUKI
On 2020/07/28 23:34, C. Michael Pilato wrote: > Hey, all. > > I'm writing some code that performs commits via the Subversion Python > bindings, and I'm struggling to understand some things I see there. > > In the svn_fs.i interface file, there's this block of code: > > /* ---

Re: [PATCH] Fix harmless uninitialized read in svn_fs_fs__l2p_index_append

2020-07-28 Thread Nathan Hartman
On Mon, Jul 27, 2020 at 3:28 AM Daniel Shahaf wrote: > Nathan Hartman wrote on Mon, 27 Jul 2020 03:29 +00:00: > > I've reviewed the first one so far. In reviewing, my concern was > > whether changing the order of the expressions could alter behavior. I > > studied the code paths through svn_fs_fs_

Python bindings API confusion

2020-07-28 Thread C. Michael Pilato
Hey, all. I'm writing some code that performs commits via the Subversion Python bindings, and I'm struggling to understand some things I see there. In the svn_fs.i interface file, there's this block of code: /* --- Fix the re

Re: SVN-4859 (Merge... E155023: can't set properties...)

2020-07-28 Thread Nathan Hartman
On Tue, Jul 28, 2020 at 9:46 AM Julian Foad wrote: > > Nathan Hartman wrote: > > Thanks, Julian! I plan to review items awaiting backport some time > > during the next few days. > > Hi, Nathan. Do you still think you may be able to review this and/or > other nominations? Yes. Apologies for the d

Re: SVN-4859 (Merge... E155023: can't set properties...)

2020-07-28 Thread Julian Foad
Nathan Hartman wrote: Thanks, Julian! I plan to review items awaiting backport some time during the next few days. Hi, Nathan. Do you still think you may be able to review this and/or other nominations? - Julian

Re: FSFS commit failure should release txn proto-rev lock

2020-07-28 Thread Julian Foad
Ping: can anyone comment on this proposed patch? - Julian Julian Foad wrote: CC'ing more possible experts Dmitry, Evgeny: any thoughts about whether this change makes sense for FSFS commit? - Julian Julian Foad wrote: TL;DR: I propose a change to the FSFS commit-transaction function, to r