Re: [PATCH] fix unable to load *.pyd files with Python 3.8.x on Windows

2020-05-09 Thread Jun Omae
On Sun, May 10, 2020 at 1:27 PM Jun Omae wrote: > I created patch to resolve the issue using moduleimport option of %module > directive. > After attached patch, *.pyd file is successfully loaded and tests for Python > bindings pass. Tested with the following environments: - (Python 3.8.2, 3.7

[PATCH] fix unable to load *.pyd files with Python 3.8.x on Windows

2020-05-09 Thread Jun Omae
Hi, I noticed Python bindings is unable to load with Python 3.8.x on Windows, while trying to run check-swig-py. [[[ C:\usr\src\subversion\trunk-py3> python.exe -c "from svn import core; print(core.SVN_VERSION)" Traceback (most recent call last): File "C:\usr\src\subversion\trunk-py3\Release

Re: [PATCH] Fix "database is locked" error when committing during rep-cache.db verification

2020-05-09 Thread Denis Kovalchuk
> What I'm trying to do here is to get a _problem statement_ to which your > patch is a solution, so we can consider other solutions. Partially repeating the first letter from this thread, the problem is the following: if a commit occurs during the rep-cache.db verification, this can lead to a pos

configure --without-swig warns when it shouldn't

2020-05-09 Thread Daniel Shahaf
A minor issue in current trunk: [[[ % …/configure -q --enable-maintainer-mode --without-swig 'RUBY=none' configure: WARNING: Python.h not found; disabling python swig bindings ]]] That warning should not be printed when --without-swig is passed. It's printed by SVN_FIND_SWIG, which _does_ know w

Re: One more issue in tests on Windows with Python 3

2020-05-09 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Fri, 08 May 2020 20:55 +0900: > On 2020/05/08 2:46, Daniel Shahaf wrote: > > Yasuhito FUTATSUKI wrote on Thu, 07 May 2020 20:46 +0900: > >> I think it is need to escape characters in char *value when we print >^some (not all) > >> them