Re: [PATCH] Fix "database is locked" error when committing during rep-cache.db verification

2020-05-01 Thread Daniel Shahaf
Denis Kovalchuk wrote on Sat, 02 May 2020 00:28 +0300: > > So the failure mode is that rep-cache.db entries are not able to be > > added while rep-cache.db is being verified. I am not convinced that > > this is a problem. > > I think that this case leads to multiple problems: > 1) Commits happe

Re: [PATCH] Fix "database is locked" error when committing during rep-cache.db verification

2020-05-01 Thread Denis Kovalchuk
> So the failure mode is that rep-cache.db entries are not able to be > added while rep-cache.db is being verified. I am not convinced that > this is a problem. I think that this case leads to multiple problems: 1) Commits happening at the same time as verify will hang for the duration of sqlite

Re: Grace period for 1.13 users to upgrade to 1.14? (was: svn commit: r1877222 - /subversion/site/publish/docs/release-notes/1.14.html)

2020-05-01 Thread Mark Phippard
On Fri, May 1, 2020 at 4:20 PM Daniel Shahaf wrote: > Mark Phippard wrote on Fri, 01 May 2020 18:26 +00:00: > > > Since we reached the 6 month mark for 1.13 yesterday, that means its > > support will continue until 1.14 is released at which point it is EOL. > > Can we dig down on this point a b

Releasing unidiffs (was: Re: Grace period for 1.13 users to upgrade to 1.14?)

2020-05-01 Thread Daniel Shahaf
Julian Foad wrote on Fri, 01 May 2020 15:58 +: > 1 May 2020 16:39:36 Nathan Hartman : > > > On Thu, Apr 30, 2020 at 12:47 PM Daniel Shahaf < d...@daniel.shahaf.name > > > wrote: > > > > > > > danie...@apache.org wrote on Thu, 30 Apr 2020 16:21 -: > > > > > > > > I just copied th

Re: Grace period for 1.13 users to upgrade to 1.14? (was: svn commit: r1877222 - /subversion/site/publish/docs/release-notes/1.14.html)

2020-05-01 Thread Daniel Shahaf
Mark Phippard wrote on Fri, 01 May 2020 18:26 +00:00: > On Fri, May 1, 2020 at 2:17 PM Daniel Shahaf wrote: > > I'm not asking for special treatment or for changing the policy. I'm > > asking to clarify the policy for the general case of the period of time > > immediately following a 1.(x+1).0

Re: Grace period for 1.13 users to upgrade to 1.14? (was: svn commit: r1877222 - /subversion/site/publish/docs/release-notes/1.14.html)

2020-05-01 Thread Mark Phippard
On Fri, May 1, 2020 at 2:17 PM Daniel Shahaf wrote: > Mark Phippard wrote on Fri, 01 May 2020 11:49 -0400: > > On Thu, Apr 30, 2020 at 12:47 PM Daniel Shahaf > > wrote: > > > > > danie...@apache.org wrote on Thu, 30 Apr 2020 16:21 -: > > > > +++ subversion/site/publish/docs/release-notes/1.1

Re: Grace period for 1.13 users to upgrade to 1.14? (was: svn commit: r1877222 - /subversion/site/publish/docs/release-notes/1.14.html)

2020-05-01 Thread Daniel Shahaf
Mark Phippard wrote on Fri, 01 May 2020 11:49 -0400: > On Thu, Apr 30, 2020 at 12:47 PM Daniel Shahaf > wrote: > > > danie...@apache.org wrote on Thu, 30 Apr 2020 16:21 -: > > > +++ subversion/site/publish/docs/release-notes/1.14.html Thu Apr 30 > > 16:21:48 2020 > > > @@ -1330,6 +1330,

Re: [PATCH] Fix variable declarations in swigutil_py.c

2020-05-01 Thread Daniel Shahaf
Branko Čibej wrote on Fri, 01 May 2020 15:24 +0200: > On 01.05.2020 12:18, Jun Omae wrote: > > Hi, > > > > I got the following syntax errors while building swigutil_py.c in > > trunk with Visual Studio 2008 (VC9). > [...] > > It seems that several variable declarations are not at start of block.

Re: Problems running testsuite on Windows with Python 3

2020-05-01 Thread Yasuhito FUTATSUKI
On 2020/04/23 2:05, Yasuhito FUTATSUKI wrote: > On 2020/04/22 23:04, Johan Corveleyn wrote: >> On Wed, Apr 22, 2020 at 3:50 PM Yasuhito FUTATSUKI >> wrote: > >>> ... and what is worse, at least >>> FAIL: merge_tests.py 34: conflict markers should match the file's eol style >>> >>> t

Re: Grace period for 1.13 users to upgrade to 1.14?

2020-05-01 Thread Julian Foad
In my opinion, although it's "nice" when everyone has clarity on all details of the process, it's just not important to decide this level of detail in advance. It's a fuzzy line and we'll make a reasonable decision if it happens, which it likely won't. Re. issuing fixes as patches, I think ther

Re: Grace period for 1.13 users to upgrade to 1.14? (was: svn commit: r1877222 - /subversion/site/publish/docs/release-notes/1.14.html)

2020-05-01 Thread Mark Phippard
On Thu, Apr 30, 2020 at 12:47 PM Daniel Shahaf wrote: > danie...@apache.org wrote on Thu, 30 Apr 2020 16:21 -: > > +++ subversion/site/publish/docs/release-notes/1.14.html Thu Apr 30 > 16:21:48 2020 > > @@ -1330,6 +1330,20 @@ if they occur. > > + > > +Subversion 1.13.x is end of life > > +

Re: Grace period for 1.13 users to upgrade to 1.14? (was: svn commit: r1877222 - /subversion/site/publish/docs/release-notes/1.14.html)

2020-05-01 Thread Nathan Hartman
On Thu, Apr 30, 2020 at 12:47 PM Daniel Shahaf wrote: > danie...@apache.org wrote on Thu, 30 Apr 2020 16:21 -: > I just copied the text we use for 1.9, but there's a distinction: users > of 1.9 have had time to upgrade to 1.10 before 1.14.0 becomes GA, > whereas users of 1.13 have not. So, s

Re: [PATCH] Fix variable declarations in swigutil_py.c

2020-05-01 Thread Branko Čibej
On 01.05.2020 12:18, Jun Omae wrote: > Hi, > > I got the following syntax errors while building swigutil_py.c in > trunk with Visual Studio 2008 (VC9). [...] > It seems that several variable declarations are not at start of block. > The declarations lead the syntax errors with Visual Studio 2008. >

[PATCH] Fix variable declarations in swigutil_py.c

2020-05-01 Thread Jun Omae
Hi, I got the following syntax errors while building swigutil_py.c in trunk with Visual Studio 2008 (VC9). "C:\usr\src\subversion\trunk\subversion_vcnet.sln" (__MORE__;__SWIG_PYTHON__ target) (1) -> (Libraries\Swig\svn_swig_py target) -> ..\..\..\subversion\bindings\swig\python\libsvn_swig_

[PATCH] Fix unable to build with Visual Studio 2008

2020-05-01 Thread Jun Omae
Hi, I tried to build Subversion 1.10.x and trunk with Visual Studio 2008 for Python (2.7) bindings, however I got the following error from `msbuild subversion_vcnet.sln /t:__MORE__ /p:Configuration=Release`. "C:\usr\src\subversion\1.10.x\subversion_vcnet.sln" (__MORE__;__SWIG_PYTHON__ target)