Re: svn commit: r1875921 - in /subversion/trunk: subversion/include/ subversion/include/private/ subversion/libsvn_fs_fs/ subversion/svnadmin/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/

2020-03-31 Thread Daniel Shahaf
Daniel Shahaf wrote on Tue, 31 Mar 2020 09:23 +00:00: > Please add a docstring. I've gone ahead and added this to STATUS so it doesn't slip through any cracks. Feel free to remove the -0 vote once it's been addressed (you needn't round-trip through me for this).

Re: [PATCH] svnadmin build-repcache command

2020-03-31 Thread Stefan Sperling
On Tue, Mar 31, 2020 at 01:35:54PM +0300, Denis Kovalchuk wrote: > > This has caused a test failure on the windows buildbot: > > > > https://ci.apache.org/builders/svn-windows-local/builds/3392/steps/Test%20fsfs%2Blocal/logs/faillog > > > > Can you please check what we should do about that? > > I

Re: [PATCH] svnadmin build-repcache command

2020-03-31 Thread Denis Kovalchuk
> This has caused a test failure on the windows buildbot: > > https://ci.apache.org/builders/svn-windows-local/builds/3392/steps/Test%20fsfs%2Blocal/logs/faillog > > Can you please check what we should do about that? I missed SkipUnless test decorator. The build_repcache() test should be skipped i

Re: [PATCH] svnadmin build-repcache command

2020-03-31 Thread Stefan Sperling
On Tue, Mar 31, 2020 at 10:55:07AM +0200, Stefan Sperling wrote: > On Tue, Mar 24, 2020 at 07:53:21PM +0300, Denis Kovalchuk wrote: > > Introduce 'svnadmin build-repcache' command. > > Committed in r1875921. Thanks! This has caused a test failure on the windows buildbot: https://ci.apache.org/bu

Re: svn commit: r1875921 - in /subversion/trunk: subversion/include/ subversion/include/private/ subversion/libsvn_fs_fs/ subversion/svnadmin/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/

2020-03-31 Thread Daniel Shahaf
s...@apache.org wrote on Tue, 31 Mar 2020 08:53 -: > +++ subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c Tue Mar 31 08:53:55 2020 > @@ -2343,3 +2344,168 @@ svn_fs_fs__info_config_files(apr_array_h > } > + > +static svn_error_t * > +ensure_representation_sha1(svn_fs_t *fs, > +

Re: [PATCH] svnadmin build-repcache command

2020-03-31 Thread Stefan Sperling
On Tue, Mar 24, 2020 at 07:53:21PM +0300, Denis Kovalchuk wrote: > Introduce 'svnadmin build-repcache' command. Committed in r1875921. Thanks! I will now nominate both patches for backport to 1.14.x.

Re: [PATCH] rep-cache.db insert optimization (was: Re: [PATCH] svnadmin build-repcache command)

2020-03-31 Thread Stefan Sperling
On Mon, Mar 30, 2020 at 11:40:38PM +0300, Denis Kovalchuk wrote: > rep-cache.db insert optimization. Committed in r1875918. Thank you!