Re: svn commit: r1875312 - /subversion/site/publish/docs/release-notes/1.14.html

2020-03-18 Thread Daniel Shahaf
Nathan Hartman wrote on Thu, 19 Mar 2020 00:42 +00:00: > On Wed, Mar 18, 2020 at 8:29 PM Daniel Shahaf wrote: > > (Or we could change the C code > > to add the "--" between the editor command and the filename, but that might > > break somebody's proverbial spacebar heating.) > > I don't think we

Re: svn commit: r1875312 - /subversion/site/publish/docs/release-notes/1.14.html

2020-03-18 Thread Nathan Hartman
On Wed, Mar 18, 2020 at 8:29 PM Daniel Shahaf wrote: > Nathan Hartman wrote on Wed, 18 Mar 2020 23:59 +00:00: > > For example, suppose that $SVN_EDITOR is set as follows: > > > > SVN_EDITOR='vim -N' > > export SVN_EDITOR > > > > Should this read «SVN_EDITOR='vim -N --'»? Probably. Else, a fi

Re: svn commit: r1875312 - /subversion/site/publish/docs/release-notes/1.14.html

2020-03-18 Thread Daniel Shahaf
Nathan Hartman wrote on Wed, 18 Mar 2020 23:59 +00:00: > On Wed, Mar 18, 2020 at 2:42 PM Daniel Shahaf wrote: > > Nathan Hartman wrote on Wed, 18 Mar 2020 13:42 -0400: > > > On Tue, Mar 17, 2020 at 3:50 PM Daniel Shahaf > > > wrote: > > > > Suggest to say "When invoking the user-defined editor",

Re: svn commit: r1875312 - /subversion/site/publish/docs/release-notes/1.14.html

2020-03-18 Thread Nathan Hartman
On Wed, Mar 18, 2020 at 2:42 PM Daniel Shahaf wrote: > Nathan Hartman wrote on Wed, 18 Mar 2020 13:42 -0400: > > On Tue, Mar 17, 2020 at 3:50 PM Daniel Shahaf > > wrote: > > > Suggest to say "When invoking the user-defined editor", with or without > > > listing some of the ways in which the edit

Re: svn commit: r1875312 - /subversion/site/publish/docs/release-notes/1.14.html

2020-03-18 Thread Daniel Shahaf
Nathan Hartman wrote on Wed, 18 Mar 2020 13:42 -0400: > On Tue, Mar 17, 2020 at 3:50 PM Daniel Shahaf wrote: > > hartmannat...@apache.org wrote on Tue, 17 Mar 2020 18:36 -: > > > +When invoking the user-defined $SVN_EDITOR, such as during > > > > The editor may be configured in other ways:

Re: svn commit: r1875312 - /subversion/site/publish/docs/release-notes/1.14.html

2020-03-18 Thread Nathan Hartman
On Tue, Mar 17, 2020 at 3:50 PM Daniel Shahaf wrote: > hartmannat...@apache.org wrote on Tue, 17 Mar 2020 18:36 -: > > +When invoking the user-defined $SVN_EDITOR, such as during > > The editor may be configured in other ways: --editor-cmd, > --config-option=…:editor-cmd, $EDITOR. > > Suggest

Re: [PATCH] svnadmin build-repcache command

2020-03-18 Thread Julian Foad
Denis Kovalchuk wrote: I would like to suggest an implementation of ‘svnadmin build-repcache’ command Thank you for contributing this enhancement! I agree this is a useful and appropriate feature. - Julian

Re: [PATCH] svnadmin build-repcache command

2020-03-18 Thread Daniel Shahaf
Denis Kovalchuk wrote on Wed, 18 Mar 2020 17:32 +0300: > +++ subversion/include/private/svn_fs_fs_private.h(working copy) > @@ -353,6 +353,16 @@ Please use the -p option to diff. > +typedef struct svn_fs_fs__ioctl_build_rep_cache_input_t > +{ > + svn_revnum_t start_rev; > + svn_revnum_t end

[PATCH] svnadmin build-repcache command

2020-03-18 Thread Denis Kovalchuk
Hello. I would like to suggest an implementation of ‘svnadmin build-repcache’ command that allows to process data in the specified revision range and add missing entries to the representation cache. It may be useful for admins who had disabled the rep-sharing option or deleted the rep-cache.db