Re: svn commit: r1874057 - in /subversion/trunk/subversion: libsvn_subr/cmdline.c tests/cmdline/update_tests.py

On Sun, Feb 16, 2020 at 10:06:49AM -0500, James McCoy wrote: > On Sun, Feb 16, 2020 at 09:59:53AM +, Daniel Shahaf wrote: > > James McCoy wrote on Sat, 15 Feb 2020 13:10 -0500: > > > Well, that makes this more involved... I guess the simplest option is to > > > do our own scan of the string and

Re: svn commit: r1874057 - in /subversion/trunk/subversion: libsvn_subr/cmdline.c tests/cmdline/update_tests.py

James McCoy wrote on Sun, 16 Feb 2020 10:06 -0500: > However, the svn-x64-macosx-apr1.3-nothread buildbot informed me that > apr_pescape_shell() isn't available in that version. It wasn't added > until 1.5.0. > > Now we need to either: > > a) Raise the minimum APR version apr 1.5.0 was tagged o

Re: svn commit: r1874057 - in /subversion/trunk/subversion: libsvn_subr/cmdline.c tests/cmdline/update_tests.py

On Sun, Feb 16, 2020 at 09:59:53AM +, Daniel Shahaf wrote: > James McCoy wrote on Sat, 15 Feb 2020 13:10 -0500: > > Well, that makes this more involved... I guess the simplest option is to > > do our own scan of the string and pre-escape any whitespace before > > having apr_pescape_shell() hand

Re: svn commit: r1874057 - in /subversion/trunk/subversion: libsvn_subr/cmdline.c tests/cmdline/update_tests.py

James McCoy wrote on Sat, 15 Feb 2020 13:10 -0500: > Well, that makes this more involved... I guess the simplest option is to > do our own scan of the string and pre-escape any whitespace before > having apr_pescape_shell() handle the rest. If we did that, apr_pescape_shell() would re-escape the b