On Wed, Oct 9, 2019 at 7:14 PM Daniel Shahaf wrote:
>
> Branko Čibej wrote on Wed, Oct 09, 2019 at 15:45:32 +0200:
> > On 09.10.2019 15:00, Johan Corveleyn wrote:
> > > During that entire discussion thread the only objections raised were
> > > about "enforcing it in the repos layer / server direct
Evgeny Kotkov writes:
> Apparently, there is a bug in the implementation of --normalize-props
> that only makes it automatically fix line endings in the values of the
> revision properties, but not node properties (as per the code around
> load-fs-vtable.c: set_node_property()).
I think that thi
On 09.10.2019 19:14, Daniel Shahaf wrote:
> The FS layer exposes
> a filesystem that's a 0-indexed array of trees [implemented by the DAG layer].
> The repos layer does… what, exactly, on top of that?
I've been asking that from day one. :) All that API duplication, which
is incomplete to boot, is
Branko Čibej wrote on Wed, Oct 09, 2019 at 15:45:32 +0200:
> On 09.10.2019 15:00, Johan Corveleyn wrote:
> > During that entire discussion thread the only objections raised were
> > about "enforcing it in the repos layer / server directly". No-one
> > objected to the proposal(s) to solve the issue
Julian Foad wrote on Wed, 09 Oct 2019 15:13 +00:00:
> * [SVN-4065] Redefine as:
>"Write a pre-commit hook to reject non-conforming eol-style=native."
>Put it in 'tools/hook-scripts/'.
...
> The redefined SVN-4065 could be a suitable hackathon task.
Isn't writing `svnlook changed -t $TXN |
I suggest there are three issues mixed up here:
* [SVN-4065] Redefine as:
"Write a pre-commit hook to reject non-conforming eol-style=native."
Put it in 'tools/hook-scripts/'.
* [new issue]
Review/organize the set of recommended/suggested hooks.
See 'tools/hook-scripts/'. See what categ
Johan Corveleyn wrote:
Julian Foad wrote:
Johan Corveleyn wrote:
I think that was the conclusion from those threads. I.e. it would be
best if we developed a standard "svnhooks" program that can be invoked
from the pre-commit hook (and not try to implement this directly in
the repos layer). At l
On 09.10.2019 15:00, Johan Corveleyn wrote:
> During that entire discussion thread the only objections raised were
> about "enforcing it in the repos layer / server directly". No-one
> objected to the proposal(s) to solve the issue via pre-commit hooks.
Validating contents (such as line endings ba
Branko Čibej wrote:
The repos layer to a large extent transparent to properties and their
values, though not so much: it has some validation and even
"normalization" of "svn:" property names and values. I feel this is
generally Bad; there is some room for repos-layer knowledge of
properties but
On Wed, Oct 9, 2019 at 11:41 AM Julian Foad wrote:
>
> Johan Corveleyn wrote:
> > I think that was the conclusion from those threads. I.e. it would be
> > best if we developed a standard "svnhooks" program that can be invoked
> > from the pre-commit hook (and not try to implement this directly in
On 09.10.2019 11:50, Julian Foad wrote:
> Julian Foad wrote:
>> If we want to change this to a repository-level rule, then that
>> implies we are changing the repository semantics in a
>> backward-incompatible way and we would need to address that (using a
>> format number bump, and an upgrade/migr
Julian Foad wrote:
If we want to change this to a repository-level rule, then that implies
we are changing the repository semantics in a backward-incompatible way
and we would need to address that (using a format number bump, and an
upgrade/migration path). We could discuss that path but I don
Johan Corveleyn wrote:
I think that was the conclusion from those threads. I.e. it would be
best if we developed a standard "svnhooks" program that can be invoked
from the pre-commit hook (and not try to implement this directly in
the repos layer). At least, after those svnhooks suggestions no-on
On Tue, Oct 8, 2019 at 6:13 PM Julian Foad wrote:
> Daniel Shahaf wrote:
> > SVN-4065 - server should enforce LF normalization for svn:eol-
> > style=native files. (Not just a patch is needed, but also a FAQ entry
> > that explains how to handle existing repositories that have this
> > problem, on
14 matches
Mail list logo
