Re: extending the blame callback

[Daniel Shahaf] > The current patch's docstring implies the LF byte is necessarily part > of a line terminator, which is true for UTF-8/16/32 but not > necessarily true in arbitrary encodings. Nitpick: It is true in UTF-8, but not -16 or -32. There are about 70 characters in the BMP which, in U

Re: extending the blame callback

On 07.01.2019 19:58, Daniel Shahaf wrote: Stefan Kueng wrote on Mon, 07 Jan 2019 19:30 +0100: On 06.01.2019 21:09, Daniel Shahaf wrote: Stefan Kueng wrote on Sun, Jan 06, 2019 at 20:40:28 +0100: @@ -758,6 +759,33 @@ * will be true if the reason there is no blame information is that the l

Re: extending the blame callback

Stefan Kueng wrote on Mon, 07 Jan 2019 19:30 +0100: > On 06.01.2019 21:09, Daniel Shahaf wrote: > > Stefan Kueng wrote on Sun, Jan 06, 2019 at 20:40:28 +0100: > >> @@ -758,6 +759,33 @@ > >>* will be true if the reason there is no blame information is that the > >> line > >>* was modified l

Re: extending the blame callback

On 07.01.2019 19:56, Branko Čibej wrote: On Mon, 7 Jan 2019, 19:30 Stefan Kueng wrote: I think for proper C, all variables need to be declared at the start of the function. Unless of course svn allows newer C versions? Not "the start of the function"

Re: extending the blame callback

On Mon, 7 Jan 2019, 19:30 Stefan Kueng > I think for proper C, all variables need to be declared at the start of > the function. Unless of course svn allows newer C versions? > Not "the start of the function" but "before any statements in the enclosing block." It has been that way since the begin

Re: extending the blame callback

the attached patch has some corrections to the doc strings. If there are no objections, I'll commit this tomorrow. Also see inline comments: On 06.01.2019 21:09, Daniel Shahaf wrote: Stefan Kueng wrote on Sun, Jan 06, 2019 at 20:40:28 +0100: +++ subversion/include/svn_client.h (working cop

Re: [PATCH] fix use-after-free in mod_dav_svn's log_warning()

On Tue, Dec 18, 2018 at 10:15:56AM +0100, Stefan Sperling wrote: > On Tue, Dec 18, 2018 at 03:55:42AM +0100, Stefan Fuhrmann wrote: > > Error handling during tear-down is always a bit messy. > > > > I guess not using the request struct will mean we cannot > > tell what operation cased a problem -

Subversion 1.9.10 up for testing/signing

The 1.9.10 release artifacts are now available for testing/signing. Please get the tarballs from https://dist.apache.org/repos/dist/dev/subversion and add your signatures there. Thanks! -- - Julian

Subversion 1.11.1 up for testing/signing

The 1.11.1 release artifacts are now available for testing/signing. Please get the tarballs from https://dist.apache.org/repos/dist/dev/subversion and add your signatures there. Thanks! -- - Julian

Subversion 1.10.4 up for testing/signing

The 1.10.4 release artifacts are now available for testing/signing. Please get the tarballs from https://dist.apache.org/repos/dist/dev/subversion and add your signatures there. Thanks! -- - Julian

Re: extending the blame callback

I reviewed the patch 'blame6_5.patch'. It all looks fine, functionally. I think it provides a good upgrade for any user of the API, even though I don't really think using it to process UTF-16 data is a very good idea. The only part of the patch I'd like to see changed is the comment about "the