Re: thoughts about shelving

2018-09-15 Thread Julian Foad
Julian Foad wrote: > Greg Stein wrote: >> When I envisioned the implementation of shelving, I figured that we would >> use the sql database to its best effect. Let me be more concrete. >> Store new pristines (which is logically just key->fulltext). Pristine file texts add up to a large fractio

Re: thoughts about shelving

2018-09-15 Thread Julian Foad
Stefan Kueng wrote: > A few more thought, mostly for the next release: > > * svn_client_shelf_save_new_version3 takes two callback functions, but > they both have the same type. So why not just change that API to take > one callback but provide a 'failed' flag instead? Could do! I suppose that

Re: thoughts about shelving

2018-09-15 Thread Stefan Kueng
A few more thought, mostly for the next release: * svn_client_shelf_save_new_version3 takes two callback functions, but they both have the same type. So why not just change that API to take one callback but provide a 'failed' flag instead? * when a shelve operation fails, we have to remove th

Re: thoughts about shelving

2018-09-15 Thread Julian Foad
Julian Foad wrote: > [...] Flat files (no longer flat files) are easier to mess with at > this stage. I meant, "Flat files (no longer patch files)...". - Julian

Re: thoughts about shelving

2018-09-15 Thread Julian Foad
Greg Stein wrote: > When I envisioned the implementation of shelving, I figured that we > would use the sql database to its best effect. Store new pristines > (which is logically just key->fulltext). Maybe create an artificial > wc_id to construct an alternate tree of ACTUAL_NODE entries where you

Re: API review for 1.11; do we need to mark new APIs as experimental?

2018-09-15 Thread Greg Stein
On Thu, Sep 13, 2018 at 10:24 AM Branko Čibej wrote: > On 13.09.2018 17:11, Julian Foad wrote: > > Julian Foad wrote: > >> [...] Are we saying now > >> that they need not be specifically marked if we feel they are pretty > >> safe? If we say that, then marking specific APIs as "experimental" in a

Re: thoughts about shelving

2018-09-15 Thread Greg Stein
On Sat, Sep 15, 2018 at 4:03 AM Julian Foad wrote: >... > > * when users update to the new version, existing shelves can't be used > > anymore since they're not compatible. Is there a way to convert the old > > shelves to the new format? If not then that means users would lose those > > saved she

Re: thoughts about shelving

2018-09-15 Thread Julian Foad
Stefan Kueng wrote on 2018-09-15: > Hi, > > I know I'm a little bit late, but now I'm implementing the new shelf > APIs in TSVN so it's now that I have some thoughts and suggestions: > > * there are deprecated APIs already, even though they weren't there in > 1.10.0, for example svn_client

thoughts about shelving

2018-09-15 Thread Stefan Kueng
Hi, I know I'm a little bit late, but now I'm implementing the new shelf APIs in TSVN so it's now that I have some thoughts and suggestions: * there are deprecated APIs already, even though they weren't there in 1.10.0, for example svn_client_shelf_save_new_version - since they're all new in