Re: Next stable releases

2018-07-12 Thread Julian Foad
Philip Martin wrote: > [...] a user recently reported another regression > [...] I'd like to delay 1.10.1 for a few days [...] My time is currently allocated to rolling a release of the good fixes we already have. In a few days I will be busy with something else, then going on vacation, and befo

Re: Next stable releases

2018-07-12 Thread Philip Martin
Julian Foad writes: > Julian Foad wrote: >> Philip Martin wrote on 2018-06-05: >> > It's time to consider 1.9.8 and 1.10.1. >> >> I can prepare these releases. Please nominate/review/vote on backports. > > I plan to roll these releases on Thursday. One of the reasons for 1.10.1 was to fix the a

Re: [PATCH] Fix segfault when gnome keyring lookup fails

2018-07-12 Thread Daniel Shahaf
Jan Palus wrote on Thu, 12 Jul 2018 20:23 +0200: > On 12.07.2018 15:08, Daniel Shahaf wrote: > > Thanks for the patch; however, I don't think that's the correct fix. > > To be honest I wasn't sure of that either but on the other hand I thought that > having initialized state won't hurt. > Initi

Re: [PATCH] Fix segfault when gnome keyring lookup fails

2018-07-12 Thread Philip Martin
Jan Palus writes: > On 12.07.2018 15:08, Daniel Shahaf wrote: >> Thanks for the patch; however, I don't think that's the correct fix. > > To be honest I wasn't sure of that either but on the other hand I thought that > having initialized state won't hurt. > >> Does the following patch fix the p

Re: [PATCH] Fix segfault when gnome keyring lookup fails

2018-07-12 Thread Jan Palus
On 12.07.2018 15:08, Daniel Shahaf wrote: > Thanks for the patch; however, I don't think that's the correct fix. To be honest I wasn't sure of that either but on the other hand I thought that having initialized state won't hurt. > Does the following patch fix the problem? Speaking of which, cou

Re: [PATCH] Fix segfault when gnome keyring lookup fails

2018-07-12 Thread Daniel Shahaf
Jan Palus wrote on Wed, Jul 11, 2018 at 13:46:35 +0200: > [[[ > Fix segfault when subversion is built with gnome keyring support and keyring > password lookup fails. > > * subversion/libsvn_subr/simple_providers.c > (svn_auth__simple_creds_cache_get): Initialize 'done' with FALSE since ie >

Re: [PATCH] can't "svn patch" working copy root if the patch is in --git format

2018-07-12 Thread Julian Foad
Dmitry Pavlenko wrote: > > ... would you mind making a regression test? ... > OK, I could do that, but much later, in 2 weeks maybe... Thanks. I think we should commit your fix anyway, but better if we can also fix the 'svn diff' output and also add a test or two. I am thinking two tests would m